GNOME Bugzilla – Bug 116482
merge favicon and address entry into a single action
Last modified: 2005-01-13 23:54:19 UTC
Its pretty silly having a seperate action for the favicon, should just merge it with the address entry. For bonus points turn off the frame on the entry, set the bg color of the icon to that of a text entry and wrap the whole widget in gtk_frame so that it looks like the icon is in the text entry :)
Sorry for the spam. Reassigning bugs with a target to our next milestone.
Entry has a particular height allocation, try it in glade. So I'm not sure if this is possible ...
I've done this in glade i think it works ok. Ideally the new combo would provide the api to do this for us no? Whats the status of kris combo will it make it into gtk 2.4?
Yeah the combo will likely be another issue, I dont think it will be possible to have the frame only on the entry. Kris combo will make 2.4 yeah, nearly ready to go in. Who use the dropdown anyway :P
Marco, Should we wait for gtk to do this or do you expect that this is too browser centric? If not we can add an icon to ephy-location-entry and merge the necessary bits from ephy-favicon-action and ephy-location-action. I'm willing to do the work if we think its the right solution.
I think that if we can get it to work correctly without gtk changes it's even better. I dont expect much apps to use it. Though if it's not possible, then I'd like if gtk would support it.
well my propose hack is the following: 1. turn off the frame of gtkentry via gtkentry public api. 2. pack an hbox with a gtkimage and a gtkentry. 3. pack the hbox in a gtkframe 4. set the bg color of the gtkimage to that of the gtkentry. and monitor theme changes as we do in other parts of ephy. drawbacks. There is only on drawback to not adding the image to gtk entry itself imo. To the best of my knowledge if we add icons to the drop down at some point in the future we will not be able to align the icons to the entry icon as is done in IE so we will end up with something like this. [icon][entry ] [icon comletion ] [icon completion ] I'm not sure if this is a big deal or not. I guess this also begs the question, would icons in the dropdown really be useful. anyway let me know what you think.
About implementation I'm worried entry size allocation will create problems, but we should try. About the drawback, probably not alignement will look ugly (also without icons).
Created attachment 20973 [details] [review] a spinning favicon action
Since combining the favicon+spinner into the entry depends on gtk+ changes, I think we can as a first step combine the favicon and the spinner and thus get rid of the spinner on the mini-toolbar.
chpe rock on!
Christian I'll try this out tomorrow.
I think we should try to do an effort to decide the whole changes in feedback for 1.2. Frankly I'm a bit confused by all the proposals has been made ...
WONTFIX.
Why is this wontfix other than we think this should be done in gtk first?
What about making it a dup of the merge icons/entry bug ?
I thought this is the bug about merging entry and icon?
Right, I read way too many bugs tonight. It make sense to keep it open then. Btw did you find libgalago code ?
Yes, crispin found it @ freedesktop cvs. I've already tried it, and it works. But dnd from the icon is impossible :(
Created attachment 23783 [details] screenshot of live proof-of-concept impl
Argh it sucks badly that we are in feature freeze :/ Maybe dnd can be made work in some way ? Do you have an url btw ? I'd like to take a look at it.
http://freedesktop.org/cgi-bin/viewcvs.cgi/galago/libgalago-gtk/libgalago-gtk/ I'm going to attach my code in a moment. I don't think dnd can be done easily... if I read the code correctly, you can set a GtkImage as icon, but it just uses the image's GdkPixbuf, and does not pack the image widget itself in the entry.
Created attachment 23784 [details] [review] proof-of-concept implementation
Mass-moving Targe Milestone 1.4 -> 1.6 due to feature, UI and string freeze.
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
Fixed in cvs, pretty much as outlined in comment 7. We decided the fact that the drop-down doesn't align under the icon was a minor issue not worth holding this up. We should make sure next gtk+ version has real support for this (bug 85292).