After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 110115 - Outline misplaced when dragging a selection
Outline misplaced when dragging a selection
Status: VERIFIED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other Linux
: Normal minor
: 1.2
Assigned To: GIMP Bugs
GIMP Bugs
: 110515 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-04-06 17:28 UTC by Pedro Gimeno
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes the misplacement of the selection outline and a text inconsistency (926 bytes, patch)
2003-04-06 17:30 UTC, Pedro Gimeno
none Details | Review

Description Pedro Gimeno 2003-04-06 17:28:11 UTC
When a selection is dragged, so that a floating selection is created, the
first time it is moved causes a misplacement of the outline that represents
the selection.

How to reproduce:

 1. Create an empty image.
 2. Add Alpha channel to the background layer.
 3. Zoom in to, say, 4:1 to see it better.
 4. Create a, say, rectangular selection.
 5. Drag the selection with the mouse.

The selection outline is now visibly misplaced with respect to the
selection itself. This is quite annoying when trying to move the selection
with pixel precision.

The patch below solves this issue, though in a perhaps quesionable way. At
the same time, it gives a trivial fix to an inconsistency of a text in the
same file (not reported AFAIK): the undo description for the "move
selection mask" text was different when dragging with the mouse and when
dragging with the keyboard. I didn't think this deserved a separate report.
Comment 1 Pedro Gimeno 2003-04-06 17:30:48 UTC
Created attachment 15516 [details] [review]
Fixes the misplacement of the selection outline and a text inconsistency
Comment 2 Sven Neumann 2003-04-07 09:19:20 UTC
I don't think the text should say "Move Selection Mask". For the user,
a selection is just a selection and she shouldn't have to care about
the internal representation. So it's probably better to change the
term used for keyboard editing.
Comment 3 Michael Natterer 2003-04-07 09:31:45 UTC
Fixed in HEAD. Could be applied to 1.2 as well...

2003-04-07  Michael Natterer  <mitch@gimp.org>

  * app/tools/gimpeditselectiontool.c: applied a (modified) patch
  from Pedro Gimeno that fixes bug #110115.
Comment 4 Sven Neumann 2003-04-07 11:15:35 UTC
Could be considered for 1.2.
Comment 5 Sven Neumann 2003-04-09 11:02:11 UTC
2003-04-09  Sven Neumann  <sven@gimp.org>

	* app/edit_selection.c (edit_selection_motion): merged fix for
	bug #110115 from HEAD branch.
Comment 6 Sven Neumann 2003-04-11 15:16:15 UTC
*** Bug 110515 has been marked as a duplicate of this bug. ***
Comment 7 Pedro Gimeno 2003-04-12 11:42:50 UTC
I think that this one was actually a duplicate of bug #17904 which can
in turn be closed. Is this correct?
Comment 8 Sven Neumann 2003-04-12 12:04:01 UTC
I think you are right, please close bug #17904.
Comment 9 Raphaël Quinet 2003-06-20 17:07:00 UTC
The fix is part of the stable release 1.2.4.  Closing this bug.