GNOME Bugzilla – Bug 105222
libgnome-desktop should not check mime type
Last modified: 2004-12-22 21:47:04 UTC
In function gnome_desktop_item_new_from_uri, it is checked that the URI is
of mime type application/x-gnome-app-info. This is bad because:
* It's a lousy way of checking a file's validity; it could still be
malformed. Basically it doesn't always work.
* It stops you from using the functions on custom file types, similar to
.desktop files but with a different mime type (this is my current problem).
There's no reason why the code shouldn't be shareable...
Please let me know what you think of the patch. An alternative way of doing
this is to have an alternative function that doesn't do the mime checking,
but that's pants.
Created attachment 14098 [details] [review]
Maintainers: I'd really appreciate it if you could review this for the
gnome-2-2 branch ASAP.
Looks fine to me. Please commit to HEAD. There is no gnome-2-2 branch yet.
2003-03-06 Andrew Sobala <firstname.lastname@example.org>
* gnome-desktop-item.c: (gnome_desktop_item_new_from_uri): remove mime
type checking. Fixes bug #105222.