GNOME Bugzilla – Bug 105047
[PATCH] Putting metathemes in .desktop files is silly
Last modified: 2004-12-22 21:47:04 UTC
At the moment, a desktop file looks like this: [Desktop Entry] Name=Blah Comment=Blah [X-GNOME-Metatheme] {theme info} These desktop entries do not launch a program, and a side effect of putting metathemes in .desktop files is that it has the mime type application/x-gnome-app-info. This means you can't thumbnail them or connect anything with their mime type. This patch allows the theme manager et al. to open a file with the following format, in addition to the existing one. [X-GNOME-Metatheme] Name=Blah Comment=Blah {theme info} I have added this to gnome-mime-data as the mime type application/x-gnome-theme, so it can be handled properly by other applications. Hopefully in the future this will become the de facto theme format, although it will also be backwards compatible. This patch ensures forward-compatibility to the GNOME 2.2 theme manager.
Created attachment 14038 [details] [review] Proposed patch
Damn, patch is broken. Removing patch keyword.
Created attachment 14873 [details] [review] Replacement patch
jrb: this patch allows themes to be written without the [Desktop Item] stuff to fix the mime types like we discussed. It also makes read_meta_theme public (themus needs this). OK to commit?
Fixed in CVS 2003-03-27 Andrew Sobala <aes@gnome.org> * gnome-theme-info.c: (gnome_theme_read_meta_theme), (update_common_theme_dir_index): s/read_meta_theme/gnome_theme_read_meta_theme/; enable the reading of themes that just use [X-GNOME-Metatheme] without pretending to be a .desktop file * gnome-theme-info.h: exposed gnome_theme_read_meta_theme