After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 105047 - [PATCH] Putting metathemes in .desktop files is silly
[PATCH] Putting metathemes in .desktop files is silly
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.2.x
Other other
: High normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 105222
Blocks: 105048 107934
 
 
Reported: 2003-02-02 14:48 UTC by Andrew Sobala
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (2.01 KB, patch)
2003-02-02 14:49 UTC, Andrew Sobala
none Details | Review
Replacement patch (3.44 KB, patch)
2003-03-09 19:48 UTC, Andrew Sobala
none Details | Review

Description Andrew Sobala 2003-02-02 14:48:49 UTC
At the moment, a desktop file looks like this:

[Desktop Entry]
Name=Blah
Comment=Blah

[X-GNOME-Metatheme]
{theme info}

These desktop entries do not launch a program, and a side effect of putting
metathemes in .desktop files is that it has the mime type
application/x-gnome-app-info. This means you can't thumbnail them or
connect anything with their mime type.

This patch allows the theme manager et al. to open a file with the
following format, in addition to the existing one.

[X-GNOME-Metatheme]
Name=Blah
Comment=Blah
{theme info}

I have added this to gnome-mime-data as the mime type
application/x-gnome-theme, so it can be handled properly by other
applications. Hopefully in the future this will become the de facto theme
format, although it will also be backwards compatible.

This patch ensures forward-compatibility to the GNOME 2.2 theme manager.
Comment 1 Andrew Sobala 2003-02-02 14:49:16 UTC
Created attachment 14038 [details] [review]
Proposed patch
Comment 2 Andrew Sobala 2003-02-04 18:16:54 UTC
Damn, patch is broken. Removing patch keyword.
Comment 3 Andrew Sobala 2003-03-09 19:48:10 UTC
Created attachment 14873 [details] [review]
Replacement patch
Comment 4 Andrew Sobala 2003-03-09 19:49:47 UTC
jrb: this patch allows themes to be written without the [Desktop Item]
stuff to fix the mime types like we discussed. It also makes
read_meta_theme public (themus needs this).

OK to commit?
Comment 5 Andrew Sobala 2003-03-27 20:53:38 UTC
Fixed in CVS

2003-03-27  Andrew Sobala  <aes@gnome.org>
                                                                     
          
        * gnome-theme-info.c: (gnome_theme_read_meta_theme),
        (update_common_theme_dir_index):
        s/read_meta_theme/gnome_theme_read_meta_theme/; enable the
reading of
        themes that just use [X-GNOME-Metatheme] without pretending to
be a
        .desktop file
        * gnome-theme-info.h: exposed gnome_theme_read_meta_theme