After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 92842 - Tasklist window menu should popup under mouse
Tasklist window menu should popup under mouse
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: tasklist
unspecified
Other All
: Normal minor
: GNOME2.x
Assigned To: libwnck maintainers
libwnck maintainers
: 97959 98925 (view as bug list)
Depends on:
Blocks: 155907
 
 
Reported: 2002-09-09 11:16 UTC by Fernando Herrera
Modified: 2005-01-28 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
teeny tiny patch to do that (962 bytes, patch)
2005-01-27 23:04 UTC, Vincent Noel 		accepted-commit_now Details | Review

Description Fernando Herrera 2002-09-09 11:16:09 UTC 
When you 2nd click over a window in the task list, you get the window menu 
(Minimize, Close...). This menu always popups at the begining of window 
tasklist button. If you have "big" button windows, and you click in the 
right side, the menu popups very far away in the left. I'll try to ascii-
draw it:


                       -----
                       |   | --> Menu here
_______________________|___|________________
|                    |                 X   |
|      Window1       |     Window 2        |
\------------------------------------------/

X --> Click here

In this case, the user needs to "nagivate" too much screen with the mouse.

The correct behaviour (from an usability a comodity point of view) should 
be to popup up the menu just where the user clicked (just like when you 
2nd click on the panel).
Comment 1 Havoc Pennington 2002-09-17 18:09:01 UTC 
agreed
Comment 2 Havoc Pennington 2002-09-21 15:58:53 UTC 
See also #87184 when refining popup algorithm
Comment 3 Gregory Merchan 2003-01-23 17:53:59 UTC 
*** Bug 98925 has been marked as a duplicate of this bug. ***
Comment 4 Gregory Merchan 2003-01-23 17:54:47 UTC 
*** Bug 97959 has been marked as a duplicate of this bug. ***
Comment 5 Vincent Noel 2005-01-27 23:04:51 UTC 
Created attachment 36625 [details] [review]
teeny tiny patch to do that

Here is a patch to show the right-click menu close to the mouse cursor. If the
cursor is close to an end of the clicked task button, the menu snaps to the
edge of the button.
The algorithm is totally stolen from Vincent's patch in bug 116028. It works
wonders.
Comment 6 Bryan W Clark 2005-01-27 23:25:05 UTC 
I haven't tried it out, but the idea sounds good.
Comment 7 Vincent Untz 2005-01-27 23:55:17 UTC 
I think the one who came with this idea is a wonderful guy ;-)
This sounds sane to me. But you'll probably want to ask Havoc or Mark before
committing.
Comment 8 Vincent Noel 2005-01-28 14:40:30 UTC 
Moving to the right component. Sorry for the spam.
Comment 9 Havoc Pennington 2005-01-28 16:44:10 UTC 
Comment on attachment 36625 [details] [review]
teeny tiny patch to do that

looks reasonable to me, thanks.
Comment 10 Vincent Noel 2005-01-28 16:46:30 UTC 
I won't be able to commit before next monday, so anyone (Vincent ?) please commit if you feel like it :-)
Comment 11 Elijah Newren 2005-01-28 16:54:22 UTC 
Committed.

2005-01-28  Elijah Newren  <newren@gmail.com>

	Patch from Vincent Noel to make the tasklist window menu popup
	near the mouse pointer.  Fixes #92842.

	* libwnck/tasklist.c: (wnck_task_position_menu): get the pointer
	location and adjust the menu location accordingly