GNOME Bugzilla – Bug 790033
Add support for third stylus button on Wacom's new Pro Pen 3D
Last modified: 2018-01-30 20:39:11 UTC
Wacom has introduced a new "Pro Pen 3D" which includes a third barrel button. GNOME does not have support for this third button: g-c-c does not provide a way to configure its operation (see bug 790028) and mutter/gtk does not allow the use of this button.
Created attachment 363169 [details] [review] clutter/evdev: Add support for BTN_STYLUS3 Note that BTN_STYLUS3 hasn't been formally accepted upstream quite yet...
Created attachment 363170 [details] [review] backends: Add support for Wacom stylus tertiary-button-action
Created attachment 363171 [details] [review] wayland: Add support for BTN_STYLUS3 GTK+ patch. Above note about BTN_STYLUS3 applies.
Note: BTN_STYLUS3 has been accepted for the 4.15 kernel https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/commit/?h=for-4.15/wacom&id=9e429d564926d3bca49907fa03031da705ad6f2c
Review of attachment 363169 [details] [review]: Makes sense.
Review of attachment 363170 [details] [review]: Looks good. ::: src/backends/native/meta-input-settings-native.c @@ +532,3 @@ GDesktopStylusButtonAction primary, + GDesktopStylusButtonAction secondary, + GDesktopStylusButtonAction tertiary) Starting to regret the explicit arguments instead of an array of those, but oh well :)
Review of attachment 363171 [details] [review]: LGTM
Comment on attachment 363169 [details] [review] clutter/evdev: Add support for BTN_STYLUS3 Attachment 363169 [details] pushed as 91df801 - clutter/evdev: Add support for BTN_STYLUS3
Comment on attachment 363170 [details] [review] backends: Add support for Wacom stylus tertiary-button-action Attachment 363170 [details] was committed too.
Comment on attachment 363171 [details] [review] wayland: Add support for BTN_STYLUS3 The GTK+ patch has been pushed to master and gtk-3-22. git bz is not friends with me today...