After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 77941 - Make up bogus icon for entire grouped application
Make up bogus icon for entire grouped application
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
0.x
Other Linux
: High trivial
: GNOME2.x
Assigned To: libwnck maintainers
libwnck maintainers
: 75942 80368 83065 87850 89740 96930 98223 98492 101905 112097 117763 130381 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-04-07 16:06 UTC by Dave Bordoley [Not Reading Bug Mail]
Modified: 2004-08-16 16:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a pretty messy patch - Havoc ? (6.45 KB, patch)
2002-08-06 05:36 UTC, Mark McLoughlin 		none Details | Review

Description Dave Bordoley [Not Reading Bug Mail] 2002-04-07 16:06:42 UTC 
Right now when grouping is used, the icon for the program in the WLA is the
no icon icon. Instead it should use the icon from the last focused window
of the program. In most cases, the icon will be the same for all windows
anyway.
Comment 1 Havoc Pennington 2002-05-13 21:36:42 UTC 
It should really use the application icon, as it does now (at the
moment grouping is based on application). Most applications don't set
an application icon though, which is the problem. When none is set it
should probably pick a random icon from the windows in the application.
Comment 2 Havoc Pennington 2002-05-13 21:49:00 UTC 
*** Bug 75942 has been marked as a duplicate of this bug. ***
Comment 3 Luis Villa 2002-05-20 16:27:45 UTC 
*** Bug 80368 has been marked as a duplicate of this bug. ***
Comment 4 Luis Villa 2002-05-20 16:28:15 UTC 
Adding the 1.x-parity keyword since the old tasklist did this correctly.
Comment 5 Havoc Pennington 2002-05-20 20:46:40 UTC 
Just to be pedantic, it didn't do it "correctly" since heuristics are
the only available mechanism for now. ;-)
Comment 6 Luis Villa 2002-05-20 20:52:52 UTC 
'Never did it in a way in which I, the casual user, noticed it to be
incorrect' :)
Comment 7 Luis Villa 2002-06-05 02:49:00 UTC 
*** Bug 83065 has been marked as a duplicate of this bug. ***
Comment 8 Carsten Menke 2002-06-23 01:22:30 UTC 
Still seeing this Gnome2 built with tarballs from June 19th.
Comment 9 Heath Harrelson 2002-07-10 16:24:52 UTC 
*** Bug 87850 has been marked as a duplicate of this bug. ***
Comment 10 Mark McLoughlin 2002-08-06 05:27:20 UTC 
*** Bug 89740 has been marked as a duplicate of this bug. ***
Comment 11 Mark McLoughlin 2002-08-06 05:36:30 UTC 
Created attachment 10286 [details] [review]
a pretty messy patch - Havoc ?
Comment 12 Havoc Pennington 2002-08-06 06:37:38 UTC 
Looks generally right. With that set_want_fallback(), I know I'm a
loser but you had better be sure there isn't code such as the window.c
code that expects to get a fallback always and calls set_want_fallback
(FALSE). ;-)

I didn't look at the patch in too much detail, too tired. Go ahead and
commit if you tested it.
Comment 13 Mark McLoughlin 2002-08-14 00:00:35 UTC 
Hmm, I really need to rememeber to cc myself on bugs where I've
submitted a patch.

Anyway, the patch is bogus. Soon after I submitted it, things started
crashing when windows were opened and closed and stuff. So, I reverted
and carried on. Sorry I haven't had a chance to go back and figure out
what's wrong with it :/
Comment 14 Dave Bordoley [Not Reading Bug Mail] 2002-10-29 19:34:52 UTC 
*** Bug 96930 has been marked as a duplicate of this bug. ***
Comment 15 Luis Villa 2002-11-05 04:52:05 UTC 
I'm going to take the liberty of marking this 'high' because of the
large number of duplicates. It looks fairly bad and unpolished.
Comment 16 Heath Harrelson 2002-11-14 21:05:57 UTC 
*** Bug 98492 has been marked as a duplicate of this bug. ***
Comment 17 Dan Winship 2002-11-26 22:02:51 UTC 
If this is annoying to fix, fixing bug 68557 would at least make
people stop caring about this bug.
Comment 18 Mark McLoughlin 2003-01-01 21:15:46 UTC 
*** Bug 101905 has been marked as a duplicate of this bug. ***
Comment 19 Dave Bordoley [Not Reading Bug Mail] 2003-01-25 21:51:53 UTC 
*** Bug 98223 has been marked as a duplicate of this bug. ***
Comment 20 Dan Winship 2003-04-23 19:14:21 UTC 
in some cases this could also be "fixed" by a heuristic that
said "if all of the windows have the same icon, use that icon
for the group too". (That would fix my Galeon and Terminal groups,
but not Evolution.) That's probably what gnome 1.4 did that
makes Luis think this is a regression?
Comment 21 Havoc Pennington 2003-04-24 01:52:23 UTC 
1.4 could have done that, though you'd have to md5 hash each icon or 
something to compare them. I bet it did something simpler.
A simple fix here is IMO fine.
Comment 22 Havoc Pennington 2003-05-03 03:59:20 UTC 
*** Bug 112097 has been marked as a duplicate of this bug. ***
Comment 23 Havoc Pennington 2003-05-03 17:15:21 UTC 
Lame fix added to CVS
Comment 24 Luis Villa 2003-07-18 12:17:07 UTC 
*** Bug 117763 has been marked as a duplicate of this bug. ***
Comment 25 Heath Harrelson 2004-01-02 21:53:53 UTC 
*** Bug 130381 has been marked as a duplicate of this bug. ***