After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777250 - Make use of the WebKit UndoManager when available
Make use of the WebKit UndoManager when available
Status: RESOLVED OBSOLETE
Product: geary
Classification: Other
Component: composer
master
Other Linux
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: geary-wk2
Blocks: 712934
 
 
Reported: 2017-01-14 12:40 UTC by Michael Gratton
Modified: 2021-07-05 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Gratton 2017-01-14 12:40:10 UTC 
Geary is no longer using the WebKit undo stack to determine if a message body has been modified by the user in the composer (Bug 712926), since WebKit.WebView no longer has can_undo()/can_redo() methods. Instead it just assumes the body has been modified if any mutation event has occurred. This isn't great, but is perhaps better for the moment since custom DOM operations break the stack (e.g. Bug 712934).

Getting access to the WebKit UndoManager may allow us to insert undo/redo transactions, hence not break the stack when manipulating the DOM, and might also then let us start using the stack to determine if the message body has actually been modified or not.

The is already a WK bug open for this, so we should look into fixing that so we can fix this: https://bugs.webkit.org/show_bug.cgi?id=88595
Comment 1 GNOME Infrastructure Team 2021-07-05 13:26:00 UTC 
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/geary/-/issues/

Thank you for your understanding and your help.