---- Reported by geary-maint@gnome.bugs 2012-06-11 12:38:00 -0700 ----

Original Redmine bug id: 5388
Original URL: http://redmine.yorba.org/issues/5388
Searchable id: yorba-bug-5388
Original author: Matthew Pirocchi
Original description:

We do some DOM manipulation to split up blockquotes when a newline is inserted
in the middle. Doing any DOM manipulation means we lose free undo-redo
support. Normally this is fixed by adding your own undo/redo steps to the undo
manager. But WebKitGtk+ does not yet expose this functionality.

Some relevant links:

[88595: WebKitGtk+'s WebView should allow arbitrary actions to be added to
the UndoStack.](https://bugs.webkit.org/show_bug.cgi?id=88595)

[WebKit Objective-C Programming Guide: Using Undo When Editing](https://develo
per.apple.com/library/mac/#documentation/Cocoa/Conceptual/DisplayWebContent/Ta
sks/UsingUndo.html#//apple_ref/doc/uid/TP40001473-CJBEHAAG)

[UndoManager and DOM Transaction](http://dvcs.w3.org/hg/undomanager/raw-
file/tip/undomanager.html)

Related issues:
related to geary - 5404: Geary relies on undo to decide whether to warn
the user a... (Open)
related to geary - 5132: must press Ctrl+Z several times to undo after
pressing En... (Invalid)



---- Additional Comments From geary-maint@gnome.bugs 2013-04-03 18:08:00 -0700 ----

### History

####

#1

Updated by Adam Dingle over 1 year ago

  * **Priority** changed from _Normal_ to _High_

####

#2

Updated by Matthew Pirocchi over 1 year ago

This is related to [WebKit 87189](https://bugs.webkit.org/show_bug.cgi?id=87189).

####

#3

Updated by Matthew Pirocchi over 1 year ago

  * **Assignee** deleted (<strike>_Matthew Pirocchi_</strike>)

It doesn't look like WebKit http://redmine.yorba.org/show_bug.cgi?id=87189/89722 will be fixed before I leave.
I've subscribed Jim and Adam so they can visit this bug when it is.

####

#4

Updated by Adam Dingle about 1 year ago

  * **Target version** deleted (<strike>_0.2_</strike>)

####

#5

Updated by Jim Nelson about 1 year ago

  * **Target version** set to _0.3.0_

UndoManager was ripped out in a [recent
commit](https://bugs.webkit.org/show_bug.cgi?id=100711). The ticket is marked
for re-implementation when someone takes ownership of undo/redo.

I think this means this ticket will be invalid against the next release of
WebKit. We should test when it becomes available.

####

#6

Updated by Jim Nelson 9 months ago

  * **Target version** changed from _0.3.0_ to _0.4.0_

####

#7

Updated by Jim Nelson 8 months ago

  * **Target version** changed from _0.4.0_ to _0.5.0_



--- Bug imported by chaz@yorba.org 2013-11-21 20:18 UTC  ---

This bug was previously known as _bug_ 5388 at http://redmine.yorba.org/show_bug.cgi?id=5388

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution