After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767146 - Improve how the escape key is used in the search bar
Improve how the escape key is used in the search bar
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-02 09:29 UTC by Joaquim Rocha
Modified: 2016-06-02 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improve how the escape key is used in the search bar (1.76 KB, patch)
2016-06-02 09:30 UTC, Joaquim Rocha 		none Details | Review

Description Joaquim Rocha 2016-06-02 09:29:59 UTC 
The search key currently only clears the text in the search bar. These changes do that when there is text but when the search bar is empty, pressing the Escape key will hide it.
This is a common pattern and improves the UX IMO.
Comment 1 Joaquim Rocha 2016-06-02 09:30:03 UTC 
Created attachment 328932 [details] [review]
Improve how the escape key is used in the search bar

The escape key was simply clearing the search bar's text. With these
changes, it does that when there is text, otherwise it hides the search
bar. This provides a counter action to showing the search bar by typing
which improves the UX.
Comment 2 Richard Hughes 2016-06-02 12:06:26 UTC 
commit d479fe2e9e2bcd2e13813642f4d39010b9722b81
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Jun 2 13:01:00 2016 +0100

    Switch to using GtkSearchBar
    
    Fixes:
    https://bugzilla.gnome.org/show_bug.cgi?id=767143
    https://bugzilla.gnome.org/show_bug.cgi?id=767144
    https://bugzilla.gnome.org/show_bug.cgi?id=767146
    https://bugzilla.gnome.org/show_bug.cgi?id=767148