After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761869 - [PATCH][tracker] return album disc property
[PATCH][tracker] return album disc property
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on: 761868
Blocks:
 
 
Reported: 2016-02-11 16:24 UTC by Marinus Schraal
Modified: 2016-05-14 00:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
handle GRL_METADATA_KEY_ALBUM_DISC (663 bytes, patch)
2016-02-11 16:24 UTC, Marinus Schraal 		reviewed Details | Review
tracker: Add album disc number mapping (1.06 KB, patch)
2016-05-13 16:38 UTC, Marinus Schraal 		none Details | Review
tracker: Add album disc number mapping (1.57 KB, patch)
2016-05-13 18:25 UTC, Marinus Schraal 		committed Details | Review

Description Marinus Schraal 2016-02-11 16:24:26 UTC 
Created attachment 320892 [details] [review]
handle GRL_METADATA_KEY_ALBUM_DISC

Handles the GRL_METADATA_KEY_ALBUM_DISC key in the tracker plugin, also needs the patch in bug #761168 to work properly.
Comment 1 Bastien Nocera 2016-03-02 10:52:37 UTC 
Review of attachment 320892 [details] [review]:

If it's been tested, looks fine to me.
Comment 2 Marinus Schraal 2016-03-02 13:23:42 UTC 
this has been tested and works https://bugzilla.gnome.org/show_bug.cgi?id=750827
Comment 3 Marinus Schraal 2016-05-13 16:38:41 UTC 
Created attachment 327807 [details] [review]
tracker: Add album disc number mapping

Map nmm:musicAlbumDisc to GRL_METADATA_KEY_ALBUM_DISC_NUMBER.
Comment 4 Marinus Schraal 2016-05-13 18:25:46 UTC 
Created attachment 327814 [details] [review]
tracker: Add album disc number mapping

Map nmm:musicAlbumDisc to GRL_METADATA_KEY_ALBUM_DISC_NUMBER. Update
configure.ac to depend on grilo core 0.3.1 for this as well.
Comment 5 Bastien Nocera 2016-05-14 00:43:43 UTC 
Attachment 327814 [details] pushed as 0b7fece - tracker: Add album disc number mapping