After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750827 - Album views - if an album has multiple disks, group tracks by disk
Album views - if an album has multiple disks, group tracks by disk
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-music-maint
gnome-music-maint
: 709288 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-06-12 05:57 UTC by Adrien Plazas
Modified: 2016-10-25 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A comparison of the expected and the actual track orders in a 3 disks real life example (407.11 KB, image/png)
2015-06-12 05:57 UTC, Adrien Plazas
  Details
simple mockup (11.12 KB, image/png)
2016-01-05 15:10 UTC, Allan Day
  Details
AlbumWidget per disc separation if available (11.11 KB, patch)
2016-02-11 16:27 UTC, Marinus Schraal
none Details | Review
AlbumWidget per disc separation if available (11.12 KB, patch)
2016-02-11 16:36 UTC, Marinus Schraal
none Details | Review
per disc view looks (181.23 KB, image/png)
2016-02-11 16:41 UTC, Marinus Schraal
  Details
AlbumWidget per disc separation if available (11.69 KB, patch)
2016-02-12 17:33 UTC, Marinus Schraal
none Details | Review

Description Adrien Plazas 2015-06-12 05:57:10 UTC
Created attachment 305116 [details]
A comparison of the expected and the actual track orders in a 3 disks real life example

Tracks from several disks of the same album are mixed together (the firsts ones first, then the second ones, etc.).
It even seems that the disks are in reverse order.

So if a have an album of 3 disks with 2 tracks each, GNOME Music would currently order it:
- disk 3, track 1
- disk 2, track 1
- disk 1, track 1
- disk 3, track 2
- disk 2, track 2
- disk 1, track 2

The expected order would be:
- disk 1, track 1
- disk 1, track 2
- disk 2, track 1
- disk 2, track 2
- disk 3, track 1
- disk 3, track 2

Having  way to tell a disk from the other would also be nice (with some spacing maybe), but that's another bug.
Comment 1 Allan Day 2016-01-05 15:10:01 UTC
Created attachment 318258 [details]
simple mockup

Grouping the tracks by disk would be a good start. It would also be great if disk headings could be added at the same time (a bit like in the attached image).
Comment 2 Marinus Schraal 2016-02-11 16:27:45 UTC
Created attachment 320894 [details] [review]
AlbumWidget per disc separation if available

Initial go at this. Needs patches in grilo and grilo plugins to work properly: #761868 , #761869 & #761168 .

This is just for the AlbumWidget view.
Comment 3 Marinus Schraal 2016-02-11 16:36:20 UTC
Created attachment 320895 [details] [review]
AlbumWidget per disc separation if available

Noticed I made an indent mistake while cleaning up the first patch.
Comment 4 Marinus Schraal 2016-02-11 16:41:48 UTC
Created attachment 320896 [details]
per disc view looks

how it looks at the moment
Comment 5 Allan Day 2016-02-11 17:31:09 UTC
(In reply to Marinus Schraal from comment #4)
> Created attachment 320896 [details]
> per disc view looks
> 
> how it looks at the moment

Looks good, although it could do with some more space between discs (above "disc 2" in your screenshot). Thanks for the patch and screenshot!
Comment 6 Marinus Schraal 2016-02-12 17:33:38 UTC
Created attachment 321010 [details] [review]
AlbumWidget per disc separation if available

Cleanup the patch some more, remove some (old?) unused stuff in the class as well.

In reply to comment #5 : I can adapt the height some more, but I don't see a way to just add padding on top.
Comment 7 Alexandre Franke 2016-09-25 12:29:13 UTC
(In reply to Adrien Plazas from comment #0)
> Having  way to tell a disk from the other would also be nice (with some
> spacing maybe), but that's another bug.

The sorting seems correct here with 3.18, so I think the separation in presentation is the only remaining issue.
Comment 8 Marinus Schraal 2016-09-25 14:18:08 UTC
I think this needs to be reimplemented on top of a redesigned album widget, not using gtktreeview. The current one is too cumbersome.

Probably together with a replacement for the artist album widget.
Comment 9 Marinus Schraal 2016-10-25 13:54:30 UTC
*** Bug 709288 has been marked as a duplicate of this bug. ***
Comment 10 Marinus Schraal 2016-10-25 14:17:17 UTC
This should be fixed in git head, please test and report issues.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.