Created attachment 317675 [details]
missing symbolic/16/gimp-prefs-icon-theme.png

Don't know why that is missing because i'd made one originally for the icon themes patch. At any rate here it is now :)

Created attachment 317676 [details]
symbolic gimp-prefs-folders-icon-themes

Ben > You actually provided us with 22x22 and 48x48 icons previously (or I missed the 16x16). Also you made a different one for 22x22, which featured only the stars. I guess the 16x16 should also be the stars only. Here you uploaded another version.

Oh and also I just realize there is a gimp-prefs-icon-theme and gimp-prefs-folders-icon-themes. This may be cause to my confusion. So they were separate icons, I guess I didn't realize. I will add these icons.

No, i had the icon, i probably forgot to add it to the zip file. yeah the the icon-themes one should be stars for 16x16 and 22x22, with the 48x48 being a folder one since its only used in the notebook, though if you prefer having them all be the same i can make a new 48x48. I was following the same thing being done for the original themes icon.

For the folders one they should all be folders with the star pattern in it.

(In reply to Jehan from comment #4)
> Oh and also I just realize there is a gimp-prefs-icon-theme and
> gimp-prefs-folders-icon-themes. This may be cause to my confusion. So they
> were separate icons, I guess I didn't realize. I will add these icons.

yeah :)

Not sure who added the folders version, because the original code i had taken that out. Must be Mitch :) anywho all good, let me know if you need another version.

Created attachment 317823 [details]
gimp-tool-seamless-clone.png

icons are for 16x16 and 22x22 and themes: standard, symbolic, symbolic-invertet

Thanks for this. Did you do the icons from a vectorial format? We are thinking of going to possibly full vectorial icons, and so we will need the SVG for your icon if we want to keep your icon when we do so.

Also the color icon seems to be the same as the current one, no?

The color one is the same as the current (as I did this before), but smaller (no exif and so on ...) in size.

Actually no svg. Sorry tried this, but without an template ... and current inkscape (0.91) seems to behave different than before.

IMHO having gimp...svg templates would be of great help. 

Tried to play with gimp-tool-warp.svg (a rather simple one) but it was of no help. E.g painting an arrow every time a-new makes it every time different. Simplier would be copying and if necessary adjusting so the icon theme would look more uniform.

Created attachment 317830 [details]
gimp-tool-unified-transform.png added

another missing icon (gimp-tool-unified-transform.png) added to symbolic in 16x16 and 22x22
and sorry again no svg for the same reasons as  before

Okay, found now the template ... :-)

https://raw.github.com/gnome-design-team/gnome-icons/master/art-libre-symbolic/src/art-libre.svg

expect some svg's after the holidays


Regards

Awesome, thanks. I will also wait for SVG of the 2 other icons you propose and commit in the same time. Thanks.

Created attachment 317883 [details]
7 svg gimp icons

With the template it was a lot easier
In the package are the following icons:

Symbolic:
gimp-hfill.svg (+ 24x24 *.png)
gimp-vfill.svg (+24x24 *.png)
gimp-prefs-playground.svg (+22x22 & 48x48 *.png)
gimp-tool-handle-transform.svg (+22x22 & 16x16 *.png)
gimp-tool-n-point-deformation.svg (+22x22 & 16x16 *.png)
gimp-tool-seamless-clone.svg (+22x22 & 16x16 *.png)
gimp-tool-unfied-transform.svg (+22x22 & 16x16 *.png)

Default:
gimp-tool-seamless-clone (+22x22 & 16x16 *.png) smaller size (no useless exif and so on as in my original png's)

Happy X-Mas

Thanks. Committed.
I have also added you in the authors list with role "artist".

commit 9618cdde32f09dbef0e768cfad2f8486e4735b5e
Author: Klaus Staedtler <staedtler-przyborski@web.de>
Date:   Sat Dec 26 17:17:23 2015 +0100

    icons: new Symbolic icons.
    
    Partly based off the art-libre source template:
    https://github.com/gnome-design-team/gnome-icons/blob/master/art-libre-symbolic/src/art-libre.svg
    Committed and verified by Jehan.

----------------

Still 31 images to go. The updated list of icons:

symbolic/128/gimp-wilber-outline.png
symbolic/128/gimp-wilber.png
symbolic/16/gimp-prefs-folders-brushes.png
symbolic/16/gimp-prefs-folders-dynamics.png
symbolic/16/gimp-prefs-folders-environ.png
symbolic/16/gimp-prefs-folders-fonts.png
symbolic/16/gimp-prefs-folders-gradients.png
symbolic/16/gimp-prefs-folders-interp.png
symbolic/16/gimp-prefs-folders-modules.png
symbolic/16/gimp-prefs-folders-palettes.png
symbolic/16/gimp-prefs-folders-patterns.png
symbolic/16/gimp-prefs-folders-plug-ins.png
symbolic/16/gimp-prefs-folders-scripts.png
symbolic/16/gimp-prefs-folders-themes.png
symbolic/16/gimp-prefs-folders-tool-plug-ins.png
symbolic/16/gimp-prefs-folders-tool-presets.png
symbolic/16/gimp-prefs-folders-tools.png
symbolic/16/gimp-prefs-image-windows.png
symbolic/16/gimp-prefs-interface.png
symbolic/16/gimp-prefs-theme.png
symbolic/16/gimp-prefs-toolbox.png
symbolic/16/gimp-prefs-window-management.png
symbolic/192/gimp-wilber-outline.png
symbolic/192/gimp-wilber.png
symbolic/256/gimp-wilber-outline.png
symbolic/256/gimp-wilber.png
symbolic/32/gimp-wilber.png
symbolic/48/gimp-wilber.png
symbolic/64/gimp-wilber-outline.png
symbolic/96/gimp-wilber-outline.png
symbolic/96/gimp-wilber.png

Created attachment 317899 [details]
missing wilber icons

Another package.

includes

gimp-wilber-outline.svg
gimp-wilber.svg

symbolic/128/gimp-wilber-outline.png
symbolic/128/gimp-wilber.png
symbolic/192/gimp-wilber-outline.png
symbolic/192/gimp-wilber.png
symbolic/256/gimp-wilber-outline.png
symbolic/256/gimp-wilber.png
symbolic/32/gimp-wilber.png
symbolic/48/gimp-wilber.png
symbolic/64/gimp-wilber-outline.png
symbolic/96/gimp-wilber-outline.png
symbolic/96/gimp-wilber.png

so only 20 icons left

Created attachment 317907 [details]
Yet another icon package

Contains


gimp-prefs-folders-brushes.svg
gimp-prefs-folders-dynamics.svg
gimp-prefs-folders-environ.svg
gimp-prefs-folders-fonts.svg
gimp-prefs-folders-gradients.svg
gimp-prefs-folders-interp.svg
gimp-prefs-folders-modules.svg
gimp-prefs-folders-palettes.svg
gimp-prefs-folders-patterns.svg
gimp-prefs-folders-plug-ins.svg
gimp-prefs-folders-scripts.svg
gimp-prefs-folders-tools.svg

symbolic/16/gimp-prefs-folders-brushes.png
symbolic/16/gimp-prefs-folders-dynamics.png
symbolic/16/gimp-prefs-folders-environ.png
symbolic/16/gimp-prefs-folders-fonts.png
symbolic/16/gimp-prefs-folders-gradients.png
symbolic/16/gimp-prefs-folders-interp.png
symbolic/16/gimp-prefs-folders-modules.png
symbolic/16/gimp-prefs-folders-palettes.png
symbolic/16/gimp-prefs-folders-patterns.png
symbolic/16/gimp-prefs-folders-plug-ins.png
symbolic/16/gimp-prefs-folders-scripts.png
symbolic/16/gimp-prefs-folders-tools.png


no credits at all cause simply copied from the template and color/size adjusted

now only 8 icons to go

Created attachment 317923 [details]
symbolic/16/gimp-prefs-folders now complete

Now all missing gimp-prefs-folders in svg and png

additionally an empty gimp-prefs-folders.svg as template for future addons

symbolic/16/gimp-prefs-folders-brushes.png
symbolic/16/gimp-prefs-folders-dynamics.png
symbolic/16/gimp-prefs-folders-environ.png
symbolic/16/gimp-prefs-folders-fonts.png
symbolic/16/gimp-prefs-folders-gradients.png
symbolic/16/gimp-prefs-folders-interp.png
symbolic/16/gimp-prefs-folders-modules.png
symbolic/16/gimp-prefs-folders-palettes.png
symbolic/16/gimp-prefs-folders-patterns.png
symbolic/16/gimp-prefs-folders-plug-ins.png
symbolic/16/gimp-prefs-folders-scripts.png
symbolic/16/gimp-prefs-folders-themes.png
symbolic/16/gimp-prefs-folders-tool-plug-ins.png
symbolic/16/gimp-prefs-folders-tool-presets.png
symbolic/16/gimp-prefs-folders-tools.png

only 5 images left for completeness

Created attachment 317926 [details]
missing prefs-icons

The 5 last missing icons

in svg and png


symbolic/16/gimp-prefs-image-windows.png
symbolic/16/gimp-prefs-interface.png
symbolic/16/gimp-prefs-theme.png
symbolic/16/gimp-prefs-toolbox.png
symbolic/16/gimp-prefs-window-management.png

The icon theme is now complete ...

But wait there are several inconsistencies.

My five cents:

Some icons are used twice (e.g. prefs-folder-icon-theme) for different purpose, some icons differ when size changes (e.g. prefs-icon-theme) and some use the wrong metaphor (e.g. channels). Okay TV have channels, as Mars has, as Venice has ... but none of them has to do with color channels as used in gimp.

I would like to try to iron out these inconsistencies and maybe beautify ;-) some of the icons in minor aspects (only when necessary, e.g. wilber from symbolic looks rather ugly, not quite a recommodation for an image manipulation program) before the icon theme could be called final. I would also like to take a look on the other side (the sifr-icon-theme in libre-office) and harmonize Symbolic and sifr when they visualize the identical function.

Hello,

Thanks for all these. I don't commit these just now, because I'm looking for a better alternative for maintaining the source SVG, similar that what the origin art-libre project was doing (single SVG source file and a script to crop files automatically). I will commit later.

For proposing better alternatives, do not hesitate. Indeed apart from being an homonym, TV channels and color channels are not the same thing. And this homonym may also work only in English and some other close languages (for instance in French, a color channel is "canal", whereas a TV channel is "chaîne", so the substitution does not work anymore).

As for harmonizing the whole set, you are welcome to propose as well. :-)

Klaus: after harmonizing and proposing alternatives, if ever you feel bored, do not hesitate to have a look at bug 759904 and go chasing for missing icons.

We'll probably have to update the code also first, but then we would want to have new icons ready to add (both for the color and the symbolic icon sets).

Well… if you get bored… ;-)

Created attachment 317974 [details]
beautified symbolic wilber icons all res.

In the package are symbolic wilber & wilber-outline & wilber-eek in svg and all found resolutions as png.

Hope wilber is now in a better shape than the one from the art-libre template.

2.Next step from me will be to replace all icons where the metaphor is wrong (channel-icons and icon-icons)

3.Step will be to generate icons for all where icons are used twice for different purpose (this needs to be done for default too). For usage gimp-code must be changed.

4.Final step will be to nostrificate alien icons so bug 759904 can be closed. Therefore gimp also needs some code change.

Luckily gimp 2.10 will not be ready that fast, so I have enough time to be bored (and paint icons) ;-)

Step 2 is almost done. I only have some headache about the automatic generation of inverted-symbolic. I intend (like libreoffice sifr-theme does too !) to use a real-minor portion of color (for the r,g,b-channel icons). Unfortunately the red, green and blue stripe in the icon would be inverted too. Any ideas ?

Created attachment 318002 [details]
methapor corrected symbolic icons all res

Contains corrected methaphor for a) icon-themes and b) channels.

a) current icon uses stars for symbolizing an icon. Stars are used normally for rating. 
My suggestion uses yin/yang, why ? 
It's difficult to make an icon which symbolizes an icon. So I decided to use the world-wide most used symbol (non-religious, non-political, non ...) as a symbol for all symbols (this is quite similar to e.g. the usage of mona-lisa as a symbol for all images).

b) Current icon uses a TV for channels. This has nothing to do with color channels.

Current channel window is somehow overpopulated. 
It show's
1. a visible icon, 
2. a small image 
3. translated-text for all existing channels in the image (due to the fact that the channel icons are insufficient to explain anything and they are not visible yet)

When you deselect a channel 
1. disappears 
2. gets toggled to a corresponding channel icon 
3. stays as it is

As the channel icons don't explain anything they are useless

My solution (as drop in replacement) changes 
2. it shows now a non-visible icon (similar icon for all channels, it's a simple crossed visible)

Better solution (but this would require some code change) 
1. toogles between visible/non-visible icon. 
2. when de-selected image disappears. 
3. ideally the text would be colored (for red green and blue channels).

I already added gimp-nonvisible.svg (and the needed png's) if someone say's: Yes we change the code, I can deliver a gimp-nonvisible for default icon theme very fast too.

For the icon-theme icon, I asked the contributor who recently contributed the star icons if he has any input and comment here. I agree that stars are not the most symbolic representation of "icons", though I'm not sure of "Yin-Yang" being perfect either for the role. Still maybe it's better though, indeed.

For channel icons, I'm really not sure of using the same for all channels. I agree that adding color would be ideal though I am not sure how this will be handled with color inversion (both now in the script way, and later with GTK+3 which does the inversion automatically if I understands correctly).

Oh by the way, I have not answered about the new Wilber icon. I will hold on these too, and ask around. Wilber is our symbol, so I guess that's an important decision.
The current symbolic icons were already used in various places (if not in GIMP itself until now) and done by a long-time GNOME contributor, I believe. We'll see.

So in the end, I committed your finished set (up to comment 18):

commit a750a2a775cf6d3d1a8e5e7e57b5211f2d2fe891
Author: Jehan <jehan@girinstud.io>
Date:   Tue Dec 29 20:59:06 2015 +0100

    icons: install the complete Symbolic icon sets.

commit 3d1b9d27778e7e99486c0cec0f0fbbba2b6a5fd5
Author: Klaus Staedtler <staedtler-przyborski@web.de>
Date:   Tue Dec 29 20:27:33 2015 +0100

    icons: complete Symbolic icon set.
----------------------

I still want to change the way we maintain these icons, probably going full vectorial, but I need to finish a script first, and also test vectorial icons under Windows (cf. bug 742300). So I just pushed and will finish this later.

For the "icon" icons, the contributor of the star icons (draekko) says that was anyway just placeholders for when he fixed the icon theme code. I'm not so sure about Yin-Yang as a good symbol either (if I see a Yin-Yang symbol, I'm not thinking about icons), but still it may be better than the stars. So for the sake of it, I committed it. That's a difficult one anyway.

----------------------
commit 836cce83896cb47ef00458b5190d5f0a5e1acd5d
Author: Klaus Staedtler <staedtler-przyborski@web.de>
Date:   Tue Dec 29 21:27:45 2015 +0100

    icons: updated icon-theme icons.
    
    Current icon uses stars for symbolizing an icon. Stars are used normally
    for rating.
    My suggestion uses yin/yang, why ?
    It's difficult to make an icon which symbolizes an icon. So I decided to
    use the world-wide most used symbol (non-religious, non-political...) as
    a symbol for all symbols (this is quite similar to e.g. the usage of
    mona-lisa as a symbol for all images).
----------------------

For the channel icons, I'm really not sure about the solution of using the same icon everywhere. I guess this needs thinking and discussion.

For the Wilber icons, we still have to discuss. This is an important decision. Do not hesitate to join us on the IRC channel or discuss this on the gimp-gui mailing list.

First of all: I've no problem if others decide different than me.

The wilber icons are derived from original wilber.svg only color was ironed out.

If anybody has a better idea to symbolize an icon theme: great, wonderful, marvellous. 
Normally icons should be self-explaining and a substitution for text. Whenever a icon needs to be explained by words it's worth to consider if it's really necessary and useful to use this icon.

About the channels: as written it's only a intermediate 'drop-in' solution, better would be some code change.

In then meanwhile I've took a look on ... guess what? photoshop (really hadn't it in mind when i made and wrote my suggestion. But I understood then what gimp is modeled after).

There channels are displayed as followed

1. a visible icon, which disappears when you deselect the channel.

2. a tinted thumbnail of the channel of the image, tintage corresponds to selected color channel. Thumbnail stays when channel is disabled, no channel icon appears here (or anywhere else).

3. Text, which names the channel (eg. red, alpha, lab, cmyk ...)

But I'm afraid this solution would require even more code change (and behinder gimp 2.10 even longer).

Created attachment 318065 [details]
New pref icons, no longer double usage needed

I've added 4 svg's two for symbolic, two for default

they can be used in settings where 2 icons (gimp-prefs-image-windows & gimp-prefs-tool-options) are in double-usage.

gimp-prefs-window-snapping is intended for window-snapping instead of tool-options and gimp-prefs-window-presentation is intended instead of image-windows.

Currently they can't be used. First code must be changed (by someone else), therefore only as svg (no png's, but they can be easily generated).

Happy new year

Created attachment 318067 [details]
oops, wrong icon in last package

Falsly put a wrong icon from experimental. Corrected

Created attachment 318115 [details]
complete icon set fopr texttool, default & symbolic

I've completed the text-tool icon set, both for symbolic and default in svg and png

two of the icons can be used directly (gimp-letter-spacing and gimp-line-spacing) the other one's (gimp-align-left, -right, -center, -block and gimp-increment-intend) require some code change, because they are hardwired to use the system theme (so they won't even change when changing the gimp-icon theme).

Symbolic icons are directly derived from libre-office sifr-theme (so libre-office users will feel familiar and won't get eye-cancer ;-), for what reason ever gimp-symblic and libre-office-sifr use slightly different grey) the colored one's are derived from the symbolic ones.

Created attachment 318119 [details]
gimp-toolbox-icons default & symbolic

Yet another icon-set. It is intended to replace the external wired icons for the toolbox. Both svg and png and default and symbolic.

Usage requires gimp code change

The icons are derived from gimp own icons.

Seems I have to be bored really long to get all the gazillion external icons into gimp ;-). But either, my inkscape experiences and capabilities increase this way.

Just discovered that device-status points for handle-transform-tool and n-point-deformation-tool hardcoded to default icons instead to those in symbolic, so standard (colored icons) appear here for the selected tools.

BTW. for me the name device-status is misleading. As the status is assigned to all tools, tool-status as title seems more correct. Also the usage of pen-icon and an information sign as icon is misleading cause it doens't affect only the pen tool. The usage of pref-tool-options together with an information sign seems more logical.

> Usage requires gimp code change

For all the new icons which have no icons currently and require a code change, please upload them in bug 759904, which I created specifically for such a purpose.

> Just discovered that device-status points for handle-transform-tool and n-point-deformation-tool hardcoded to default icons instead to those in symbolic, so standard (colored icons) appear here for the selected tools.

I don't understand what you mean. No tool icon are hardcoded to a specific theme. I just checked again my dev version, I have proper symbolic icons for both handle-transform-tool and n-point-deformation-tool. Are you sure you haven't installed them in the wrong place?

> BTW. for me the name device-status is misleading. As the status is assigned to all tools, tool-status as title seems more correct.

For this kind of issues, could you open a new bug report and propose the name change there?

> Also the usage of pen-icon and an information sign as icon is misleading cause it doens't affect only the pen tool.

What pen-icon are you referring to? Do you mean the pencil (gimp-tool-pencil)? If not, which? And where else is this icon used?
Also, same thing, please open a separate bug report.

Sorry about the organisational messages, but there are already too many unrelated messages here and I fear I will later miss some of your messages when I will take time to review your propositions. This is only so that your work does not get lost.

(In reply to Jehan from comment #32)
> > Usage requires gimp code change
> 
> For all the new icons which have no icons currently and require a code
> change, please upload them in bug 759904, which I created specifically for
> such a purpose.
> 

Okay

> > Just discovered that device-status points for handle-transform-tool and n-point-deformation-tool hardcoded to default icons instead to those in symbolic, so standard (colored icons) appear here for the selected tools.
> 
> I don't understand what you mean. No tool icon are hardcoded to a specific
> theme. I just checked again my dev version, I have proper symbolic icons for
> both handle-transform-tool and n-point-deformation-tool. Are you sure you
> haven't installed them in the wrong place?
> 

The wrong icons will show with symbolic icon theme, then select a tool (these icons itself are correct) and then in the tool-box the tab device-status. There you see a small icon of the selected tool in front of a foreground, background, and so on symbol. These minor icons are all correct symbolic, except handle-transform-tool & n-point-deformation-tool. Browsed whole symbolic icon directory, because - naturally - I first thought it was a failure of mine, but didn't find any 


> > BTW. for me the name device-status is misleading. As the status is assigned to all tools, tool-status as title seems more correct.
> 
> For this kind of issues, could you open a new bug report and propose the
> name change there?

Ok

> 
> > Also the usage of pen-icon and an information sign as icon is misleading cause it doens't affect only the pen tool.
> 
> What pen-icon are you referring to? Do you mean the pencil
> (gimp-tool-pencil)? If not, which? And where else is this icon used?
> Also, same thing, please open a separate bug report.

I refer to gimp-device-status which is composed of the pencil icon and an 'i'
 
> Sorry about the organisational messages, but there are already too many
> unrelated messages here and I fear I will later miss some of your messages
> when I will take time to review your propositions. This is only so that your
> work does not get lost.

I was in doubt if it's better to open new bugs, because all I mention here are 'cosmetics' and need some retouche, no real bugs. But naturally, I can do so.

(In reply to Klaus Staedtler from comment #33)

> The wrong icons will show with symbolic icon theme, then select a tool
> (these icons itself are correct) and then in the tool-box the tab
> device-status. There you see a small icon of the selected tool in front of a
> foreground, background, and so on symbol. These minor icons are all correct
> symbolic, except handle-transform-tool & n-point-deformation-tool. Browsed
> whole symbolic icon directory, because - naturally - I first thought it was
> a failure of mine, but didn't find any 

Stupid me, I looked for colored icons and didn't see that the 16x16 handle-transform-tool & n-point-deformation-tool symbolic icons where missing in my gimp installation. Arggh. Blinded by icons it seems.

Please forgive the unnecessary noise

Created attachment 318171 [details]
Corrected symbolic handle-transform for dark-themes

As symbolic handle-transform didn't work correctly on dark themes I've added an updated (and tested) icon (all req. res and svg).

Please exchange the icon thanks

(In reply to Klaus Staedtler from comment #26)

> If anybody has a better idea to symbolize an icon theme: great, wonderful,
> marvellous. 
> Normally icons should be self-explaining and a substitution for text.
> Whenever a icon needs to be explained by words it's worth to consider if
> it's really necessary and useful to use this icon.

Thanks to a conversation with Martin Owens from Inkscape I thought: let's see what inkscape has new and yet unpublished (in preperation for inkscape 0.92) in their box.

Indeed they have a symbol icon now. A heraldic-fleur-de-lis. Really nice, and fully equipped with symbolic. If somebody says 'yes' I can upload these for gimp (according with the req. png's), I already have them in my experimental folder.

Maybe we should use this too (as they even have a colored one), hopefully nobody believes then gimp/inkscape is a troup of crusaders managed by french aristocrats... (just kidding)

Just to make sure, are the Inkscape icons GPLv3?
We want our icons to be GPLv3 too (and not just some Creative Commons variant or others). If they are not, would you mind asking the authors of the icon if they would accept to double-license the icons we require in GPLv3?

As for switching to this other icon, I am not against. I was getting used to the Yin-Yang, and I'm still not sure that a Fleur de Lys would be any better, but that's probably because I really have no idea what a good "icon-representative icon" could be, as I said before.
So I will let you in charge of deciding which one suits best for the task. :-) If you want to change to this other, just upload it and I will update, provided you made sure of the license conformance. If you want to keep your Yin-Yang icon, I'm fine with this too.

Thanks.

(In reply to Jehan from comment #37)
> Just to make sure, are the Inkscape icons GPLv3?

Before discussing licences (inkscape has GPLv2, but I'm absolutely sure it won't be a problem to get the icon GPLv3):

Yin-Yang is assigned to a principle (of mind, viewing the world, ...), nothing else. 

Fleur de Lis is quite the contrary, it is (over)loaded with meanings, historical events, political, religious, symbolic ... meanings. Luckily it is not assigned to one specific organisation, historical event, religion ...., otherwise it would disqualify itself.

I (for myself) prefer the emptyness (or freedom) of Yin-Yang. Thats - beside beeing one of the most used symbols - why I decided to use it as a symbol for all symbols.

> I (for myself) prefer the emptyness (or freedom) of Yin-Yang. Thats - beside beeing one of the most used symbols - why I decided to use it as a symbol for all symbols.

Then I suggest we stick with it. :-)
As said in comment 37, I let you in charge of deciding this.

The original icons was from the Art Libre icon set, but a contributor (jEsuSdA) provided a bunch of additional icons and unfortunately he did not provide SVG at the time (2013). I didn't realize but there seem to be a lot more than I thought.

I sent him an email asking him for original source SVG. Hopefully he will answer and send us the files so that you (or someone else) won't have to redo a job already done in the past. Let's wait.
Just in case, I set the list I made of images with missing SVG source (I may have made some mistake, since ids in the Art Libre SVG source don't always match perfectly with ids in our icon set).

gimp-center
gimp-color-triangle
gimp-controller-linux-input
gimp-convert-grayscale
gimp-convert-indexed
gimp-convert-rgb
gimp-display-filter-colorblind
gimp-display-filter-contrast
gimp-display-filter-gamma
gimp-display-filter-proof
gimp-display-filter-lcms
gimp-gradient-shapeburst-angular
gimp-gradient-shapeburst-dimpled
gimp-gradient-shapeburst-spherical
gimp-gradient-spiral-anticlockwise
gimp-gradient-spiral-clockwise
gimp-layer-to-imagesize
gimp-list

gimp-gradient-square
gimp-histogram-linear
gimp-images
gimp-layer-to-imagesize
gimp-list
gimp-navigation
gimp-path-stroke
gimp-path
gimp-resize
gimp-scale
gimp-selection-add
gimp-selection-replace
gimp-selection-to-channel
gimp-selection-to-path
gimp-toilet-paper
gimp-tool-preset
gimp-tools
gimp-warning

gimp-prefs-system-resources
gimp-frame
gimp-wilber-eek

(In reply to Jehan from comment #40)
> The original icons was from the Art Libre icon set, but a contributor
> (jEsuSdA) provided a bunch of additional icons and unfortunately he did not
> provide SVG at the time (2013). I didn't realize but there seem to be a lot

Don't worry. 

Had a first look on the missing ones, if the sources aren't available I can redo them (as long as you don't demand a 110% perfect copy). Would only require some time when I'm bored ;-).

We don't require a perfect copy. Feel free to even fix or change designs if you think you have a better idea.
I'm pretty sure you can be considered the "owner" of the GIMP icon sets with all the work you have produced now. :-)

By the way, I'd like to propose some rules:

- could you use the color scheme from the original source from now on (https://github.com/gnome-design-team/gnome-icons/tree/master/art-libre-symbolic/src), which is basically to draw only the inverted set.

I know that's contradictory to what I asked of you until now, but I am working on reorganizing the SVG source, and I started working with the Art Libre source file which — it turns out — was using the inverted scheme. Don't bother for all your previous SVG files. I already inverted them locally. Just for the next ones.

- could you make your icons in 16x16 in Inkscape. Of course, this is vectorial, so this is only for purely aesthetic reasons since we will have all the icons in the same file next to each other.
Why 16x16? Because once again that's the size of the original Art Libre source.

- could you make sure every icon is square and has all necessary space on the side, and especially it should be centered (a lot of the icons you originally contributed were not centered).
A trick for this is to create a 16x16 square. Make it in some color at first (like black), and center your icon in the middle of it once you are done. Then group the square and the icon together, and remove the fill color of the square (using Inkscape XML editor to select the square).

- set ids to your finale grouped object, corresponding to the file name. For instance the icon which is meant to become gimp-wilber.svg should have the "gimp-wilber" id.

If you have any question, do not hesitate. The goal is to make the icons automatically exported from a single SVG source file in the end. All these will help us do so. :-)
Thanks!

(In reply to Jehan from comment #42)

> I'm pretty sure you can be considered the "owner" of the GIMP icon sets with
> all the work you have produced now. :-)

Too much of reputation.

> - could you use the color scheme from the original source from now on
> (https://github.com/gnome-design-team/gnome-icons/tree/master/art-libre-
> symbolic/src), which is basically to draw only the inverted set.

No problem.

> - could you make your icons in 16x16 in Inkscape. 

No problem, luckily many of the missing external, icons alraedy have exactly that size.

> - could you make sure every icon is square and has all necessary space on
> the side, and especially it should be centered (a lot of the icons you
> originally contributed were not centered).

yes I know first icons where more-ore-less only a quick hack of bad quality and I was surprised at all.

Later ones are getting better and better (as I'm more experienced with inkscape. I only used inkscape over a year ago for some icons I've done for darktable, rygel and dvb-daemon ..., in the 90ies I've done lot's of OS/2 icons but thats another story).

> A trick for this is to create a 16x16 square. 

Have that found by myself ;-)

> - set ids to your finale grouped object, corresponding to the file name. For
> instance the icon which is meant to become gimp-wilber.svg should have the
> "gimp-wilber" id.

This is the way inkscape does it within their icon sheet, they too have a swatch-palette to change color globally, should I try this too ?

Created attachment 318260 [details]
Current GIMP symbolic icons with SVG source

So I have finally pushed the source file containing all icons:
https://git.gnome.org/browse/gimp/tree/icons/Symbolic/scalable.svg

It would be cool if you could work directly with it from now on.

As you will see (see the png export in attachment), all the icons are well organized in it. This is purely to make contributions easy and organized. :-)
The only thing which will really matter from scripting perspective will be to have each icon have a proper id corresponding to GIMP chosen codes.

Also the icons have to be proper square images, and be "standalone" (i.e.: if you export them as is, this has to be usable directly, which means properly spaced and centered…).

I have not yet looked in details to your previous amendments and new icons. So this file currently only contains the current state of GIMP tree.

> This is the way inkscape does it within their icon sheet, they too have a swatch-palette to change color globally, should I try this too ?

I assume this is a way to set named colors to SVG objects instead of hardcoding RGB colors each and every time. If so, yes definitely, use this! This would make things a lot easier if we decide to change colors globally.

Also I updated with your new letter and line spacing icons, both for symbolic and color themes:

commit 059ebca538438e0807a7238af51e79d9ff2052bf
Author: Klaus Staedtler <staedtler-przyborski@web.de>
Date:   Tue Jan 5 17:35:19 2016 +0100

    icons: updating gimp-letter-spacing and gimp-line-spacing icons.

For the channel visibility discussion, I have opened bug 760167 where I copied your proposition.

Your corrected handle transform icons are now pushed as well:

commit a27179de2ae0e4be7291bd103957114de05334e1
Author: Klaus Staedtler <staedtler-przyborski@web.de>
Date:   Tue Jan 5 17:51:31 2016 +0100

    icons: corrected symbolic handle-transform for dark-themes.

Correct me if I am wrong, but except the icons which currently don't exist and require a code update (any further discussion and upload of icons on the topic should go to bug 759904), all what is remaining in the current bug report is:

- get SVG for symbolic icons which have none (comment 40);
- discuss whether the current Wilber icon is not suitable. Personally it's indeed a different design as the color Wilber, but I don't mind. I like it too.

Am I missing anything that you wanted handled? I have skimmed through most of the report, but there are so many comments now, that it's hard to get a focus. :-)

(In reply to Jehan from comment #46)
> For the channel visibility discussion, I have opened bug 760167 where I
> copied your proposition.
> 
> Your corrected handle transform icons are now pushed as well:

Thanks, in the meanwhile I've drawn replacement icons (without TV), so regardless what happens channel will have correct methaphor.
 
> Correct me if I am wrong, but except the icons which currently don't exist
> and require a code update (any further discussion and upload of icons on the
> topic should go to bug 759904), all what is remaining in the current bug
> report is:
> 
> - get SVG for symbolic icons which have none (comment 40);

Exactly, thanks for the scalable.svg. Thats exactly what I wanted to start next, so you saved me a lot of work. THANKS

> - discuss whether the current Wilber icon is not suitable. Personally it's
> indeed a different design as the color Wilber, but I don't mind. I like it
> too.

The different design was not my problem, but after adding outline it really looked /&%%ß"

Maybe we should close this bug and open another for the 'SVG for symbolic icons which have none (comment 40)'.

> The different design was not my problem, but after adding outline it really looked /&%%ß"

So maybe that's only a SVG bug? Would it be possible to fix the Wilber icon by keeping this design?
If you really wish to change it, I propose you start a discussion on the gimp-gui mailing list. You may also propose another design, if you wish. :-)

> Maybe we should close this bug and open another for the 'SVG for symbolic icons which have none (comment 40)'.

Done! Bug 760176.
Closing this report as "fixed" since we don't have any missing Symbolic icon now, compared to the color set.

P.S.: you should have received an email, by the way, where I propose you write access on our repository so that you can work more comfortably. :-)