After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760167 - Slightly change color channel visibility UI
Slightly change color channel visibility UI
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-01-05 17:18 UTC by Jehan
Modified: 2018-05-24 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jehan 2016-01-05 17:18:35 UTC
I'm moving here a proposition by Klaus Staedtler who is doing our symbolic icons. As he noticed, it is hard to symbolize color channels in monochrome, which triggered this proposition.
Copied from bug 759673, comment 22:

--------------
Current channel window is somehow overpopulated. 
It show's
1. a visible icon, 
2. a small image 
3. translated-text for all existing channels in the image (due to the fact that the channel icons are insufficient to explain anything and they are not visible yet)

When you deselect a channel 
1. disappears 
2. gets toggled to a corresponding channel icon 
3. stays as it is

As the channel icons don't explain anything they are useless

My solution (as drop in replacement) changes 
2. it shows now a non-visible icon (similar icon for all channels, it's a simple crossed visible)

Better solution (but this would require some code change) 
1. toogles between visible/non-visible icon. 
2. when de-selected image disappears. 
3. ideally the text would be colored (for red green and blue channels).

I already added gimp-nonvisible.svg (and the needed png's) if someone say's: Yes we change the code, I can deliver a gimp-nonvisible for default icon theme very fast too.
Comment 1 Michael Natterer 2016-01-05 18:37:38 UTC
Or simply try GtkCellRendererToggle's "inconsistent" property?
Comment 2 Michael Natterer 2016-01-08 14:14:11 UTC
Colored text is a bad idea because of themes.

What about just changing the symbolic icon and make an exception by
having a small spot of the actual color inside the synbolic shape?
There simply aren't any metaphors for colors.
Comment 3 Jehan 2016-01-08 15:48:44 UTC
> What about just changing the symbolic icon and make an exception by having a small spot of the actual color inside the synbolic shape?

This means we can't invert the icon as easily (the inverse of a pure red is cyan). We will need to invert the grey parts of the image but keep the non-grey colors as is. This could be done as exception in our build process, of course, but just saying a straightforward color channel invert won't work. So that's additional work.

Also I wonder if this is portable, long-term since I am still not sure how icon themes work with GTK+3. I understood that GTK+3 themes have the concept of dark theme. Will the dark version of a theme invert automatically monochrome icons or we will still have to generate the inverted icon set? The former can be a problem with such non-monochome icons.
Comment 4 Michael Natterer 2016-01-08 16:32:17 UTC
I don't know, but I just realized that we need color component icons
regardless of what we do here, because we have the option do disable
previews, and then the icon is shown.
Comment 5 Klaus Staedtler 2016-01-08 19:08:33 UTC
(In reply to Michael Natterer from comment #4)
> I just realized that we need color component icons
> regardless of what we do here, because we have the option do disable
> previews, and then the icon is shown.

Thats why I suggested as temporal solution to show a 'gimp-channel-whatever the channel is-nonvisible' icon. 

Information is even better than showing a non-expressive different icon for each channel-type (okay colorored icons have here definitly a bargain, but we have the text too in both themes, so loss won't be critical). 

BTW. Photoshop has another solution 

channel on
1. view icon
2. channel preview tinted in channel type (red, blue and so on)
3. Name of the channel and shortcut


channel of
1. an empty square
2. channel preview tinted in channel type
3. Name of the channel and shortcut

see yourself http://www.automotiveillustrations.com/tutorials/photoshop-channels.html
Comment 6 Klaus Staedtler 2016-01-08 19:10:47 UTC
see yourself http://www.automotiveillustrations.com/tutorials/photoshop-channels.html

see by yourself ...not see yourself.
Comment 7 GNOME Infrastructure Team 2018-05-24 16:00:32 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/820.