After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760176 - Missing SVG source for some symbolic icons
Missing SVG source for some symbolic icons
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-01-05 19:07 UTC by Jehan
Modified: 2016-01-18 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gimp.svg preview (645.83 KB, image/svg+xml)
2016-01-08 20:22 UTC, Klaus Staedtler
Details
gimp.svg preview complete (97.19 KB, application/zip)
2016-01-09 16:08 UTC, Klaus Staedtler
Details
even more complete gimp.svg preview (715.48 KB, image/svg+xml)
2016-01-12 21:06 UTC, Klaus Staedtler
Details

Description Jehan 2016-01-05 19:07:13 UTC
The original icons was from the Art Libre icon set, but a contributor (jEsuSdA) provided a bunch of additional icons and unfortunately he did not provide SVG at the time (2013). I didn't realize but there seem to be a lot more than I thought.

I sent him an email asking him for original source SVG. Hopefully he will answer and send us the files so that you (or someone else) won't have to redo a job already done in the past. Let's wait.
Just in case, I set the list I made of images with missing SVG source (I may have made some mistake, since ids in the Art Libre SVG source don't always match perfectly with ids in our icon set).

gimp-center
gimp-color-triangle
gimp-controller-linux-input
gimp-convert-grayscale
gimp-convert-indexed
gimp-convert-rgb
gimp-display-filter-colorblind
gimp-display-filter-contrast
gimp-display-filter-gamma
gimp-display-filter-proof
gimp-display-filter-lcms
gimp-gradient-shapeburst-angular
gimp-gradient-shapeburst-dimpled
gimp-gradient-shapeburst-spherical
gimp-gradient-spiral-anticlockwise
gimp-gradient-spiral-clockwise
gimp-layer-to-imagesize
gimp-list

gimp-gradient-square
gimp-histogram-linear
gimp-images
gimp-layer-to-imagesize
gimp-list
gimp-navigation
gimp-path-stroke
gimp-path
gimp-resize
gimp-scale
gimp-selection-add
gimp-selection-replace
gimp-selection-to-channel
gimp-selection-to-path
gimp-toilet-paper
gimp-tool-preset
gimp-tools
gimp-warning

gimp-prefs-system-resources
gimp-frame
gimp-wilber-eek
Comment 1 Klaus Staedtler 2016-01-05 21:32:46 UTC
After a first overview situation looks like this:

gimp-center+
gimp-color-triangle+
gimp-controller-linux-input+
gimp-convert-grayscale+
gimp-convert-indexed+
gimp-convert-rgb+
gimp-display-filter-colorblind+
-gimp-display-filter-contrast (added was in art-libre)
gimp-display-filter-gamma+
gimp-display-filter-proof+
gimp-display-filter-lcms+
gimp-gradient-shapeburst-angular+
gimp-gradient-shapeburst-dimpled+
gimp-gradient-shapeburst-spherical+
gimp-gradient-spiral-anticlockwise+
gimp-gradient-spiral-clockwise+
gimp-layer-to-imagesize+
gimp-list+

gimp-gradient-square+
gimp-histogram-linear+
gimp-images+
gimp-layer-to-imagesize+
-gimp-navigation (added, was in art-libre , but in many cases it means locked, should there be a locked icon? )
gimp-path-stroke+
-gimp-path (=gimp-paths, a double)
-gimp-resize (=gimp-tool scale, triple use)
-gimp-scale (= gimp-tool-scale, triple use)
gimp-selection-add+
gimp-selection-replace+
gimp-selection-to-channel+
gimp-selection-to-path+
-gimp-tool-preset (=gimp-prefs-tools-preset, double use)
-gimp-tools+ (=gimp-prefs-toolbox double usage)
gimp-warning+
gimp-wilber-eek+
-gimp-prefs-system-resources (was in unused, moved and id set)


The following one's where always IMHO  png and never svg.

gimp-frame. Not really an image is a black(or white) frame surrounded by transparency, I'm sure it should better stay as png, it's only one file,

gimp-toilet-paper. Guess this was never a svg, it's an identical one-file png in all icon-themes.


For the double/triple usage I'll try to make different icons (when it makes sense).
Comment 2 Jehan 2016-01-06 03:56:02 UTC
Any idea when the frame icon is used?

Even when svg looks unneeded, I'd suggest to try and go full SVG. This way, we will be able to deal with any size of icons for all sort of screens (HiDPI, as well as very low res in particular).

Of course a full white/black image may seem completely OK in bitmap (it won't get bad when scaled), but the icon system may not like this and grab another generic not-found icon if we were to try and scale it.
Unless it is used in a special way where scaling is really never a problem. If you can figure what it is used for, it would be cool. :-)
Comment 3 Klaus Staedtler 2016-01-06 09:41:33 UTC
(In reply to Jehan from comment #2)

> If you can figure what it is used for, it would be cool. :-)

Made some brutal test: removed gimp-frame.png from all icon-themes. Found no difference. But didn't test every aspect of gimp (takes weeks I believe).

BTW.: there is a second 64x64 it's named gimp-texture png, it has thin diagonal lines and is missing from svg too.

Would it be ok to make them 1:1 as 64x64 svg (not 16x16) ? I'm afraid when scaling, the thin lines  or the 1px transparent frame gets scaled too. Whatever these icons are used for, I'm convinced they must be exactly as they are.

But I've found where toilet-paper is used :-) it's in the drop-down list 'templates' when creating a new image, all other images there are system icons. A joke I guess.
Comment 4 Michael Natterer 2016-01-06 12:28:57 UTC
The frame icon is used in gimpviewrenderer-frame.c and is expected
to be 48x48 pixels, it's used when images want a frame, like thubnails
have one.
Comment 5 Jehan 2016-01-06 14:22:55 UTC
Mitch > right now it is a fixed size, but can we imagine that in the future, with HiDPI screen, 48x48 might be considered too small even for thumbnails and that we would want dynamic resolution for this image too?

I think it is still better to have a vectorial version for everything when possible.
Comment 6 Klaus Staedtler 2016-01-06 17:44:41 UTC
I was wrong with gimp-texture. It is in gimp.svg but when exported as 64x64 png it looks quite weird.

Current state of missing svg

- gimp-center (added, new)
gimp-color-triangle+
gimp-controller-linux-input+
gimp-convert-grayscale+
gimp-convert-indexed+
gimp-convert-rgb+
- gimp-display-filter-colorblind (added, new)
- gimp-display-filter-contrast (added was in art-libre, needs rework,done)
- gimp-display-filter-gamma (added, new)
- gimp-display-filter-proof (added, new)
- gimp-display-filter-lcms (added, new)
gimp-gradient-shapeburst-angular+
gimp-gradient-shapeburst-dimpled+
gimp-gradient-shapeburst-spherical+
gimp-gradient-spiral-anticlockwise+
gimp-gradient-spiral-clockwise+
gimp-layer-to-imagesize+
gimp-list+

gimp-gradient-square+
- gimp-histogram-linear (renamed was gimp-histogram)
- gimp-histogram (added, new)
- gimp-images (added new)
gimp-layer-to-imagesize+
- gimp-navigation (added, was in art-libre , but in many cases it means locked, should there be a locked ? )
gimp-path-stroke+
- gimp-path+ (=gimp-paths, a double)
- gimp-resize+ (=gimp-tool scale, triple use)
- gimp-scale+ (= gimp-tool-scale, triple use)
gimp-selection-add+
gimp-selection-replace+
gimp-selection-to-channel+
gimp-selection-to-path+
- gimp-toilet-paper (added, currently new in gimp-templates-new.svg
- gimp-tool-preset+ (=gimp-prefs-tools-preset, double use)
- gimp-tools+ (added, double usage)
gimp-warning+

- gimp-prefs-system-resources+(was in unused)
gimp-frame+ (not an image is a black(or white) frame surrounded by transparency)
gimp-texture (guess thats wrong, diagonal texture gets scaled too)
gimp-wilber-eek+

NEW UNUSED

+ gimp-nonvisible
Comment 7 Klaus Staedtler 2016-01-08 20:22:28 UTC
Created attachment 318539 [details]
gimp.svg preview

If somebody wants to have a preview see attach

current state is like this:
MISSING

- gimp-center (added, new)
gimp-color-triangle+
gimp-controller-linux-input+
- gimp-convert-grayscale (added, new)
- gimp-convert-indexed (added, new)
- gimp-convert-rgb (added, new)
- gimp-display-filter-colorblind (added, new)
- gimp-display-filter-contrast (was in art-libre, reworked to match with other display filter)
- gimp-display-filter-gamma (added, new)
- gimp-display-filter-proof (added, new)
- gimp-display-filter-lcms (added, new)
- gimp-gradient-shapeburst-angular (added, new)
- gimp-gradient-shapeburst-dimpled (added, new)
- gimp-gradient-shapeburst-spherical (added, new)
- gimp-gradient-spiral-anticlockwise (added, new)
- gimp-gradient-spiral-clockwise (added, new)
- gimp-list (added, new)
- gimp-gradient-square (added, new)
- gimp-histogram-logarithmic (was missing from the missing list. added, new)
- gimp-histogram (added, new)
- gimp-images (added new)
gimp-layer-to-imagesize+
- gimp-navigation (added, new)
- gimp-path-stroke (added, new)
- gimp-path (added, new)
- gimp-resize (added, new)
- gimp-scale (added, new)
- gimp-selection-add (added, new)
- gimp-selection-replace (added, new)
- gimp-selection-to-channel (added, new)
- gimp-selection-to-path (added, new)
- gimp-toilet-paper (added, new needs testing)
- gimp-tool-preset (added, =gimp-prefs-folders-tool-presets, double use)
- gimp-warning'(added, new)
- gimp-prefs-toolbox (added, from gnome 3.12 symbolic theme)

gimp-wilber-eek+

??? gimp-frame+ (not an icon is a black(or white) frame surrounded by transparency)
??? gimp-texture (not an icon guess thats wrong here, diagonal texture gets scaled too, temp.removed)

CHANGES

- gimp-prefs-system-resources (moved, renamed, was in unused)
- g847 (renamed to gimp-grid)
- gimp-channels (new, no TV-metaphor)
- gimp-histogram-linear (renamed, was gimp-histogram)
- gimp-tools (renamed, was gimp-prefs-toolbox)
- gimp-wilber-outlined (outligning changed to 'bebebeff 30%')

NEW UNUSED

+ gimp-nonvisible

TODO:

Most important: what to do with: gimp-frame & gimp-texture


Some icons to paint, afterwards into the cooling-pond and having another look on it some days later, correct if necessary, finally to git.
Comment 8 Jehan 2016-01-08 20:45:59 UTC
gimp-texture is used in 2 docks: navigation and selection editor, as background when there is no image. Indeed not sure if that is very necessary to make vectorial versions, since it would be concatenated with itself and never actually scaled, I guess, anyway.

About the gimp-frame, you can leave it be also if you wish. As Mitch says, we always use it as a fixed size for now.
If ever this had to change, well then we will see. No need to get stuck too long on indecision. ;-)

Anyway great job.
Looking forward the finale version. :-)
Comment 9 Klaus Staedtler 2016-01-09 16:08:20 UTC
Created attachment 318588 [details]
gimp.svg preview complete

It's ready now. For a 'preview' and the changes see attach.

As said I wait a week or so before I upload gimp.svg to git, just to find minor whatsever and to see if I continue to like em in a week or not.
Comment 10 Klaus Staedtler 2016-01-09 16:45:58 UTC
I'm afraid toilet-paper must be removed:

Explanation: (Except from gnome-icon-theme-symbolic readme)

The color of the icon set is defined at runtime by the gtk theme.

If you need colorize specific part of an icon you need to set a class of that
object. In inkscape 0.47 this is sadly only achievable by selecting the object,
going into the xml editor and creating a new attribute 'class' and setting its
value. There are currently 3 possible values:

- warning - this maps to gtk @warning_color
- error - maps to @error_color
- success - maps to @success_color


The colors I've found are

if (warning_color)
    css_warning = rgba_to_string_noalpha (warning_color);
  else
    css_warning = g_strdup ("rgb(245,121,62)");

=orange

  if (error_color)
    css_error = rgba_to_string_noalpha (error_color);
  else
    css_error = g_strdup ("rgb(204,0,0)");

=red

  if (success_color)
    css_success = rgba_to_string_noalpha (success_color);
  else
    css_success = g_strdup ("rgb(78,154,6)");

=green


This means the toilet-paper icons gets more or less darkgray ( ("rgb(80,80,80)") in non-inverted theme. The joke returns into it's contrary ...
Comment 11 Michael Schumacher 2016-01-09 17:06:10 UTC
There is no joke there. This is used for the size of the toilet paper image size template, used e.g. by toilet paper pattern designers.
Comment 12 Klaus Staedtler 2016-01-09 17:19:57 UTC
(In reply to Michael Schumacher from comment #11)
> used e.g. by toilet paper pattern designers.

Wasn't aware of that.

But question remains: will they accept a darkgrey roll of toilet-paper as symbol for their templates (used colors in real-life are  white, pink, lavender, light blue, light green, purple, green, and light yellow) ? Estethical rather confusing.
Comment 13 Klaus Staedtler 2016-01-12 06:48:37 UTC
Please add the following for gimp-toilet-paper.png so it will stay white.



@@ -25,6 +25,7 @@ include $(top_srcdir)/icons/Symbolic/icon-list.mk
 # As an exception, we do not want to invert gimp-default-colors.
 # Just use it as-is.
 16/gimp-toilet-paper.png: $(top_srcdir)/icons/Symbolic/16/gimp-toilet-paper.png
+	mkdir -p `dirname $<`
 	cp -f $< $@
 
 # We are basically repeating the same rule for every subdirectory, which
Comment 14 Jehan 2016-01-12 17:21:37 UTC
> Please add the following for gimp-toilet-paper.png so it will stay white.

To answer the above, I don't feel that a darkened toilet paper symbolic icon would be that much of a problem. But I don't feel like bargaining, since I don't care that much. As long as the icon looks good everywhere (on both light and dark backgrounds), it may as well be the same everywhere. :-)
So we'll do as you say.

Feel free to commit your icons whenever you like. You will always be able to edit them afterwards anyway, if needed be.
Comment 15 Klaus Staedtler 2016-01-12 21:01:21 UTC
(In reply to Jehan from comment #14)
> > Please add the following for gimp-toilet-paper.png so it will stay white.
> 
> To answer the above, I don't feel that a darkened toilet paper symbolic icon
> would be that much of a problem. But I don't feel like bargaining, since I
> don't care that much. As long as the icon looks good everywhere (on both
> light and dark backgrounds), it may as well be the same everywhere. :-)
> So we'll do as you say.


Sorry to tell, but there are more exceptions ...

gimp-color-picker-black
gimp-color-picker-white

and those are not that easy, because they must be inverted, BUT the small quarter indicating black or white must stay black or white. 


Possible solution 1. renaming the icons (black gets white and the other way round)

gimp-color-picker-grey is not a problem.

Solution 2, as the exceptions are growing... and this one would catch gimp-stand-color and gimp-toilet-paper too, no need to apply extra code).

I came back to my color-swatch idea (shamelessly copied from inkscape)

we have two sheets. gimp-symbolic.svg and gimp-symbolic-inverted.svg

Only one sheed needs to be managed. The other one is a copy with a minor difference (color-pattern bebebeff is changed to color-pattern 505050ff). 

In gimp-symbolic all 'standard color' (bebebeff at the moment) has to be assigned to a color pattern which can the be changed by the swatch-field with a single klick. 

All other colors (black or white for instance) stay as they are set by the designer. 

In gimp-symbolic-inverted 'standard-color' will be 505050ff then.

symbolic icons are created from gimp-symbolic.svg

symbolic-inverted from gimp-symbolic-inverted.svg


> 
> Feel free to commit your icons whenever you like. You will always be able to
> edit them afterwards anyway, if needed be.

I pulled sources from git today and build all png's in all res. just to check everything is in place in gimp.svg.

No it wasn't. 
gimp-tool-preset was missing.

gimp-tool-blend was identical with gimp-gradient-linear. Sometimes economic use of icons (use them several times) makes sense, but quite often it doesn't, so I painted a new one (despite the fact that gimp has much to many icons ;-). 


BTW. with current color bebebeff in gimp.svg is the theme then called 'symbolic' or symbolic-inverted' ?
Comment 16 Klaus Staedtler 2016-01-12 21:06:34 UTC
Created attachment 318920 [details]
even more complete gimp.svg preview

State this evening. I'm some days away and before something happens a backup here ...

see attach
Comment 17 Klaus Staedtler 2016-01-18 15:44:15 UTC
As all missing icons are now in scalable.svg and committed to master...

This bug can be closed
Comment 18 Jehan 2016-01-18 15:47:09 UTC
Do not hesitate to close a report yourself when you finished the work. :-)
Anyway, closed as "Resolved > Fixed".