GNOME Bugzilla – Bug 725464
Add HiDPI icon theme for gimp-2.9 (gtk2)
Last modified: 2018-01-05 00:12:35 UTC
The gtk2-based Gimp 2.9, when running on a GNOME 3.10 or 3.12 system set to HiDPI mode (scaling-factor 2), picks up correct font scaling but doesn't scale up any of the icons such as the toolbox icon buttons. This makes it very hard to pick the tools... Since 2.9/2.10 seems to still be planned as a gtk2 release, it might be nice to include a HiDPI theme that scales up the toolbox icon buttons, whether or not higher-res icons actually get made. (Note that the gtk3-port branch (see bug 725263) shows the buttons at a nice size thanks to gtk3's built-in HiDPI scaling, though blurry because the icons are only available at low-resolution.)
Created attachment 270646 [details] Screenshot of Gimp-2.9 under Fedora 20+GNOME 3.12 on Retina MacBook Pro; default theme
I've got a really quick stub of a HiDPI theme on github: https://github.com/brion/gimp/commit/0ddbf9b3732e11a5e7033418c17732295183a885 There's probably a better way to set the stock GTK icon sizes in the theme, but this version just bumps up from 'button' to 'dialog' size, and adjusts some of the other widgets.
Created attachment 282013 [details] Screenshot of GIMP 2.8 on a QHD+ display with the HIDPI theme
(In reply to comment #2) > I've got a really quick stub of a HiDPI theme on github: > https://github.com/brion/gimp/commit/0ddbf9b3732e11a5e7033418c17732295183a885 > > There's probably a better way to set the stock GTK icon sizes in the theme, but > this version just bumps up from 'button' to 'dialog' size, and adjusts some of > the other widgets. I can confirm this bug in Gimp 2.8 (Ubuntu Gnome 14.04) on a Dell Precision M3800 laptp, equipped with a QHD+ display. Thanks to Brion's HIDPI theme, we have a workaround for now, but do note that some icons still stubbornly refuse to scale.
We will not fix anything about HIDPI themes on 2.8. Can you check if the same problems appear in git master? We just changed to actually using icon themes.
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for. Thanks!
I've tested Gimp 2.9 with a Surface Pro 3 and Windows 8.1. In the attached screenshot I marked two problems: 1. The (toolbox) icons are off cause still small. But the gtkrc from Brion doesn't work in Gimp 2.9. 2. The up/down button in the custom Gimp size widget are even smaller then normal.
Created attachment 304023 [details] Gimp 2.9 Surface Pro 3
Is this the gtk3-port branch? Pointing out HiDPI issues in git master is of no use, see comment 5.
Yes, this was git master. In comment 5 you have not written anything about gtk3-port. The title of this bug report is even "Add HiDPI icon theme for gimp-2.9 (gtk2)". The problem at the moment is, that icon themes don't work any longer in 2.9. The theme works with 2.8. Why are you against adding a HiRes Icon theme to Gimp 2.9/2.10? We are not talking about code changes. Thats a gtk3 job, we know that.
Yeah sorry that was unclear. The discussion about this has continued on IRC a while ago, but not in this bug. We switched to using icon themes in master, and theme authors should adapt their themes. It's clear that themes that change icons via gtkrc don't work any longer and need to be updated, unless I miss something. There is for example the issue that stock icons now have a problem in GIMP when replaced in a theme, but the same works fine for the built-in GTK+ icons. I have no problem shipping or supporting HiDPI icons in 2.10, but our resources are very limited so this is very low priority compared to other things, therefore it was tentatively moved to 3.x. I guess my point is: if you want HiDPI icons working in 2.10, you better fix the problems and attach patches here :)
*** Bug 763883 has been marked as a duplicate of this bug. ***
*** Bug 774028 has been marked as a duplicate of this bug. ***
For the Windows platforms, we could use the existing manifest to tell the OS that we're not DPI-aware: http://www.danantonielli.com/adobe-app-scaling-on-high-dpi-displays-fix/ We got the exact opposite in the current gimp.manifest file, so I'm not sure if doing this could be worse.
(In reply to Michael Schumacher from comment #14) > We got the exact opposite in the current gimp.manifest file, so I'm not sure > if doing this could be worse. Follow-up on that: it would be, the whole UI would get blurry.
Personally, I'm tempted to close this as FIXED, since we already make it possible to make large icons in 2.9.x.
Indeed. This is now fixed. By default, GIMP will propose big icons for high density screens. It will even auto-detect the density and propose something reasonable by default (and it is be possible to override this auto-detection by choosing smaller/bigger icons). As Mitch explains, third party theme creators will indeed have to update their theme, and in particular they will have to split the icons from the rest of the theme. Icon themes can be vector or bitmap, and they can propose several fixed size. I should make a blog post or something about the exact sizes, I guess. So yeah, this is all good, I guess. We now have HiDPI themes and third-party theme writers can propose their own as well.