GNOME Bugzilla – Bug 706115
Implement the new display settings designs
Last modified: 2013-08-20 17:42:25 UTC
The current design has all kinds of issues with it: it is purely focused on setting up multi-display workstations, with no focus on presentation scenarios, it has a confusing state when there is only one display, setting the primary display is hard, and it doesn't give much information about the various modes that are available. The new designs aim to address these various issues: https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/displays/displays-v2.png The new design should also accommodate a wider range of display types, including wireless displays.
Created attachment 251914 [details] [review] initial implementation of the new design This is an initial implementation of the new design for the display panel. The display previews and presentation mode are not yet fully implemented. This patch also includes the removal of the confirmation dialog from the configuration process, as suggested in bug 635564. This patch also requires attachment 251513 [details] [review] from bug 705919.
I'll have to get the office on monday to try with multiple monitors. So far, my impressions: - a bit bland, without the preview - the size change of the display image when rotating is pretty irritating. I would expect the representation to stay the same size. - I was playing with the rotation buttons for a while. When I eventually clicked done, I found my screen suddenly upside-down ! very surprising, because the top bar in the dialog was a the top
Thanks for the patch, Thomas! Here's my review: Panel * Display titles should be horizontally aligned * When a built-in display has its lid closed, it is insensitive. This should be indicated by: having a black thumbnail and dimming the text in the list row Display Dialog * List text color should be inverted (ie. it should be white) when a row is selected * Done button should be labelled "Apply". Should be insensitive until a change is made. * Add 12px vertical padding between rotate buttons and the details below * The rotate buttons shouldn't allow you to turn a display upside down - you could make the rotate right button go insensitive once in the right/vertical position, etc Arrange Displays Dialog * Change the background color to use the grey "system" texture * There seems to be too much padding between the arrange widget and the titlebar Thumbnails and OSDs * Black squares with numbers on the thumbnails need work (rounded corners, centered numbers) - they should look exactly the same as the actual OSD * Use a "screenshot" of the display (wallpaper + top bar, if there is one) for the thumbnail * In vertical orientation, the thumbnail doesn't seem to have the correct aspect ratio
Created attachment 252266 [details] [review] display: initial implementation of the new design This new patch address some of the issues mentioned above and is rebased on current master. It also requires the new patch proposed for bug 705919.
Created attachment 252427 [details] [review] display: initial implementation of the new design This version addresses a few more of the comments above and also updates the required version of gnome-desktop. The patch was also created with the "minimal" option to try and reduce its size.
Lots of issues fixed! Here's what's remaining: Display Dialog * List text color should be inverted (ie. it should be white) when a row is selected Arrange Displays Dialog * Change the background color to use the grey "system" texture * Please remove 24px vertical padding from the top of the thumbnail * Please remove 18px vertical padding from the top of the Cancel/Apply buttons Thumbnails and OSDs * Black squares with numbers on the thumbnails need work (rounded corners, centered numbers) - they should look exactly the same as the actual OSD * Use a "screenshot" of the display (wallpaper + top bar, if there is one) for the thumbnail
Attachment 252427 [details] pushed as b4a16be - display: initial implementation of the new design The final patch includes some padding tweaks, as discussed on IRC. The issues with the display previews can be addressed in bug 706429. I think the issue with the labels may be to do with the theme, so I have opened bug 706408 for that. I have also opened bug 706432 to track implementation of the presentation mode.