GNOME Bugzilla – Bug 706429
Display preview issues
Last modified: 2013-08-30 12:40:42 UTC
As described in bug 706115, there are a few issues with the display previews: * Black squares with numbers on the thumbnails need work (rounded corners, centered numbers) - they should look exactly the same as the actual OSD * Use a "screenshot" of the display (wallpaper + top bar, if there is one) for the thumbnail
Created attachment 253234 [details] [review] display: improve the display previews Add the current background to the display previews and improve the display number indicators.
Created attachment 253501 [details] Screenshot Before
Created attachment 253502 [details] Screenshot After
Review of attachment 253234 [details] [review]: Looks good. Unrelated to this patch, I noticed that even though cc-display-panel.c includes math.h it doesn't link to libm. ::: panels/display/cc-display-panel.c @@ +70,3 @@ + GnomeBG *background; + GnomeDesktopThumbnailFactory *thumbnail_factory; Do we really need them for the whole lifetime of the object? They are only used once. I don't really care. Upto you.
Comment on attachment 253234 [details] [review] display: improve the display previews Attachment 253234 [details] pushed as 183e318 - display: improve the display previews (In reply to comment #4) > ::: panels/display/cc-display-panel.c > @@ +70,3 @@ > > + GnomeBG *background; > + GnomeDesktopThumbnailFactory *thumbnail_factory; > > Do we really need them for the whole lifetime of the object? They are only used > once. I don't really care. Upto you. The background and thumbnail factory objects are used each time the preview is painted, which is why they are kept for the lifetime of the object.