After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706408 - Dim labels in GtkListBoxRow can be difficult to read
Dim labels in GtkListBoxRow can be difficult to read
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-20 15:05 UTC by Thomas Wood
Modified: 2013-08-31 18:31 UTC
See Also:
GNOME target: 3.10
GNOME version: ---


Attachments
screenshot (66.18 KB, image/png)
2013-08-23 17:35 UTC, Allan Day
  Details
Screenshot showing a selected row (60.17 KB, image/png)
2013-08-29 13:51 UTC, Thomas Wood
  Details
Use currentColor to set the color property of dim-labels (1.02 KB, patch)
2013-08-30 14:28 UTC, Thomas Wood
committed Details | Review
Screenshot after applying attachment 253621 (61.39 KB, image/png)
2013-08-30 17:11 UTC, Thomas Wood
  Details

Description Thomas Wood 2013-08-20 15:05:27 UTC
Labels with the GTK_STYLE_CLASS_DIM_LABEL style class inside a GtkListBoxRow can be difficult to read when the row is selected.
Comment 1 Allan Day 2013-08-23 17:35:55 UTC
Created attachment 252930 [details]
screenshot

Yes, the contrast is a bit low there. It's a combination of the darker background and lighter text.
Comment 2 Thomas Wood 2013-08-29 13:51:58 UTC
Created attachment 253507 [details]
Screenshot showing a selected row

There is also a contrast issue when a dim label is used and a row is selected.
Comment 3 Thomas Wood 2013-08-30 14:28:53 UTC
Created attachment 253621 [details] [review]
Use currentColor to set the color property of dim-labels

This patch fixes the issue by calculating the value of the color property based on the currentColor value.
Comment 4 Jakub Steiner 2013-08-30 15:56:09 UTC
Review of attachment 253621 [details] [review]:

currentColor comes as a shocking news to me. Looks like a cool hack!
Comment 5 Thomas Wood 2013-08-30 17:11:54 UTC
Created attachment 253636 [details]
Screenshot after applying attachment 253621 [details] [review]
Comment 6 Matthias Clasen 2013-08-31 15:21:42 UTC
We should get this landed for .91
Comment 7 Cosimo Cecchi 2013-08-31 18:31:00 UTC
Attachment 253621 [details] pushed as 9a85875 - Use currentColor to set the color property of dim-labels

Pushed, but changed the alpha factor to keep it consistent with the current style in the non-selected case.