GNOME Bugzilla – Bug 706408
Dim labels in GtkListBoxRow can be difficult to read
Last modified: 2013-08-31 18:31:03 UTC
Labels with the GTK_STYLE_CLASS_DIM_LABEL style class inside a GtkListBoxRow can be difficult to read when the row is selected.
Created attachment 252930 [details] screenshot Yes, the contrast is a bit low there. It's a combination of the darker background and lighter text.
Created attachment 253507 [details] Screenshot showing a selected row There is also a contrast issue when a dim label is used and a row is selected.
Created attachment 253621 [details] [review] Use currentColor to set the color property of dim-labels This patch fixes the issue by calculating the value of the color property based on the currentColor value.
Review of attachment 253621 [details] [review]: currentColor comes as a shocking news to me. Looks like a cool hack!
Created attachment 253636 [details] Screenshot after applying attachment 253621 [details] [review]
We should get this landed for .91
Attachment 253621 [details] pushed as 9a85875 - Use currentColor to set the color property of dim-labels Pushed, but changed the alpha factor to keep it consistent with the current style in the non-selected case.