GNOME Bugzilla – Bug 705069
Port from dbus-python to Gio GDBus API
Last modified: 2016-04-04 08:33:32 UTC
dbus-python is deprecated for years and not part of GNOME anymore https://developer.gnome.org/gio/unstable/ch32.html
Yes, its a temporary solution, we're currently blocked on bug 656330
#656330 might be solved already
The only component of Music that depends on dbus-python is the MPRIS plugin. See also https://bugzilla.gnome.org/show_bug.cgi?id=759751
*** Bug 759751 has been marked as a duplicate of this bug. ***
dropping dependency cleanup bugs from the target list at this point
Created attachment 324146 [details] [review] Port MPRIS to pydbus Ported MPRIS from dbus-python to pydbus. Relevant Links: https://github.com/LEW21/pydbus https://dbus.freedesktop.org/doc/dbus-specification.html#idp94392448 https://specifications.freedesktop.org/mpris-spec/latest/ I'm not sure how to go about adding pydbus as a dependency and therefore the patch doesn't address that.
Created attachment 324293 [details] [review] Port MPRIS to Gio GDBUS API After Felipe's suggestion on IRC "it is always better to use our own stack", turns out it's possible to drop the need for pydbus altogether.
(In reply to Gaurav Narula from comment #7) > Created attachment 324293 [details] [review] [review] > Port MPRIS to Gio GDBUS API > > After Felipe's suggestion on IRC "it is always better to use our own stack", > turns out it's possible to drop the need for pydbus altogether. It reduces the dependencies, but pydbus is a "Pythonic" API on top of GDBus, so if it had been a lot of work to port it, I would have advised not to port the code, but as it's already done.
Created attachment 324303 [details] [review] Handle an edge case in GetAll The edge case wasn't picked up by MPRISTester but was rather detected while using a Shell Extension.
Review of attachment 324293 [details] [review]: looks good.
Review of attachment 324303 [details] [review]: sure.
Thanks for your patch.