After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694435 - Implement new media controls
Implement new media controls
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 163345 376624 397824 589856 634475 657527 666802 676994 680713 693795 694436 694437 (view as bug list)
Depends on: 697296 698969
Blocks: 697896 697897 698975 698976
 
 
Reported: 2013-02-22 11:09 UTC by Bastien Nocera
Modified: 2013-04-29 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
main: Implement new overlay controls (93.43 KB, patch)
2013-04-04 11:19 UTC, Bastien Nocera
none Details | Review
main: Implement new overlay controls (106.25 KB, patch)
2013-04-05 07:28 UTC, Bastien Nocera
none Details | Review
main: Implement new overlay controls (119.30 KB, patch)
2013-04-09 15:16 UTC, Bastien Nocera
none Details | Review
XXX Use a frame for the OSD (2.87 KB, patch)
2013-04-09 15:17 UTC, Bastien Nocera
none Details | Review
main: Implement new overlay controls (126.02 KB, patch)
2013-04-11 15:43 UTC, Bastien Nocera
none Details | Review
main: Implement new overlay controls (143.00 KB, patch)
2013-04-11 17:46 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2013-02-22 11:09:25 UTC
For both fullscreen and windowed mode.

This is how it looks in WebKitGTK+:
http://blogs.igalia.com/xrcalvar/2013/02/20/new-media-controls-in-webkitgtk/

And the designs:
https://live.gnome.org/Design/Apps/Videos#Tentative_Design
Comment 1 Bastien Nocera 2013-02-22 11:47:55 UTC
*** Bug 694437 has been marked as a duplicate of this bug. ***
Comment 2 Bastien Nocera 2013-02-22 11:48:02 UTC
*** Bug 694436 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2013-02-22 12:02:28 UTC
*** Bug 693795 has been marked as a duplicate of this bug. ***
Comment 4 Bastien Nocera 2013-02-22 12:02:35 UTC
*** Bug 676994 has been marked as a duplicate of this bug. ***
Comment 5 Bastien Nocera 2013-02-22 12:02:44 UTC
*** Bug 657527 has been marked as a duplicate of this bug. ***
Comment 6 Bastien Nocera 2013-02-22 12:02:55 UTC
*** Bug 634475 has been marked as a duplicate of this bug. ***
Comment 7 Bastien Nocera 2013-02-22 12:06:40 UTC
*** Bug 680713 has been marked as a duplicate of this bug. ***
Comment 8 Bastien Nocera 2013-02-22 12:15:19 UTC
*** Bug 376624 has been marked as a duplicate of this bug. ***
Comment 9 Bastien Nocera 2013-02-22 12:15:36 UTC
*** Bug 397824 has been marked as a duplicate of this bug. ***
Comment 10 Bastien Nocera 2013-02-22 12:18:04 UTC
*** Bug 589856 has been marked as a duplicate of this bug. ***
Comment 11 Bastien Nocera 2013-02-22 12:19:55 UTC
*** Bug 666802 has been marked as a duplicate of this bug. ***
Comment 12 Bastien Nocera 2013-02-22 12:21:16 UTC
Notes from duplicate bugs:
- Move the exit fullscreen to the main toolbar
- Controls should appear on _mouse_ motion, or single-tap for a touchscreen, or a key binding
- Video's name should be ellipsised
- Popup should be away from the edges, so that the volume popup doesn't run into the edge of the screen
- The popup will be overlaid on the video, so the video will not resize
Comment 13 Bastien Nocera 2013-03-18 07:31:26 UTC
*** Bug 163345 has been marked as a duplicate of this bug. ***
Comment 14 Bastien Nocera 2013-03-18 07:33:14 UTC
Note that we'll be showing:
time [=====[]===] time left
for the seek bar rather than time / total time
as the total time is already available in the properties tab.
Comment 15 Bastien Nocera 2013-04-04 11:19:06 UTC
Created attachment 240582 [details] [review]
main: Implement new overlay controls

To replace the static controls we currently have.

TODO:
- Fix clutter warnings due to the use of margins in the layout
(totem:23486): Clutter-WARNING **: ./clutter-actor.c:9752: Actor 'BaconVideoControlsActor' tried to allocate a size of -63.00 x -31.00
- Move GdFullscreenFilter to main
- Really centre the play/pause widgets
- Make fullscreen exit button work
- Show buffering progress somehow
- Set a minimum width for the video widget so the controls can be shown
- Rework showing/hiding the controls
- Fix sensitivity of the seekbar and volume buttons
- File bugs about clipped buttons in the overlay (volume button in particular)
- Fix double-clicks going through the controls overlay
- Port the browser plugin to it too
- Use a GtkHeaderBar or CSD to show film title and buttons
Comment 16 Bastien Nocera 2013-04-05 07:28:37 UTC
Created attachment 240699 [details] [review]
main: Implement new overlay controls

To replace the static controls we currently have.

TODO:
- Fix clutter warnings due to the use of margins in the layout
(totem:23486): Clutter-WARNING **: ./clutter-actor.c:9752: Actor 'BaconVideoControlsActor' tried to allocate a size of -63.00 x -31.00
- Move GdFullscreenFilter to main
- Really centre the play/pause widgets
- Investigate sidebar resizing (or nuke it)
- Show buffering progress somehow
- Rework showing/hiding the controls
- File bugs about clipped buttons in the overlay (volume button in particular)
- Fix double-clicks going through the controls overlay
- Port the browser plugin to it too
- Use a GtkHeaderBar or CSD to show film title and buttons
Comment 17 Bastien Nocera 2013-04-09 15:16:25 UTC
Created attachment 241068 [details] [review]
main: Implement new overlay controls

To replace the static controls we currently have.

TODO:
- Fix clutter warnings due to the use of margins in the layout
(totem:23486): Clutter-WARNING **: ./clutter-actor.c:9752: Actor 'BaconVideoControlsActor' tried to allocate a size of -63.00 x -31.00
See https://bugzilla.gnome.org/show_bug.cgi?id=697296

- Really centre the play/pause widgets

- Show buffering progress somehow

- Rework showing/hiding the controls

- File bugs about clipped buttons in the overlay (volume button in particular)
  and original minimum size (remove hard-coded width)
See https://bugzilla.gnome.org/show_bug.cgi?id=697554

- Fix double-clicks going through the controls overlay
See https://bugzilla.gnome.org/show_bug.cgi?id=697380

- Port the browser plugin to it too
Comment 18 Bastien Nocera 2013-04-09 15:17:32 UTC
Created attachment 241069 [details] [review]
XXX Use a frame for the OSD

See https://bugzilla.gnome.org/show_bug.cgi?id=697554
Comment 19 Bastien Nocera 2013-04-11 15:43:39 UTC
Created attachment 241266 [details] [review]
main: Implement new overlay controls

To replace the static controls we currently have.
With help from Cosimo Cecchi for the overlay theming.

TODO:
- Fix clutter warnings due to the use of margins in the layout
(totem:23486): Clutter-WARNING **: ./clutter-actor.c:9752: Actor 'BaconVideoControlsActor' tried to allocate a size of -63.00 x -31.00
See https://bugzilla.gnome.org/show_bug.cgi?id=697296

- Really centre the play/pause widgets

- Show buffering progress somehow

- Rework showing/hiding the controls

- Port the browser plugin to it too
Comment 20 Bastien Nocera 2013-04-11 17:46:37 UTC
Created attachment 241286 [details] [review]
main: Implement new overlay controls

To replace the static controls we currently have.
With help from Cosimo Cecchi for the overlay theming.

TODO:
- Fix clutter warnings due to the use of margins in the layout
(totem:23486): Clutter-WARNING **: ./clutter-actor.c:9752: Actor 'BaconVideoControlsActor' tried to allocate a size of -63.00 x -31.00
See https://bugzilla.gnome.org/show_bug.cgi?id=697296

- Really centre the play/pause widgets

- Make buffering overlay semi-transparent, sync with
gnome-control-center
Test with http://ice.atv-stream.de:8000/db0tv.nsv for example

- Rework showing/hiding the controls
  (Punt this to a separate bug)

- Port the browser plugin to it too

- Header bar isn't semi-transparent
Comment 21 Bastien Nocera 2013-04-29 15:26:46 UTC
Attachment 241286 [details] pushed as 848309d - main: Implement new overlay controls

Still a bunch of warnings and bugs due to libraries, and a few TODO items.