After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697897 - Rework showing/hiding the controls
Rework showing/hiding the controls
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
3.12
Depends on: 694435
Blocks:
 
 
Reported: 2013-04-12 16:34 UTC by Bastien Nocera
Modified: 2014-02-04 16:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2013-04-12 16:34:34 UTC
We probably need 2 different behaviours based on mouse/touchpad and touch.

Mouse:
- Similar to Totem's old behaviour, motion would show the controls, hide after a timeout

Touch:
- Show/hide on tap

We could also go with just show/hide on click.

We should also show the controls:
- when skipping using the keyboard
- until the movie has really started playing when opening it, or other buffering actions are on-going
- after pausing
Comment 1 Jakub Steiner 2013-04-13 08:08:04 UTC
I agree with your proposal. Special casing mouse here to not require a click would be good, and the other cases you list for keeping the controls visible make sense as well. Extra points for fade transitions.
Comment 2 Michal 'hramrach' Suchanek 2013-12-25 21:19:06 UTC
why would you show controls when skipping with keyboard?

actually, totem does not have OSD so it makes sense to display the sucky position indicator it has along with the other useless cruft because there is no option to show it separately.

Similarly, the controls don't help you when buffering. You want an indicator for that. It should be probably displayed in place of the video or overlayed over the last piece of the video that totem managed to display.
Comment 3 Bastien Nocera 2014-01-07 13:20:42 UTC
(In reply to comment #2)
> why would you show controls when skipping with keyboard?

Because it provides feedback.

> actually, totem does not have OSD

It does, and a pretty big one due to a rendering bug in 3.10.

> so it makes sense to display the sucky
> position indicator it has along with the other useless cruft because there is
> no option to show it separately.

"sucky position indicator"? That's helpful.

> Similarly, the controls don't help you when buffering. You want an indicator
> for that.

There's already one.

>It should be probably displayed in place of the video or overlayed
> over the last piece of the video that totem managed to display.

Which is what it is in Totem master. You're reading a bug about the redesigned Totem having only used the stable versions. Best keep up with the context of bugs before commenting in the future.
Comment 4 Bastien Nocera 2014-02-04 11:55:02 UTC
(In reply to comment #0)
> We probably need 2 different behaviours based on mouse/touchpad and touch.
> 
> Mouse:
> - Similar to Totem's old behaviour, motion would show the controls, hide after
> a timeout

Done.

> Touch:
> - Show/hide on tap

Done.

> We could also go with just show/hide on click.

Didn't do that.

> We should also show the controls:
> - when skipping using the keyboard
> - until the movie has really started playing when opening it, or other
> buffering actions are on-going
> - after pausing

Still need to implement all those.

Also, we need the popups not to hide when we're using the fullscreen popup.
Comment 5 Bastien Nocera 2014-02-04 16:39:17 UTC
(In reply to comment #4)
> > We should also show the controls:
> > - when skipping using the keyboard

Didn't implement that.

> > - until the movie has really started playing when opening it, or other
> > buffering actions are on-going

That's done.

> > - after pausing

Didn't implement that.

> Still need to implement all those.
> 
> Also, we need the popups not to hide when we're using the fullscreen popup.

Done.

Let's see how people like it.