After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589856 - Add key for displaying controls
Add key for displaying controls
Status: RESOLVED DUPLICATE of bug 694435
Product: totem
Classification: Core
Component: Movie player
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: Robin Stocker
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-07-27 11:19 UTC by Robin Stocker
Modified: 2013-02-22 12:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display-controls.patch (6.86 KB, patch)
2009-07-27 11:29 UTC, Robin Stocker 		needs-work Details | Review
display-controls-2.patch (7.31 KB, patch)
2009-08-01 11:33 UTC, Robin Stocker 		needs-work Details | Review

Description Robin Stocker 2009-07-27 11:19:12 UTC 
Sometimes it's useful to be able to briefly display the controls in full screen mode by pressing a key, instead of moving the mouse. As discussed in bug #559024 (http://bugzilla.gnome.org/show_bug.cgi?id=559024#c10), this is a separate bug report for this.
Comment 1 Robin Stocker 2009-07-27 11:29:04 UTC 
Created attachment 139273 [details] [review]
display-controls.patch

Make it possible to briefly display the controls in full screen mode by pressing D, using the command-line argument --display-controls or a LIRC key.

It's not tested yet and I'm not sure about the LIRC stuff.
Comment 2 Bastien Nocera 2009-07-31 14:42:45 UTC 
KEY_DISPLAY is definitely wrong for the LIRC config.

Could you please use "--show-controls" instead of "--display-controls" as well?

Rest looks fine.
Comment 3 Robin Stocker 2009-08-01 11:33:09 UTC 
Created attachment 139679 [details] [review]
display-controls-2.patch

Ok, changed it to "show" everywhere. Should we change the key to "s" or "c" as well?

I commented out the LIRC configuration as with another command, the user can choose a key herself.
Comment 4 Bastien Nocera 2009-08-01 11:44:45 UTC 
I just checked the driver for the PS3 Bluetooth remote, and you should use KEY_INFO for showing the controls (and the LIRC bits should actually toggle the controls showing, not just show them).

There's also a "toggle-controls" which is only used for windowed mode, so "show-controls" should work in windowed mode as well.
Comment 5 Robin Stocker 2009-08-02 14:39:14 UTC 
(In reply to comment #4)
> (and the LIRC bits should actually toggle the
> controls showing, not just show them).

Should there be a "toggle controls" for full-screen mode, which will always show the controls?

> There's also a "toggle-controls" which is only used for windowed mode, so
> "show-controls" should work in windowed mode as well.

Should it behave as if "toggle controls" was pressed, then wait a time and then toggle them again? Or should it show just the controls (without the menu or sidebar)?
Comment 6 Bastien Nocera 2013-02-22 12:18:04 UTC 
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 694435 ***