GNOME Bugzilla – Bug 692966
Password in shield zooms out of the way
Last modified: 2013-05-20 17:19:36 UTC
Like any other window being closed, instead of the overlay simply disappearing. gnome-shell master 644b8304ab2f9ed0925a4d395af00b9c272e5e7a
I have no idea what this bug report is saying.
When you type in your password, the layer in which you typed your password shrink to a very small size (like the default mutter "close window" animation). The top bar is also invisible during that animation.
Created attachment 234953 [details] [review] screenShield: Fade instead of zooming out on unlock Zooming out to 0 causes big translation movements which, especially on large monitors and on such a short animation, might cause some eye strain. -- I've been repeating this like a broken record, maybe it's just me and I should get an appointment at an ophthalmologist?
Created attachment 234955 [details] [review] screenShield: Fade instead of zooming out on unlock -- Rebased on master now.
Created attachment 234956 [details] [review] screenShield: Pop modes before starting unlock animation This way the top panel remains visible while the shield hiding animation is ongoing instead of suddenly appearing just when it ends.
Created attachment 235075 [details] [review] css: Keep the panel height the same in all modes Since the panel affects struts, if we change its height on mode transitions, windows will move around which is particularly noticable with maximized windows when coming out of the screen shield.
Created attachment 235076 [details] [review] css: Remove style transitions for the panel This, together with the panel's transparent background in the screen shield, has the unfortunate side-effect of showing the desktop background in a brief flash while coming out of the screen shield.
Review of attachment 234955 [details] [review]: Looks good.
Review of attachment 234956 [details] [review]: OK.
Review of attachment 235075 [details] [review]: Huh? So does the same value actually cause us to change the height?
Review of attachment 235076 [details] [review]: OK.
(In reply to comment #10) > Review of attachment 235075 [details] [review]: > > Huh? So does the same value actually cause us to change the height? It's the same for these styles but both are different from the main #panel style which is 1.86em. Thanks for the reviews, but I would also like to have an ack from a design perspective, particularly for the 1st patch.
*** Bug 693341 has been marked as a duplicate of this bug. ***
Review of attachment 235075 [details] [review]: OK.
Attachment 234956 [details] pushed as 3652002 - screenShield: Pop modes before starting unlock animation Attachment 235075 [details] pushed as d30477b - css: Keep the panel height the same in all modes Attachment 235076 [details] pushed as 496b5d6 - css: Remove style transitions for the panel
*** Bug 693344 has been marked as a duplicate of this bug. ***
The transition animation as designed is raising the shield, followed by zooming in the session underneath it over a black background: http://jimmac.fedorapeople.org/gnome3/unlock.webm I don't know if we have newer mockups or not.
(In reply to comment #4) > Created an attachment (id=234955) [details] [review] > screenShield: Fade instead of zooming out on unlock I ended up not pushing this since the whole background re-work was going on and I though this transition would be taken care of. But I've just realized we didn't do anything regarding this so can we push this? I think it looks a lot less jarring than the current zoom animation, especially on multiple monitors.
I just noticed the transition also only happens on login, not unlock. Should be the same thing.
Is this fixed?
The "password in shield" still "zooms out of the way" but the fix we really want, as Jakub points, is to have the same animation we have in on log in which is now filed as bug 699955. The other issues here were fixed so let's close it.
Review of attachment 234955 [details] [review]: Removing a-c-n flag