GNOME Bugzilla – Bug 692413
Move gdm-languages from gnome-control-center as gnome-languages
Last modified: 2013-01-25 14:53:04 UTC
See patches.
Created attachment 234237 [details] [review] post-release version bump
Created attachment 234238 [details] [review] gnome-languages: Extracted from gnome-control-center This used to be panels/common/gdm-languages.c in gnome-control-center but it's useful in several core desktop modules so let's move it here and s/gdm/gnome/.
Created attachment 234239 [details] [review] gnome-languages: Fix a memory leak
Created attachment 234240 [details] [review] gnome-xkb-info: Group layouts by country and language This will allow us to do better guesses at which layout should be the default for a given locale.
Created attachment 234241 [details] [review] gnome-xkb-info: Add a get_layout_info_for_locale method Now that we have layouts grouped properly by country and language we can implement an accurate get_layout_info_for_locale method instead of the hacky solution that we had before.
Created attachment 234389 [details] [review] gnome-xkb-info: Group layouts by country and language -- Fixed some bugs found with more extensive testing.
Created attachment 234390 [details] [review] gnome-xkb-info: Add a get_layout_info_for_locale method -- Fixed some bugs found with more extensive testing.
Review of attachment 234237 [details] [review]: ++
Review of attachment 234238 [details] [review]: Looks good.
Review of attachment 234239 [details] [review]: Backport to gnome-control-center's gnome-3-6 branch as well.
Review of attachment 234389 [details] [review]: Looks good.
Review of attachment 234390 [details] [review]: Looks good.
Thanks for reviewing. I also pushed the mem leak fix to the control center 3.6 branch. Attachment 234237 [details] pushed as 44f6650 - post-release version bump Attachment 234238 [details] pushed as cc16a0e - gnome-languages: Extracted from gnome-control-center Attachment 234239 [details] pushed as 09d15b8 - gnome-languages: Fix a memory leak Attachment 234389 [details] pushed as 5e86bb4 - gnome-xkb-info: Group layouts by country and language Attachment 234390 [details] pushed as 57b0643 - gnome-xkb-info: Add a get_layout_info_for_locale method