After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684229 - Workspace switcher disappears
Workspace switcher disappears
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 692036 694648 694775 694896 698566 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-17 15:59 UTC by Cosimo Cecchi
Modified: 2014-04-26 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ViewSelector: fix showing the workspace page when opening the overview (988 bytes, patch)
2012-12-13 17:09 UTC, Giovanni Campagna
needs-work Details | Review
ViewSelector: fix showing the workspace page when opening the overview (2.27 KB, patch)
2012-12-13 17:37 UTC, Giovanni Campagna
reviewed Details | Review
ViewSelector: fix showing the workspace page when opening the overview (2.34 KB, patch)
2012-12-13 18:12 UTC, Giovanni Campagna
needs-work Details | Review
ViewSelector: fix showing the workspace page when opening the overview (5.56 KB, patch)
2012-12-13 22:45 UTC, Giovanni Campagna
none Details | Review

Description Cosimo Cecchi 2012-09-17 15:59:53 UTC
After using the Shell for a while, it sometimes happens that the workspace switcher on the right completely disappears.
I can't find any useful information in ~/.cache/gdm/session.log, but my session is in that state right now, so I can pull information out of Looking Glass if necessary.
Comment 1 Giovanni Campagna 2012-10-03 21:46:07 UTC
Got the same problem here, it disappeared (while trying to debug it) by going to the app search and back.

Also, I saw the message tray disappear in the overview, although it was working fine outside it.
Comment 2 Andreas Trepczik 2012-12-13 09:34:29 UTC
I happens awfully often to me with gnome-shell 3.6.2.

I have found out that the workspace switcher will disappear if you type in the search box and quickly press Enter to launch the selected application before the shell is even able to display the application results. To reproduce simply open the Activies view, type 'A' and almost immediately hit Enter. Open Activies view again and notice the workspaces have gome.

The workspace switcher can be made show again by clicking the "Show Applications" button twice or by restarting the shell.
Comment 3 Giovanni Campagna 2012-12-13 17:09:29 UTC
Created attachment 231494 [details] [review]
ViewSelector: fix showing the workspace page when opening the overview

Setting activePage at the beginning of the function meant that that
later _showPage() was shortcutted and did nothing, thus not restoring
the opacity of the workspacePage, causing occasionally to get stuck
hidden.
Comment 4 Florian Müllner 2012-12-13 17:28:09 UTC
Review of attachment 231494 [details] [review]:

Nope - try '<super>a' outside the overview :-)
Comment 5 Florian Müllner 2012-12-13 17:30:43 UTC
Well, just using the all-apps button "works" as well.
Comment 6 Giovanni Campagna 2012-12-13 17:37:35 UTC
Created attachment 231497 [details] [review]
ViewSelector: fix showing the workspace page when opening the overview

Setting activePage at the beginning of the function meant that that
later _showPage() was shortcutted and did nothing, thus not restoring
the opacity of the workspacePage, causing occasionally to get stuck
hidden.
Also, fix the logic in showPage, which was backward and caused _activePage
to get stuck at null if never set from outside.
Comment 7 Florian Müllner 2012-12-13 17:45:55 UTC
Review of attachment 231497 [details] [review]:

::: js/ui/viewSelector.js
@@ +204,3 @@
                                transition: 'easeOutQuad',
+                               onComplete: function() {
+                                   this.hide();

This works, but "this" is rather confusing here - maybe add a (redundant) onCompleteScope: this._activePage? Or use Lang.bind(this._activePage, ...)?
Comment 8 Giovanni Campagna 2012-12-13 18:12:46 UTC
Created attachment 231498 [details] [review]
ViewSelector: fix showing the workspace page when opening the overview

Setting activePage at the beginning of the function meant that that
later _showPage() was shortcutted and did nothing, thus not restoring
the opacity of the workspacePage, causing occasionally to get stuck
hidden.
Also, fix the logic in showPage, which was backward and caused _activePage
to get stuck at null if never set from outside.
Comment 9 Florian Müllner 2012-12-13 19:05:15 UTC
Review of attachment 231498 [details] [review]:

LGTM
Comment 10 Florian Müllner 2012-12-13 19:06:46 UTC
Review of attachment 231498 [details] [review]:

Sorry, no - when first entering the overview by super-a, we still get it wrong.
Comment 11 Giovanni Campagna 2012-12-13 22:45:01 UTC
Created attachment 231523 [details] [review]
ViewSelector: fix showing the workspace page when opening the overview

Setting activePage at the beginning of the function meant that that
later _showPage() was shortcutted and did nothing, thus not restoring
the opacity of the workspacePage, causing occasionally to get stuck
hidden.
Also, fix the logic in showPage, which was backward and caused _activePage
to get stuck at null if never set from outside.

This one should work...
Comment 12 Giovanni Campagna 2013-01-18 22:00:23 UTC
*** Bug 692036 has been marked as a duplicate of this bug. ***
Comment 13 drago01 2013-02-25 10:29:49 UTC
*** Bug 694648 has been marked as a duplicate of this bug. ***
Comment 14 Giovanni Campagna 2013-02-25 13:49:47 UTC
The patch might be good for 3.6 (not tested), but it's obsolete in master, because the page handling and visibility code for overview controls was reworked significantly.
I'm not sure if this bug should be kept open.
Comment 15 drago01 2013-02-27 10:03:41 UTC
*** Bug 694775 has been marked as a duplicate of this bug. ***
Comment 16 drago01 2013-02-27 10:04:36 UTC
(In reply to comment #14)
> The patch might be good for 3.6 (not tested), but it's obsolete in master,
> because the page handling and visibility code for overview controls was
> reworked significantly.
> I'm not sure if this bug should be kept open.

Apparently enough people are hitting it so it is worth to fix for 3.6.x ...
Comment 17 Florian Müllner 2013-02-28 19:49:41 UTC
*** Bug 694896 has been marked as a duplicate of this bug. ***
Comment 18 Kamil Páral 2013-03-13 13:30:18 UTC
Hello, I see this once or more times a week, regularly for the last several+ months (it feels like years). rtcm pointed me to this bug and I reproduced it exactly using comment 2, even the workaround fix.

If there is a 3.6 patch release coming, this would be great to incorporate. Thanks.
Comment 19 Fabian Deutsch 2013-03-15 20:48:14 UTC
Hey,

I'm running F18 with gnome-shell-3.6.3.1-1.fc18.x86_64

And I could also reproduce it as described in comment 2.
Comment 20 Florian Müllner 2013-03-15 21:03:25 UTC
(In reply to comment #19)
> And I could also reproduce it as described in comment 2.

That's why the bug is still open :-)

This issue is on the list of fixes to include in another 3.6.x release, but at this point I'll need to set up a VM environment to do any testing, which isn't something I'll spend time on before 3.8.0 (or even 3.8.1).
Comment 21 Fabian Deutsch 2013-03-15 21:52:07 UTC
(In reply to comment #20)
> (In reply to comment #19)
> > And I could also reproduce it as described in comment 2.
> 
> That's why the bug is still open :-)
> 
> This issue is on the list of fixes to include in another 3.6.x release, but at
> this point I'll need to set up a VM environment to do any testing, which isn't
> something I'll spend time on before 3.8.0 (or even 3.8.1).

:) Yes, my comment might just be a bit redundant. And I see that it doesn't apply for master. So I might just switch to 3.8 ... When it's available for F18... Thanks
Comment 22 Florian Müllner 2013-03-15 21:56:22 UTC
(In reply to comment #21)
> So I might just switch to 3.8 ... When it's available for F18...

3.8 won't be available in F18. As mentioned before though, the plan is to include this in a 3.6.4 release (and submit it as an update to F18) some time after 3.8.0 is released.
Comment 23 drago01 2013-04-22 21:22:30 UTC
*** Bug 698566 has been marked as a duplicate of this bug. ***
Comment 24 Jasper St. Pierre (not reading bugmail) 2013-06-13 00:15:23 UTC
*** Bug 696660 has been marked as a duplicate of this bug. ***
Comment 25 Florian Müllner 2014-04-26 14:19:55 UTC
3.6 is old and code has diverged a lot, so closing.