After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682529 - Application search - do not use generic names or comments
Application search - do not use generic names or comments
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 650866 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-23 11:51 UTC by Allan Day
Modified: 2012-11-30 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-app: Don't match on comments (2.27 KB, patch)
2012-08-23 12:21 UTC, Florian Müllner 		committed Details | Review

Description Allan Day 2012-08-23 11:51:43 UTC 
Searching for "the" shouldn't give me a list of applications. We should use the keywords from applications' desktop files for search, not comments.
Comment 1 Allan Day 2012-08-23 11:52:03 UTC 
We shouldn't use the generic name either. See:

https://live.gnome.org/GnomeShell/Design/Whiteboards/Search#Search_Matching_and_Ordering
Comment 2 Allan Day 2012-08-23 11:52:39 UTC 
*** Bug 650866 has been marked as a duplicate of this bug. ***
Comment 3 Florian Müllner 2012-08-23 12:14:30 UTC 
(In reply to comment #0)
> We should use the keywords from applications' desktop files for search

We have been doing that for a while actually (there are just not too many applications that have keywords in their .desktop file)
Comment 4 Florian Müllner 2012-08-23 12:21:14 UTC 
Created attachment 222214 [details] [review]
shell-app: Don't match on comments

Comments are meant to be displayed, not to be searched - we should
rather advertise the use of Keywords, which yields much better results.

(looks like we never matched on GenericName)
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-08-23 15:50:27 UTC 
Review of attachment 222214 [details] [review]:

Sure.
Comment 6 Florian Müllner 2012-08-23 16:04:56 UTC 
Attachment 222214 [details] pushed as d60a4e9 - shell-app: Don't match on comments
Comment 7 Jeremy Bicha 2012-11-14 23:46:22 UTC 
Just for anyone following along, GNOME Shell 3.6.2 now uses GenericName for searching (Bug 687121).
Comment 8 Allan Day 2012-11-30 14:39:19 UTC 
*** Bug 689345 has been marked as a duplicate of this bug. ***
Comment 9 Allan Day 2012-11-30 14:41:39 UTC 
(In reply to comment #7)
> Just for anyone following along, GNOME Shell 3.6.2 now uses GenericName for
> searching (Bug 687121).

Indeed. I only just noticed this because of bug 689345. Reopening.
Comment 10 Allan Day 2012-11-30 15:37:48 UTC 
Actually, looking at this again, searching for GenericName should be OK. 

Bug 689345 seems to be a case of GenericName misuse rather than the search criteria being wrong. And the issue I originally reported for this bug seems to be fixed in 3.6.