After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678512 - Migrate to Python 3
Migrate to Python 3
Status: RESOLVED FIXED
Product: accerciser
Classification: Applications
Component: core
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
Accerciser Developers
Depends on:
Blocks: python3
 
 
Reported: 2012-06-21 00:07 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-11-27 16:01 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
Use relative imports (python 2.7 compatible) (8.68 KB, patch)
2012-06-21 03:57 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
Use range instead of xrange (python 2.7 compatible) (6.19 KB, patch)
2012-06-21 03:57 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
Misc function changes (python 2.7 compatible) (3.37 KB, patch)
2012-06-21 03:58 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
Exception changes (python 2.7 compatible) (4.77 KB, patch)
2012-06-21 03:59 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
Whitespace and comma cleanup (python 2.7 compatible) (11.57 KB, patch)
2012-06-21 04:00 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
Use print() function instead of print statement (python 2.7 compatible) (2.53 KB, patch)
2012-06-21 04:13 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
List-related changes (python 2.7 compatible) (9.91 KB, patch)
2012-06-21 04:30 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
The python-3-unique changes (NOT python 2.7 compatible) (7.17 KB, patch)
2012-06-21 09:17 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
All the changes for Macaroon (9.83 KB, patch)
2012-06-21 13:37 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review

Description Joanmarie Diggs (IRC: joanie) 2012-06-21 00:07:03 UTC
As discussed a few team meetings ago, we have a GNOME A11y Goal: Complete the Python 3 migration in time for the 3.6 release.
Comment 1 Joanmarie Diggs (IRC: joanie) 2012-06-21 03:57:10 UTC
Created attachment 216890 [details] [review]
Use relative imports (python 2.7 compatible)
Comment 2 Joanmarie Diggs (IRC: joanie) 2012-06-21 03:57:55 UTC
Created attachment 216891 [details] [review]
Use range instead of xrange (python 2.7 compatible)
Comment 3 Joanmarie Diggs (IRC: joanie) 2012-06-21 03:58:42 UTC
Created attachment 216892 [details] [review]
Misc function changes (python 2.7 compatible)
Comment 4 Joanmarie Diggs (IRC: joanie) 2012-06-21 03:59:39 UTC
Created attachment 216893 [details] [review]
Exception changes (python 2.7 compatible)
Comment 5 Joanmarie Diggs (IRC: joanie) 2012-06-21 04:00:44 UTC
Created attachment 216894 [details] [review]
Whitespace and comma cleanup (python 2.7 compatible)
Comment 6 Joanmarie Diggs (IRC: joanie) 2012-06-21 04:13:12 UTC
Created attachment 216895 [details] [review]
Use print() function instead of print statement (python 2.7 compatible)
Comment 7 Joanmarie Diggs (IRC: joanie) 2012-06-21 04:30:29 UTC
Created attachment 216896 [details] [review]
List-related changes (python 2.7 compatible)
Comment 8 Joanmarie Diggs (IRC: joanie) 2012-06-21 09:17:11 UTC
Created attachment 216903 [details] [review]
The python-3-unique changes (NOT python 2.7 compatible)

Javi, with this last commit along with an ipython for python 3, Accerciser is working for my in Python 3.

I'll look at the macaroon conversion after I sort out bug 678517. But in the meantime, please review all of the attached. Thanks!
Comment 9 Joanmarie Diggs (IRC: joanie) 2012-06-21 13:37:23 UTC
Created attachment 216916 [details] [review]
All the changes for Macaroon

This particular patch assumes the patch from bug 678517.

Aside from review and subsequent changes, I *believe* I am now done with the Python 3 migration of Accerciser. :)
Comment 10 Javier Jardón (IRC: jjardon) 2012-11-12 17:30:34 UTC
Hi,

It would be nice to integrate this if possible
Comment 11 Javier Hernández 2012-12-09 03:26:36 UTC
Hi!

I finally got time to apply those patches. Some slightly modifications were needed but it works very well.

I squashed all commits into another one and I've just pushed it to master [1].
I also updated the 3.8 moduleset section for accerciser [2].

Althought it seems to work without problems, some testing will be appreciated.

Thanks a lot for your work here Joanie, you rock (as always)!

Cheers!

[1]: http://git.gnome.org/browse/accerciser/commit/?id=b9bb2f48eebbf9f21ca633b6ecd6a58d6befe04a
[2]: http://git.gnome.org/browse/jhbuild/commit/?id=249fb3b537555e10db468492c0b067290ba53803
Comment 12 Joanmarie Diggs (IRC: joanie) 2013-11-27 16:01:46 UTC
(In(In reply to comment #11)
> Hi!
> 
> I finally got time to apply those patches. Some slightly modifications were
> needed but it works very well.

It appears that nearly all of the Macaroon changes (see comment 9) were not included in this commit. As a result, Macaroon doesn't work at all in Python 3. I have just opened bug 719433 for that.