After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719433 - Macaroon is still not Python 3 compatible
Macaroon is still not Python 3 compatible
Status: RESOLVED FIXED
Product: accerciser
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Accerciser Developers
Accerciser Developers
Depends on:
Blocks: python3
 
 
Reported: 2013-11-27 15:59 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2014-03-06 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
master-compatible patch to make Macaroon work in Python 3 (8.55 KB, patch)
2013-11-27 15:59 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2013-11-27 15:59:45 UTC 
Created attachment 262958 [details] [review]
master-compatible patch to make Macaroon work in Python 3

In bug 678512 comment 9, you'll find:
> Created an attachment (id=216916) [details] [review]
> All the changes for Macaroon

In bug 678512 comment 11, you'll find:
> I squashed all commits into another one and I've just pushed it to master [1].

[...]
 
> [1]:
> http://git.gnome.org/browse/accerciser/commit/?id=b9bb2f48eebbf9f21ca633b6ecd6a58d6befe04a

But if you look at [1], you'll see that only three lines were changed in one Macaroon file. If you compare that to the original patch, you'll note that much is missing. Without those missing changes, Macaroon fails to work in Python 3.
Comment 1 Javier Hernández 2014-03-06 14:48:48 UTC 
Review of attachment 262958 [details] [review]:

Hi Joanie,

that's true, maybe it was me that I missed to include the full patches.
Anyhoo, just pushed it to master. [1]

Thanks for taking care of it.

[1]: https://git.gnome.org/browse/accerciser/commit/?id=bf0865bcdf383a5b14d6d4df78debe1851a0b69b