After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678517 - Macaroon script recorder is broken
Macaroon script recorder is broken
Status: RESOLVED FIXED
Product: accerciser
Classification: Applications
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
Accerciser Developers
Depends on:
Blocks:
 
 
Reported: 2012-06-21 04:04 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2012-06-25 23:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix - part 1 (5.36 KB, patch)
2012-06-21 12:12 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review
Significantly smaller keyboard event mask (1.78 KB, patch)
2012-06-21 12:28 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review
Sanity check to prevent tripping over runtime errors when getting the path (1.20 KB, patch)
2012-06-21 19:06 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2012-06-21 04:04:49 UTC 
While working on Accerciser's python 3 migration I discovered that the Macaroon script recorder no longer works. Note that I do not believe this to be a recent breakage. My use of macaroon w.r.t. Orca does not include using the script recorder.
Comment 1 Joanmarie Diggs (IRC: joanie) 2012-06-21 12:12:20 UTC 
Created attachment 216911 [details] [review]
proposed fix - part 1

This gets it working again. (There are other issues.)
Comment 2 Joanmarie Diggs (IRC: joanie) 2012-06-21 12:28:29 UTC 
Created attachment 216912 [details] [review]
Significantly smaller keyboard event mask

There is a crazy delay which results from registering the keystroke listeners. I have no idea why the mask was set to over 16,000. This patch does what we do in Orca and seems to work just fine.
Comment 3 Joanmarie Diggs (IRC: joanie) 2012-06-21 19:06:30 UTC 
Created attachment 216954 [details] [review]
Sanity check to prevent tripping over runtime errors when getting the path
Comment 4 Javier Hernández 2012-06-25 23:04:58 UTC 
Review of attachment 216911 [details] [review]:

commited: f19e98af43069dc5943e2e9ff1d17f6bc6b3b7db
Comment 5 Javier Hernández 2012-06-25 23:05:39 UTC 
Review of attachment 216912 [details] [review]:

commited: 711bc814f9a66c2f8edb4419a339c1014d14d7c4
Comment 6 Javier Hernández 2012-06-25 23:07:20 UTC 
Review of attachment 216954 [details] [review]:

commited: c750733ace9bfcd49f4e9e9ad65c22e287078a65
Comment 7 Javier Hernández 2012-06-25 23:09:06 UTC 
Good stuff!!

Thanks a lot Joanie!

Cheers!