GNOME Bugzilla – Bug 668135
location bar integration with reload/stop depends on font size
Last modified: 2012-04-24 12:51:16 UTC
Created attachment 205482 [details] bug with font size. See screenshot. I use Droid Sans as my font, and at 10 points it's a few pixels smaller than Cantarell. The result is that the stop/reload button doesn't match the location bar. The location bar should depend on the button, I believe.
Created attachment 207439 [details] a slight improvement over last time, with last week's jhbuild
*** Bug 671812 has been marked as a duplicate of this bug. ***
Created attachment 210685 [details] [review] ephy-toolbar: fix stop/reload button alignment When using some less taller fonts like Droid Sans (compared to Cantarell), the stop/reload button breaks its aligment with the location entry. Sync the button minimum height with the entry requested height.
Created attachment 210686 [details] Caveat of the proposed fix. The extra pixel that my particular case adds to the entry causes this uglyness. It's noticeable when entering text.
Further testing reveals that our location entry adds any new pixels to its bottom padding, even if instead of 1 new pixel it is 2 new pixels (supposedly so it adds 1 on top and 1 on bottom). Any clue?
(In reply to comment #5) > Further testing reveals that our location entry adds any new pixels to its > bottom padding, even if instead of 1 new pixel it is 2 new pixels (supposedly > so it adds 1 on top and 1 on bottom). > For the record: I am blaming GTK+ here. Not our own code. I can not see how we would have broke /that/.
Created attachment 210755 [details] [review] ephy-toolbar: fix stop/reload button alignment Add back/forward buttons, location entry, stop/reload button, and the page menu button to a vertical GtkSizeGroup. This ensures that all the toolbar elements will have the same height, regardless of things like fonts.
Created attachment 210756 [details] Patch applied, using 3 different fonts. Further testing and a million screenshots reveal that we can't do much with that extra pixel. The padding before adjusting the size is 2px, top and bottom. When the extra pixel comes in, it has to go somewhere and it goes bottom, so it is 2px top, 3px bottom. I don't think it is that bad as when I first saw it. We could have code to ensure that the entry receives an even number of extra pixels so the padding is equal, but I don't think it is worth it. Plus, this likely depends on the theme being used. GtkSizeGroup is a good solution, IMHO. Attached tests with: Cantarell 11, Cantarell 10, Droid Sans 10.
Attachment 210755 [details] pushed as 71a003c - ephy-toolbar: fix stop/reload button alignment
*** Bug 674712 has been marked as a duplicate of this bug. ***