GNOME Bugzilla – Bug 672927
"awesomebar" entries need some better whitespace
Last modified: 2012-05-16 15:32:19 UTC
Created attachment 210705 [details] improved paddings It's a bit crammed right now. Attached a mockup which addresses the paddings between icons and edges and icons and text.
I agree we need more whitespace around the icons.
Depends on bug #668135 for the location GtkEntry aligment.
Created attachment 210737 [details] [review] e-location-entry: adjust padding for completion
Created attachment 210738 [details] [review] e-location-entry: make bookmark icon follow-state
Created attachment 210739 [details] [review] e-location-entry: redundant ellipsize-set
Created attachment 210740 [details] WIP. With the proposed patches applied.
Looks good to go to me. Thanks for fixing so quickly! :)
Review of attachment 210738 [details] [review]: Please explain what's the visible outcome of this in the commit message.
Review of attachment 210739 [details] [review]: OK.
Review of attachment 210737 [details] [review]: I don't want to be an ass, but based on the screenshot you posted, shouldn't the completion text align with the text in the entry? I think there's too much padding now.
Created attachment 210742 [details] [review] e-location-entry: dim URL in completion rows
Created attachment 210749 [details] [review] e-location-entry: make bookmark icon follow-state Makes the symbolic-icon of the completion rows change its color accordingly to the selection state. With Adwaita: black -> white.
Created attachment 210750 [details] [review] e-location-entry: redundant ellipsize-set
Created attachment 210751 [details] [review] e-location-entry: dim URL in completion rows
Created attachment 210752 [details] [review] e-location-entry: make aligment pixel-perfect Align the elements of the GtkEntryCompletion popup with those in the location entry. The code comes with a detailed comment and a scheme of how the aligment is done now. Because of the unhandled pixels of GtkEntryCompletion, this code might need an update if anything in GTK+ or Adwaita changes.
Updated patches. Also adding depend on Cosimo's fixes for the completion popup in bug #672947.
Created attachment 210753 [details] All patches applied Apparently my new goal in life is making Hylke happy. Here's the screenshot of the completion with the patches applied. When Cosimo's patches for the completion in bug #672947 are applied, the bookmark icon will align perfectly with the lock icon. And if we ever fix bug #668135, the entry will align perfectly with the stop button. I think this is already perfect-enough. Testing on other fonts, and resolutions, and stuff, is welcome. Reviewing is also welcome :)
Review of attachment 210750 [details] [review]: I think I already reviewed this?
Review of attachment 210749 [details] [review]: OK.
Review of attachment 210751 [details] [review]: OK.
Review of attachment 210752 [details] [review]: OK. ::: lib/widgets/ephy-location-entry.c @@ +1059,3 @@ + */ + gtk_cell_renderer_set_padding (cell, 5, 2); + gtk_cell_renderer_set_fixed_size (cell, 23, 4); Is it possible to get the numbers as a+b+c so that it is crystal clear what are we doing here? The comment is awesome, but that would make the code easier to read too.
Created attachment 210994 [details] [review] e-location-entry: make aligment pixel-perfect Align the elements of the GtkEntryCompletion popup with those in the location entry. The code comes with a detailed comment and a scheme of how the aligment is done now. Because of the unhandled pixels of GtkEntryCompletion, this code might need an update if anything in GTK+ or Adwaita changes.
Review of attachment 210994 [details] [review]: Great, much better.
Attachment 210749 [details] pushed as dda0c52 - e-location-entry: make bookmark icon follow-state Attachment 210750 [details] pushed as 638b468 - e-location-entry: redundant ellipsize-set Attachment 210751 [details] pushed as 0b9943b - e-location-entry: dim URL in completion rows Attachment 210994 [details] pushed as 5f99eda - e-location-entry: make aligment pixel-perfect
*** Bug 669920 has been marked as a duplicate of this bug. ***