After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640570 - Lyrics plugin: asks to upgrade plugin
Lyrics plugin: asks to upgrade plugin
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: Community Extensions
1.9.1
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
gnome[unmaintained]
: 641669 645100 650195 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-01-25 20:11 UTC by zozo
Modified: 2020-03-17 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description zozo 2011-01-25 20:11:38 UTC
When searching for new lyrics (Banshee 1.9.2), I get the following message
QUOTE
Upgrade to Lyrics Plugin version 0.4
Powered by LyricsPlugin (http://www.lyricsplugin.com)
UNQUOTE
instead of the lyrics.
This is problematic since the available plugins on this website are for WMP, Winamp or iTunes only.
Comment 1 Alexander Kojevnikov 2011-01-30 13:50:43 UTC
Looks like they have changed the access protocol. Confirming and CCing the maintainer.
Comment 2 Bertrand Lorentz 2011-02-03 19:41:10 UTC
I just disabled the lyricsplugin.com source for now.

I think we might have to remove it, as the web page with the "Upgrade to Lyrics Plugin version 0.4" message has the following in the HTML source :

PLEASE DO NOT USE THIS SERVICE AS A SOURCE FOR THIRD PARTY APPLICATIONS, PLUGINS, WEBSITES, ETC.
Comment 3 Michael Martin-Smucker 2011-02-06 18:05:10 UTC
*** Bug 641669 has been marked as a duplicate of this bug. ***
Comment 4 damianatorrpm@gmail.com 2011-02-06 18:14:35 UTC
This is not only now a problem I discovered that lyricsplugin.com made some problems before also(august 2010): http://ubuntuforums.org/showthread.php?p=10433691
Comment 5 Johannes Mockenhaupt 2011-02-20 12:23:53 UTC
With the update to 1.9.3 the lyrics extensions works properly for me, so thanks for that.
However, the text "Upgrade to Lyrics Plugin version 0.4" is still cached and is now displayed as valid lyrics and therefore no attempt is made to fetch them again. The remove bogus cached lyrics go to ~/.cache/banshee-1/extensions/lyrics and run this command:

find | while read file; do grep "Upgrade to Lyrics Plugin version 0.4" "$file" >/dev/null && rm "$file"; done

I hope this saves other people the time I spend on this.
Comment 6 Johannes Mockenhaupt 2011-02-20 17:23:36 UTC
Well, that's not really the end of it, since banshee writes lyrics to ID3 tags, I wound up with mp3s having a bogus lyrics tag. While deleting the cached lyrics files will make banshee fetch the lyrics again, the saveToID3 method in LyricsManager will correctly abort writing the lyrics tag when one is already present. So I used the eyeD3 CLI to check for bogus lyrics tags and remove them, afterwards I had banshee go over the library again to fetch missing lyrics.

If an automatic cleanup, done programatically is something someone wants to pursue, then from what I've figured the following needs to be done:
1) LyricsCache.IsInCache would either have to check not only if a file exists but also if the content is not the 'please update' response. Or this could be done on startup, possibly similiar to DB schema upgrades
2)LyricsManager.saveToID3 is called whenever new lyrics are. so when adding a check for the bogus lyrics in the tag and if found, overwriting it. This would clean up the library 'one file at a time'.
However, it's cleaner to fully clean the library in batch mode via eyeD3 I guess.
I have no idea though, how many people are affected by this and if an solution is really required here.
Comment 7 Michael Martin-Smucker 2011-03-18 13:35:35 UTC
*** Bug 645100 has been marked as a duplicate of this bug. ***
Comment 8 Michael Martin-Smucker 2011-06-04 03:00:39 UTC
*** Bug 650195 has been marked as a duplicate of this bug. ***
Comment 9 André Klapper 2020-03-17 08:54:00 UTC
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.
See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.