GNOME Bugzilla – Bug 556932
Finish time is wrong
Last modified: 2013-08-15 23:45:46 UTC
Please describe the problem: I just finished a game within 49 seconds (45 seconds active) - but actually I was playing about >1h. So I guess the game just "forgot" one hour or hours are no longer displayed (strftime or whatever). Steps to reproduce: Maybe by playing over one hour. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 120858 [details] Wrong time in Sudoku game.
Could this be a duplicate of bug #556155 ? Was this a loaded game?
I just finished a game that started before midnight and ended after midnight. The time spent on the game was reported as one day and five hours and a bit. Possibly related to: http://bugzilla.gnome.org/show_bug.cgi?id=534019 http://bugzilla.gnome.org/show_bug.cgi?id=551861 Thanks for a great game! - Sy
I'd like to report for the lol factor that about 4 days ago, I completed a puzzle that told me that I "completed the puzzle in 77 years, 5 months, 1 day, 23 hours, 20 minutes and 42 seconds (1 hour, 54 minutes and 56 seconds active)". So, yes, I can confirm that this is a bug.
Hi Anthony what version do you use?
Hi, Thomas. I _was_ using the latest gnome-games package available for Ubuntu 8.10 as of the time of writing. According to http://packages.ubuntu.com/intrepid-updates/gnome-games, that would be 2.24.1.1 (-0ubuntu1). Since reporting, I have switched to Archlinux/KDE on a trial basis, and don't have an existing installation of Ubuntu/Gnome to test against.
Greetings Thomas and Anthony: I have an existing installation of Ubuntu/Gnome, and have version 2.24.1.1 of GNOME Sudoku installed. I've been using GNU/Linux for quite some time now; but I'm still merely a lUser. However, if there is anything I can do to assist I would be happy to help. - Sy
I can confirm the bug on ubuntu 8.10 with version 2.24.1.1. "You completed the puzzle in 16 hours, 35 minutes and 36 seconds (19 minutes 4 seconds active) You got 0 hints" I had the game open for some 4 or 5 hours maybe! But not 16h! Maybe its because of the AM / PM? But that would be strange. I started the game around 12:00 (AM) and finished it around 14:00 (2 PM). cheers felix
that's still an issue in 2.26
Created attachment 136917 [details] [review] Don't stop the timer during autosave I've poked around a bit and made a patch which I believe fixes the issue. The git code as of today was stopping the timer 50 seconds into the game (for autosave), which would explain the initial report. As for the several duplicated bugs which say that the total time taken is way too long, I couldn't reproduce this on the git version, nor with my patched version. I can look into it a bit deeper to find out the original cause (as I can reproduce it on the version in my distro), but I won't unless someone asks me to. I renamed "__absolute_start_time__" to "start_time" (mainly to comply with PEP8). I also don't store "total_time" anymore, I couldn't quite see the purpose of saving it. If I'm missing something, then let me know. (We store the time we started (as seconds past the epoch) and the number of active seconds - from this, we can always resume sensibly). I'm fairly sure this will also close #562782 and #563319.
I can confirm the 'too long' error on a newly built up-to-date ubuntu904. This was my very first game of Sudoku on this new build machine. I started and finished the game well within one hour, but got the message "You completed the puzzle in 11 hours, 4 minutes and 35 seconds (38 minutes 53 seconds active) You got 0 hints" I filed a problem through the Help menu - hope it helps... PS thanks for fixing the 'fails to know the game is finished' bug - I cleared some tracks on this game without getting the old problem. Hope this new (to me) one isn't related to that fix!
The automatically collected version details etc are with Ubuntu launchpad Bug #405025
Has this been fixed? I was just playing around with 2.28.0, and I couldn't reproduce it.
Created attachment 147187 [details] .tgz of screenshots Note the clock times of start and finish.
Sorry - it's still there. See attached screenshots. This may be a more serious fault than at first meets the eye, because on two occasions now I have generated a Yelp crash when investigating bugs. Last time I was suffering a personal stack overload and could not push the Yelp problem, so I don't know whether it was this bug. I might be able to dig out the date of the last Yelp crash and correlate it with by bug reporting if it matters to you. And this may be a silly suggestion, but how difficult would it be to program a running display of elapsed and active times? Then we would know when it happens, and potentially what triggers it.
Oops - sorry for the noise. The previous Yelp crash was not on this bug. Chris
Sigh... I'm having a really bad day here. Whilst it was not on this bug, it was on Ubuntu Launchpad bug 282315. I seem to be subscribed to the same problem on both threads.
No - it was Launchpad 469116. Yes, it really was, this time... And to complete the cross referencing (I think!) I have added the Yelp issue to Launchpad Bug 451164. The crash dump is too big to upload to the Gnome Bugzilla. Chris
Oh dear - The crash dump is in Launchpad bugnumber 451164 at: https://bugs.launchpad.net/ubuntu/+source/yelp/+bug/451164 to avoid the misleading formatting.
Ok, well if it is still an issue, then I've written a patch for it which does fix it... hopefully it still applies cleanly to the tree. The problem was to do with how it accounted for time when the main window didn't have focus.
Review of attachment 136917 [details] [review]: I had just diagnosed the problem and written a very similar patch when I found this one. This one's a little cleaner than mine, so I recommend it.
Is this still a problem in a recent version such as 3.4 or 3.2, or can this be closed as OBSOLETE?
Marking this OBSOLETE since it's been three years since the last comment. Sorry the patch wasn't reviewed in that time. If it's still a problem, please do say so and we can reopen this.