After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 374661 - "Location" column would be helpful for search results
"Location" column would be helpful for search results
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Search Interface
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 452203 607303 685269 700497 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-11-13 12:54 UTC by Cees Timmerman
Modified: 2013-07-11 14:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adds location column to search view by default (1.73 KB, patch)
2011-02-09 17:54 UTC, Stefano Teso
none Details | Review
Bug 374661 - Show Location column by default for search results (3.10 KB, patch)
2013-06-21 02:12 UTC, Garrett Regier
reviewed Details | Review
Bug 374661 - Show Location column by default for search results v2 (2.82 KB, patch)
2013-06-21 15:36 UTC, Garrett Regier
committed Details | Review

Description Cees Timmerman 2006-11-13 12:54:02 UTC
I got 8 results with the same name. A column with the file locations would save a lot of time. Could gnome-search-tool be integrated in the side panel?
Comment 1 Jonh Wendell 2006-11-24 13:52:52 UTC
This bug was reported in Ubuntu too:
http://launchpad.net/bugs/70229
Comment 2 Nicola 2008-08-28 08:36:55 UTC
Here I have the same problem. I think that is very annoying.
Nicola
Comment 3 Nicola 2008-08-28 09:04:58 UTC
Here I have the same problem. I think that is very annoying.
The problem is that we don't have in the column editor 
the file path as column.

I have found the other columns declarations in 
the source in

src/nautilus-file-management-properties.glade
in row from 1454 to 1543

I think that the file affected must be also

src/nautilus-file-management-properties.c
src/nautilus-file-management-properties.h

to add a column type "file path"

and then the user can add this column type to view the path of
searched files.

ah and in search mode this column must be always visible but not in
"normal" mode (I don't know of nautilus save the column settings
for normal and search mode..)

But I don't know the nautilus source and I think that I can make mistakes...
any nautilus developer here?????

Best Regards
Nicola Lunghi
Comment 4 Paolo Benvenuto 2008-11-24 08:29:56 UTC
Is there a plan to fix this bug? thank you!
Comment 5 Charles 2009-04-06 04:06:27 UTC
I too would like this bug resolved.  I often search for a file and get 10 - 15 results . . . all with the same file name.  Location is very important. 

A full uri would be a very valuable column.
Comment 6 Allison Karlitskaya (desrt) 2009-04-06 04:10:44 UTC
This bug is a little bit problematic because probably even if users want the full uri to be displayed in search results they won't want the same thing for normal list view of a folder.

This means that we either need to have a separate set of columns visible for search results (vs normal folder viewing) or maybe have a simple special-case check box for "Add full location column to search results".  This is truly a special case because search results have the rather unique property of being the only place in Nautilus where files from separate directories are shown together in one window [of course, ignoring the original paths of the files for burn:/ and trash:/ backends].

Comment 7 Allison Karlitskaya (desrt) 2009-04-06 04:18:38 UTC
Some more ideas: it might help a little bit to make the full location of the file visible in a tooltip when you hover over an item in the search results.

Also, because the full uri to the file is likely to be long, it might make sense to show it smaller, indented, italicised and underneath all of the normal columns.

  Name                   | Date       | Size

  my file                  2009-03-02   4322
    file://home/desrt/Desktop/folder/my file

  other file               2009-04-01   2222
    file://home/desrt/other/place/other file

that sort of thing.
Comment 8 Allison Karlitskaya (desrt) 2009-04-06 04:19:39 UTC
Worth considering, though, that either of the ideas in comment #7 prevent sorting the list by location which might be desired.
Comment 9 A. Walton 2009-04-06 04:26:25 UTC
From the ongoing IRC discussion:

<awalton__> wonder if it would make sense just to add a "full path" column and enable it by default when searching?
<desrt> also enable listview as the default view for searches
<awalton__> definitely that too.
<desrt> i'm not adding any more comments to the bug
<awalton__> searching by icon view is pointless...
<desrt> people are gonna be pissed enough at me already
<desrt> you can add those ones :)
<desrt> and avoid saying "desrt told me to" :p
Comment 10 Alexander Larsson 2009-04-06 07:43:00 UTC
Well, step one is to just add the (optional) column. The attribute is already availible via nautilus_file_get_string_attribute() as "where", so it should be trivial.

The second step is being able to have different column lists per window, maybe even doing some of that automatically. Not sure what is best here, but even just having it availible is a step up.

For the tooltip expansion of a listview column, that is an often requested generic treeview feature. I don't know what the status is of that, but i belive with the new(ish) tooltips architecture this should be possible.
Comment 11 Charles 2009-04-06 14:45:07 UTC
As a user, I can tell you that I don't mind having the column available everywhere and just turning it on and off when needed -- if that simplifies the situation.  Also, sorting by this column is very important as indicated above.
Comment 12 Alexander Larsson 2009-04-08 13:10:08 UTC
I added one, since it was trivial:

2009-04-08  Alexander Larsson  <alexl@redhat.com>

	* libnautilus-private/nautilus-column-utilities.c:
	(get_builtin_columns):
	Add column for location. (#374661)

Note, the description is kinda lame since we're in a string freeze. Keeping the bug open so we don't forget to change that.
Comment 13 Sebastien Bacher 2009-06-23 10:43:14 UTC
*** Bug 452203 has been marked as a duplicate of this bug. ***
Comment 14 Stefano Teso 2011-02-09 17:54:47 UTC
Created attachment 180497 [details] [review]
adds location column to search view by default

Hi,

perhaps the attached patch does the trick? It builds on the work done to allow default custom columns for the trash. The NAUTILUS_IS_SEARCH_DIRECTORY (directory) trick is done all over the place, so I consider it legal. Maybe a new nautilus_directory_is_search_directory () function would be cleaner.

Please review.
Comment 15 Stefano Teso 2011-02-09 17:57:25 UTC
Forgot to say that the patch only fixes the list view. The icon and compact views are unaffected.
Comment 16 William Jon McCann 2012-07-20 12:40:33 UTC
*** Bug 607303 has been marked as a duplicate of this bug. ***
Comment 17 Cosimo Cecchi 2012-10-02 13:38:58 UTC
*** Bug 685269 has been marked as a duplicate of this bug. ***
Comment 18 Adam Dingle 2013-03-30 13:59:19 UTC
Stefano's patch still applies to the current git master and is functional.  The only issue I can see is that with the extra location column in the search results, columns seem to jump around oddly when I resize them and when I move the window.

I'd love to see this cleaned up and committed for Nautilus 3.10.
Comment 19 Osmo Salomaa 2013-04-28 19:43:37 UTC
(In reply to comment #9)
> <awalton__> searching by icon view is pointless...

(In reply to comment #15)
> Forgot to say that the patch only fixes the list view. The icon and compact
> views are unaffected.

Now that since 3.6 search is a form of keyboard navigation (instead of the previous typeahead-find), it would be strange if during navigation one would flip back and forth between icon and list views.

Would it be possible to display paths relative to the search directory in icon view search results instead of basenames? Perhaps ellipsized in the middle if it gets long?
Comment 20 Adam Dingle 2013-04-28 21:39:14 UTC
I think the simplest solution here is that path information should only be directly visible in list view (i.e. via the Location column), since displaying paths in icon view will probably look poor, especially when filenames or other directory components are long.  Of course, if you search in icon view and you want to know where a result is, you can always right click an icon and view its properties.

By the way, the columns jumping around that I observed in comment 18 above are a more general problem in Nautilus; see bug 698970.
Comment 21 António Fernandes 2013-05-17 09:08:34 UTC
*** Bug 700497 has been marked as a duplicate of this bug. ***
Comment 22 Garrett Regier 2013-06-21 02:12:04 UTC
Created attachment 247398 [details] [review]
Bug 374661 - Show Location column by default for search results

This patch is dependent on the patch for Bug 698190.
Comment 23 Cosimo Cecchi 2013-06-21 07:01:50 UTC
Review of attachment 247398 [details] [review]:

This looks good in general, but it will probably need to be adapted to some changes after bug 698190 is fixed.
Comment 24 Garrett Regier 2013-06-21 15:36:11 UTC
Created attachment 247460 [details] [review]
Bug 374661 - Show Location column by default for search results v2

Updated to reflect the changes in Bug 698190.
Comment 25 Cosimo Cecchi 2013-06-21 15:54:54 UTC
Review of attachment 247460 [details] [review]:

Looks good to me, thanks!
Comment 26 Garrett Regier 2013-06-21 15:58:41 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 27 alex diavatis 2013-07-11 00:38:04 UTC
I think this patch doesn't really solves the problem. I had this patch since the day you commit it, but I discovered the Location Bar in List view only after I read this bug report. 

I never use the list view (how many do?) and I don't think that extra click in List every time you do a search (and revert back in Grid after) is a very attractive solution. 

I think it is wrong to present search results the same way you display regular files structure, and even by design is a fail, because you can't show some metadata that user needs to know when performs a search (like location, last edit, etc)

It would be nice if you could add a special display view for searching, probably a kind of list (similar to shell search).

In any case this is just a half fix, since it solves the problem only for the List View, which is less common than Grid. 

Should I open a new bug for this?
Comment 28 Paolo Benvenuto 2013-07-11 07:56:50 UTC
I think that alex is right.

The correct behaviour could be that searching opens a new tab in list mode
Comment 29 António Fernandes 2013-07-11 08:13:29 UTC
(In reply to comment #27)
> I never use the list view (how many do?)

I almost always use list view.

> Should I open a new bug for this?

I think that's already covered by bug 311875 and bug 703629.
Comment 30 alex diavatis 2013-07-11 14:47:51 UTC
(In reply to comment #29)

> > I never use the list view (how many do?)
> 
> I almost always use list view.
> 

Yes I mean that Grid is the default view

> 
> I think that's already covered by bug 311875 and bug 703629.

Thank you for pointing those out