GNOME Bugzilla – Bug 332968
Too many items on drop-down menu
Last modified: 2007-12-18 18:50:11 UTC
Whenever I right-click on a webpage, too many options appear on the drop-down menu. Back, forward and reload are useful since they refer to very usual functions and thus save quite a lot of time. Save and add to bookmarks, however, only overbloat the menu and confuse the user. Furthermore, if I click on an image because I want to save it, the icon used to save the webpage and the one used to save the image are the same, which sometimes led me to mistake and made me save a webpage when I wanted to save an image. Other information:
I agree that the "Add to bookmark" items are not really needed in the context menu.
The icon part of this is solved with bug #410223 I also think that "Add to bookmark" is not very useful here.
Created attachment 92862 [details] [review] removes bookmark link from context menu this should remove the bookmark link item.
I don't think we should remove the bookmark link item; comment 0 was speaking about the "bookmark page" item, I think (that's the "ContextBookmarkPage" action, instead.)
Created attachment 92882 [details] [review] removes both bookmark and save, as requested in comment #0 Thanks chpe, you're right, I misunderstood the question. This should do what is requested. It seems a good choice to me also to remove "Save As..." from that context menu, as often it is misleading, and quite useless imho.
Cosimo, isn't your patch also removing the Add Bookmark action? Leaving control+D useless?
Diego: no, it was just the ContextBookmarkPage. The Bookmarks->Add Bookmark should be defined by { "FileBookmarkPage", STOCK_ADD_BOOKMARK, N_("_Add Bookmark…"), "<control>D", N_("Add a bookmark for the current page"), G_CALLBACK (window_cmd_file_bookmark_page) }, which is just a few lines before.
I just committed the last patch, you were missing this: Index: src/ephy-lockdown.c =================================================================== --- src/ephy-lockdown.c (revision 7238) +++ src/ephy-lockdown.c (working copy) @@ -174,8 +174,6 @@ update_window (EphyWindow *window, ephy_action_change_sensitivity_flags (action, LOCKDOWN_FLAG, disabled); action = gtk_action_group_get_action (action_group, "FileBookmarkPage"); ephy_action_change_sensitivity_flags (action, LOCKDOWN_FLAG, disabled); - action = gtk_action_group_get_action (popups_action_group, "ContextBookmarkPage"); - ephy_action_change_sensitivity_flags (action, LOCKDOWN_FLAG, disabled); action = gtk_action_group_get_action (popups_action_group, "BookmarkLink"); ephy_action_change_sensitivity_flags (action, LOCKDOWN_FLAG, disabled); Anyway committed with that included. Not closing because there are some other issues to tackle yet. 2007-08-02 Diego Escalante Urrelo <diegoe@gnome.org> * data/ui/epiphany-ui.xml: * src/ephy-window.c: * src/ephy-lockdown.c: Remove "Add bookmark" and "Save as" from the document context menu. Patch by Cosimo Cecchi. Part of bug #332968.
Diego: thanks, i really missed the lockdown part :( What other issues about this are still pending? The "save image" icon is already solved along with #410223, and I do not see any other requests here.
Right, closing as FIXED. Thanks!
I'm a bit late with this but I have my doubts about removing these context menu items, leaving only navigation-related context menu items on a web page. Looking at Evolution, it has 'Save as' and 'Print' as document-related context menu items. Evince has 'Copy' (we have that too if text is selected) and 'Select All'. Add that to Epiphany's document-oriented approach to the web, and I doubt that the current short menu in SVN is the right thing to do. There are a number of other bugs relating to the page context menu that need to be considered as well, that's why I am reopening this bug.
Updating version. Any opinions, please? Are my doubts unfounded? :)
Evince only has navigational items. It has a clean UI. Evolution has many non-navigational items. The UI is a mess. Epiphany only has navigation items (at least now). Ergo: it has a clean UI ;)
@Wouter: I don't consider Copy / Select all (in Evince) navigational. Do you?
Not having the save option in the context menu is really annoying, does this menu really need to be limited to 3 entries? It's not like there was over 10 options already there
To be honest I don't care, but Sebastien makes me note that it is not a big improvement to go from 5 items to 3 items, and I think he has a point on that. I didn't use those items, but I can think that maaaaybe for consistency we should have them there, think about right clicking stuff on the embed (links, images, etc) they all have action items on their context menus like save as or download or whatever, so it would make sense to have Save as and Add bookmark too I think. Hmmm?
I'd be ok with re-adding the items, but we're UI frozen...
Well, restoring the UI to what it was in 2.18 is hardly an UI freeze break. It's not like any translators or doc writers are affected... :)
I made some friends of mine switch to Epiphany lately, and I had requests from them to have the "Add Bookmark" item to the context menu. I agree that we could add that item again, while I would not re-add "Save as" item, as it is not used very often.
*** Bug 334596 has been marked as a duplicate of this bug. ***
Created attachment 101199 [details] [review] readd "Add to Bookmark" Attached patch adds again the "Add to Bookmark" item and also fixes the bug I just marked as duplicate.
Committed, thanks. I think now we can finally close this report. ------------------------------------------------------------------------ r7786 | cosimoc | 2007-12-18 19:45:27 +0100 (mar, 18 dic 2007) | 3 lines Readd "Add to Bookmark" entry to the document context menu. Bug #332968.