GNOME Bugzilla – Bug 410223
right click icon weirdness
Last modified: 2007-07-24 09:53:07 UTC
When currently using the right click menu, some icon weirdness appears. * Open Link is combined with the file-open icon, even though clicking the option just follows the link. * There seems to be a distinction between Download link and Save Link As, although download is actually just file-save (this also causes some weirdness when ). * The download/save confusion gets even worse when you're using tango-icon-theme, as that uses the harddrive approach for file-save and file-save-as, something we're probably going to use in gnome-icon-theme for 2.20 as well. I would suggest removing the icons in this menu, as the labels are great by themselves. Other information:
Created attachment 83006 [details] menu seen using the tango-icon-theme icon theme
That reminds me that Open Image and Open Link always confuse me :/. Can we change the Open Image icon for something that makes you think of viewing images (like a glass over a photograph?)?
Or just remove the icon. Too many icons is annoying.
I made a patch where i removed icons for the Download Link, Open Image and Save Image As options; i also substituted GTK_STOCK_OPEN with GNOME_STOCK_MAIL_NEW for the "Send Email" action and GTK_STOCK_OPEN with GTK_STOCK_JUMP_TO for the "Open Link" action.
Created attachment 91998 [details] [review] attempt to fix this bug
+ { "SendEmail", GNOME_STOCK_MAIL_NEW, N_("_Send Email…"), As far as I know, the gnome stock items are deprecated... The other changes are fine, thanks for the patch.
Devhelp says that the deprecated items are GNOME_STOCK_PIXMAP_*, replaced with GNOME_STOCK_*. Maybe someone from gnome-themes could help us here.
I meant deprecated that the gnome-* icons that those #defines expand to are deprecated icon names, afaik.
So how could i use e.g. the new mail icon in Epiphany? Do I need to "hack" with gtk_icon_theme_lookup_icon() and similar?
Have you consulted the icon naming spec (http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html ) for a suitable icon name? If there is one, just add it to the others in lib/ephy-stock-icons.[ch] and then you can use it. Otherwise we'd need to copy the one from gnome-icon-theme into epiphany (data/icons/*) and then proceed like above.
Created attachment 92043 [details] [review] modified patch using icon-naming-spec and chpe's directions Thanks Christian, i modified the patch following your directions.
Perfect. Thanks!
Sorry for the silly question (it's a short time I'm here on bugzilla), but my patch being marked as "accepted-commit_now", does mean that *I* have to commit it in any way (which would be unknown to me) or that you or another dev will commit it later? Thanks!
It means that if you have an svn account, you may commit the patch now; otherwise someone else will commit it for you.
2007-07-21 Wouter Bolsterlee <wbolster@svn.gnome.org> * lib/ephy-stock-icons.c: (ephy_stock_icons_init): * lib/ephy-stock-icons.h: * src/ephy-window.c: Remove some icons from the context menu, and use better ones for some menu items. Reported by Andreas Nilsson. Patch by Cosimo Cecchi. Fixes bug #410223.
Please note that we have yet a STOCK_SEND_MAIL stock icon defined in ephy-stock-icons.h. This stock icon should be currently used in File->Send Link menu item. I can't see any reason to add another stock icon for send email action (STOCK_NEW_MAIL), but I've no time and resources (until September, at least) to produce a patch, and no permissions to reopen this bug. Note: STOCK_SEND_MAIL is currently linking to "mail-forward" named icon just because "mail-send" is currently missing in gnome-icon-theme and "mail-message-new" appearance don't suggest you an email related action (it seems to me "new-document" instead).
Luca, isn't it a bug of gnome-icon-theme not providing the right icons then, rather than a epiphany one? STOCK_NEW_MAIL is used in a different context than STOCK_SEND_MAIL, because the former appears if i right-click on a "mailto: ..." link when the latter is used to send the link of an arbitrary page in a pre-compiled email, and imho forward is the right action there.
(In reply to comment #17) > Luca, isn't it a bug of gnome-icon-theme not providing the right icons then, > rather than a epiphany one? Of course, there was a comment in ephy-stock-icons.h saying that "mail-forward" was just a placeholer, waiting for complete icon set before pick up the proper icon. > STOCK_NEW_MAIL is used in a different context than STOCK_SEND_MAIL, because the > former appears if i right-click on a "mailto: ..." link when the latter is used > to send the link of an arbitrary page in a pre-compiled email, and imho forward > is the right action there. > Oh, that's right. So use different icons could be the right choise. Then, isn't a good idea use better names for stocks? For example STOCK_WRITE_MAILTO and STOCK_SEND_LINK_BY_MAIL (maybe too much descriptive) Or remove both stock definitons and directly use named icons in code. I.e. - { "FileSendTo", STOCK_SEND_MAIL, N_("S_end Link by Email…"), NULL, + { "FileSendTo", "mail-forward", N_("S_end Link by Email…"), NULL,