After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310288 - Icon chooser used in launcher & drawer properties is not friendly
Icon chooser used in launcher & drawer properties is not friendly
Status: RESOLVED OBSOLETE
Product: gnome-panel
Classification: Other
Component: panel
2.28.x
Other Linux
: Normal minor
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 344164 350173 352841 455564 470336 550553 568211 589427 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-07-13 21:59 UTC by Dick Gevers
Modified: 2010-10-02 09:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description Dick Gevers 2005-07-13 21:59:38 UTC
Version details: 2.10.2-1mdk.rpm
Distribution/Version: Mandriva Cooker 2006.0

Way to proceed:
Right click the panel and choose "Add to panel".
Choose "Custom application launcher".
Press "Add".
In the "Create launcher" window add all necessary entries and press "No icon".
A window appears showing the icons in /usr/share/pixmaps. The path is shown at
the top and a button "Browse" beside it. Press the button and browse to a
directory within the "Home" directory that contains icons (and which have proper
file permissions).

Problem: If the directory is selected and clicked (or double clicked, depending
upon user settings), all the icons in this directory are greyed out and cannot
be selected. But: see (*) below.

On the other hand, if the whole path to the desired icon is entered instead of
the default "/usr/share/pixmaps", the icon is added to the new panel launcher.

(*) On the other hamd if the same directory is selected and the button "Open" is
pushed (in the lower right hand corner of the file selector dialogue) it does work. 

So the problem is that opening the directory by ordinary means doesn't work,
only via the "open " button. IMHO that ought to be fixed.

--

A similar situation occurs when right clicking an existing launcher and choosing
"Properties" etc. further as above.
Comment 1 Jeremy Messenger 2005-07-15 20:43:02 UTC
I have the same problem here on FreeBSD, you can see a screenshot of it.

http://people.freebsd.org/~mezz/Screenshot.png

I always get grey disable, no matter where I go in even in my home directory or 
0777 image files. Same version, gnome-panel 2.10.2.
Comment 2 Sebastien Bacher 2005-07-15 21:47:22 UTC
that's not a bug, you have to select a file and not a folder, you can browser
with the fileselector and use the button to use the selected folder
Comment 3 Dick Gevers 2005-07-15 22:16:30 UTC
That is not correct. The file selector can be used anywhere by clicking and
entering, or double clicking on a directory and *then* selecting a file. That's
what I want to be able to do here as well. But launching as described that does
not work, only entering the directory via the "open" button works, and then you
can select a file, not the former way. This is inconsistent with the normal
operation in other situations of using the file selector, so you are wrong.
Sorry, but I reopen the bug.
Comment 4 Alex Ford 2005-07-15 23:59:02 UTC
To add another confirmation of this. I am running FreeBSD Gnome Panel 2.10.2.
Here's a screenshot: http://www.greenoceandesign.com/images/Screenshot.png

For reference, I also use the deskutils/smeg Gnome menu editor port and the icon
choosing dialog boxes work correctly.
Comment 5 Jeremy Messenger 2005-07-16 02:34:14 UTC
> that's not a bug, you have to select a file and not a folder, you can browser
> with the fileselector and use the button to use the selected folder

That's our point, how can we select a file when it's disable? Take a look at the 
screenshot again.
Comment 6 Sebastien Bacher 2005-07-16 11:14:11 UTC
The screenshot is right, you select a folder with the "Browse" dialog, then the
files from this folder are listed by the "Browse icons" dialog and you can pick
one. This is done this way because the fileselector has no image preview, it's
not on the file picker mode but the folder mode.
Comment 7 Dick Gevers 2005-07-16 14:43:14 UTC
I see your reasoning but it is user-unfriendly and counter-intuitive. Therefor
bad design overall. But if you say it is in accordance with the HIG I will leave
the bug closed, though unhappily.

Ciao,
=Dick Gevers=
Comment 8 Sebastien Bacher 2005-07-16 15:04:40 UTC
that is different of your initial concern, it works but maybe that's not
optimal. Reopening, updating the settings and the title.
Comment 9 Dick Gevers 2005-07-16 15:54:53 UTC
Thanks!
Comment 10 Jeremy Messenger 2005-07-16 17:13:22 UTC
> The screenshot is right, you select a folder with the "Browse" dialog, then 
> the files from this folder are listed by the "Browse icons" dialog and you can 
> pick one. This is done this way because the fileselector has no image preview, 
> it's not on the file picker mode but the folder mode.

Ah, now it works to allow me change the icon. Ok, I understand now that we are 
supposed to pick folder to 'open' it then browser the icons to select it. I 
didn't expected that the behavior has changed from 2.10.1 and below to 2.10.2.

It seems to be long way than what it's supposed to me if you already knew which 
file you want to use. The browser icons doesn't get refresh when I finished with 
select folder so I had to press enter key to get icons refresh/reload. It will 
be nice if you add allow select either folder or file, if selected folder then 
go back to browser icon. If seelected file then it's done.
Comment 11 Frederic Crozat 2005-07-19 12:16:27 UTC
cc Reinouts, because we discussed this exact same bug during GUADEC6.

I think there is two different problems here :
-file selector is used in directory mode, which is not very obvious for the
user, because "Browse..." doesn't give enough information on what is expected
from the user.
-once a directory has been selected with the file chooser, the icon selector is
not updated to display the content of the directory.

There are several ways to solve this :
-make sure icon view is updated when a new directory has been selected with
filechooser, so icon view is consistent with user choice.
-Change "Browse..." with "Select a folder containing icons.." or something similar.

Another solution would be to use filechooser in file selection mode (not in
folder selection mode), but it would probably require more changes in the icon
selector too.

Unfortunately, it is not possible to use file chooser to allow both file and
directory selection.
Comment 12 Reinout van Schouwen 2005-07-19 12:48:34 UTC
Thanks Frederic. 

IMNSHO the icon chooser is an archaic piece of junk. We can do without it:
pressing the icon button should simply bring up the icons folder (with
Nautilus). The folder window might not have an OK button but we don't need that
either: the icon will simply change instantly once an icon is selected in the
nautilus folder. The launcher properties has a revert button in case the user
liked the original choice better.
Comment 13 Boris de Laage 2005-07-21 13:14:38 UTC
Seems to be an usability issue. Do the usability team agree ?
Comment 14 Vincent Untz 2005-08-18 20:43:09 UTC
I'd very much prefer a new icon chooser...
Comment 15 Reinout van Schouwen 2005-11-03 13:38:21 UTC
Updating version, getting new reports about this problem.
Comment 16 Michael Crider 2006-04-27 06:17:54 UTC
I agree that alternative interfaces might be better.  However, the first solution in Comment 11 seems like it would be fairly trivial from a coding perspective (although I am not familiar with the code involved), and it would make the need for a new interface less pressing.
Comment 17 Sebastien Bacher 2006-05-04 13:49:00 UTC
The patch from bug #340478 fixes most of the issues with that widget
Comment 18 Jens Elkner 2006-06-08 12:38:49 UTC
But is still not, what a usual (aka none-technical) expects ...
Comment 19 Vincent Untz 2006-06-09 12:28:34 UTC
*** Bug 344164 has been marked as a duplicate of this bug. ***
Comment 20 Vincent Untz 2006-08-09 09:04:16 UTC
*** Bug 350173 has been marked as a duplicate of this bug. ***
Comment 21 Vincent Untz 2006-08-29 14:03:04 UTC
*** Bug 352841 has been marked as a duplicate of this bug. ***
Comment 22 Vincent Untz 2006-08-29 14:06:03 UTC
Updating summary.
Comment 23 Vincent Untz 2007-07-11 10:07:15 UTC
*** Bug 455564 has been marked as a duplicate of this bug. ***
Comment 24 trollord 2007-07-13 11:26:27 UTC
In case someone is interested and did not notice, I was not aware of this bug and made that 455564. Includes a quick mockup what a better icon chooser could look like, and couple small points about how it should perhaps behave.
Comment 25 Vincent Untz 2007-09-02 14:49:38 UTC
*** Bug 470336 has been marked as a duplicate of this bug. ***
Comment 26 André Klapper 2009-12-19 21:24:53 UTC
*** Bug 589427 has been marked as a duplicate of this bug. ***
Comment 27 André Klapper 2009-12-19 21:25:56 UTC
*** Bug 568211 has been marked as a duplicate of this bug. ***
Comment 28 André Klapper 2009-12-19 21:26:15 UTC
*** Bug 550553 has been marked as a duplicate of this bug. ***