GNOME Bugzilla – Bug 340478
fixes for GnomeIconEntry
Last modified: 2006-06-08 12:35:05 UTC
The following patch provides some much needed fixes for GnomeIconEntry. * update icon list when a new dir is selected * disable preview area in file chooser, not needed as we're selecting a directory * filter out non-directory items in the file chooser This third fix doesn't seem to work though. No errors, it just doesn't seem to apply the filter. When I put the filter in the update_preview function it would filter correctly but only once you've selected something in the list. I could use some help making it work right.
Created attachment 64710 [details] [review] patch
Created attachment 64719 [details] [review] new This patch fixes the problem with the filter, now does everything the summary says.
Created attachment 64803 [details] [review] try #3 The old patch would occasionally fail to apply the filter or have a flash of unfiltered data, this one doesn't seem to have that problem.
In HEAD: 2006-05-05 Travis Watkins <alleykat@gmail.com> * libgnomeui/gnome-icon-entry.c: Autoupdate icon list on dir change and remove preview widget. * libgnomeui/gnome-file-entry.c: Filter out regular files when using with directory-entry. Closes bug #340478.
Well, try #3 works, but: I think it is very convinient, that if a user has to choose (which is almost equivalent with browse) a directory, it is helpful to see its content. So it is ok and appreciated to show all files, but gray them out aka disable them for selection. The main problem is, that the dialog does not clearly states, what it expects from the user. A title like "... : Choose a folder" or "...: Choose a file" or "...: Choose files" would be (I guess) a quite simple thing to do with a very valueable result ... And last but not least, the problem, which has been resolved by the patch is, that the dialog should reflect the users choice immediately... Please have a look at bug #344164 - wrt. my findings that would be the best aka from a usual (non-technical) user expected variant...