I would love this feature. But this is a difficult task. Some cameras (Olympus EI-2000 or HP 912, etc.) do not create an audio file on the the mass storage device with the same name as the image, but embed the audio clip into the file.

Cameras these days create not only images, but audio and video files. 

I think it would be nice if F-Spot would allow media files to be imported with/from images and it would be very useful if those files would be exported to galleries as well.

An example image with embedded *.wav file:

http://violent.skystorm.net/im009254.jpg

*** Bug 302568 has been marked as a duplicate of this bug. ***

Bug #325366 is related to this one. Possible duplicate

There is for me two seperate issues here:

 1. the one described in bug #325366, which is about f-spot silently ignoring non-supported media, and;
 2. this bug, about supporting such media.

Should f-spot also manage videos? How about mp3s? How far should this go?

I think F-spot could also manage video media. I have opened a new request for this:
http://bugzilla.gnome.org/show_bug.cgi?id=353773

I think supporting audio attachments is also a separate issue.

*** Bug 353773 has been marked as a duplicate of this bug. ***

I fail to see how a separate enhcement request for VIDEO media support and this one for AUDIO media support are duplicates. 

Created attachment 81487 [details] [review]
RFC: not implemented at all!

This silly little patch abuses ImageFile enough to get an .avi file to import into the database. It does not do any thumbnail stuff, nor does it do any native viewing, and it mostly just causes a lot of exceptions. It does, however, allow the .avi's to be detected, imported into the database, and gives the error image as a thumbnail (thank you f-spot!). You can then right-click and "Open with" the file. A starting point!

Next question: Should we aim for native viewing? Or perhaps prompt with a dialog saying something like, "f-spot cannot view this, would you like to try an external program?" .. then use the GnomeVFSMime to determine the correct app to open?

I think it would be cool to have a thumbnail taken n seconds into the video.  From there the user could "Open With".

The thumbnails are going to be handled by totem-video-thumbnailer, which is the same thing that Nautilus uses.  Therefore, if you want to change how the thumbnail is taken, you should modify totem-video-thumbnailer (although it already seems to work pretty well. I think it finds the first non-black screen, either that or skips a few seconds)

Created attachment 81497 [details] [review]
Loads AVIs into FSpot with thumbnails

This uses totem-video-thumbnailer to generate the thumbnails.  For me, each one took about 1 second, so I allow it 5 seconds to create the thumbnail or else it returns null.

About abusing ImageFile: While AVIs aren't really images, I don't think this abuses the class too much since we are representing a video with an image, and we aren't making FSpot a video-editor or anything.  We open the videos with an external application.  Therefore, there is really no practical need for a new "VideoFile" class.  Semantically there is a little bit of difference, but not much.

Created attachment 82516 [details] [review]
Abstracts ImageFile to the more general MediaFile, and creates a VideoFile class.  Updates (most) UI elements so certain actions cannot be applied to videos.  (caution: WIP)

This patch does 2 new things:
 1. Updates UI elements (but not all yet) so that actions such as filters, print, export, etc. cannot be done on video files.  There is still some work to be done here (context menus, rotate buttons, etc)
 2. MediaFile class is created.  ImageFile and VideoFile now inherit from this class.  Hopefully F-Spot can just open MediaFiles without having to deal with whether it is a video or an image.

Created attachment 82545 [details] [review]
Abstracts ImageFile to the more general MediaFile, and creates a VideoFile class.  Updates (most) UI elements so certain actions cannot be applied to videos.  (caution: WIP)



Sorry, forgot to do an "svn add MediaFile.cs VideoFile.cs" before doing the "svn diff"

This patch should have the new classes.

Just curious, how is date and time for the video handled in this patch? The camera that I use creates .thm-files for every video I record, should these maybe be used when they exist? Also these files contains an EXIF Date/Time tag that could make sorting easier.

The date and time determination depends on the type of the file, each of which have their own loader.  I followed the convention used with Images: it is loaded from EXIF data if available, otherwise it is the current time (DateTime.Now)

These .thm files appear to just be .jpg files containing the EXIF data for the associated video.  I suppose that AVI files cannot contain exif data?  Since these .thm files are actually thumbnails of the videos, if we could get those then it should be quicker than generating thumbnails for each video.

Yes, they are just renamed .jpg-files as far as I know. One problem could be that these files are to small when browsing with full zoom, the pictures my camera creates are just 160x120 pixels. Anyway, this should be faster than creating a thumbnail from the video.

Yeah, we would have to regenerate the thumbnail when they are imported.  But in the file-selection dialog during import it would be much faster to use this instead of creating our own.

Sorry I haven't had a chance to review this yet, I'll be looking over it in the next couple of days.

Created attachment 85586 [details] [review]
Updated to work with latest pull from SVN (2007.03.30)

I fixed all the compile errors and also added the ability to import .mov, .mpeg, and .mpg files.

There are still some known bugs, such as:
1. Edit buttons (such as rotate) don't always get disabled when a video is selected.  So far there isn't a very clean way to do this.  I might need to add some methods to BrowsablePointer or somewhere central to selected items.
2. FullScreen and Slideshow modes did not work so well with videos.  At least they no longer crash F-Spot.
3. The dialog to create a new version is displayed when trying to playback a video through an external app.

(In reply to comment #20)

> I fixed all the compile errors and also added the ability to import .mov,
> .mpeg, and .mpg files.

It would be possible to add support for .3gp files (cell phone videos) too?
They're normal MPEG files with 3gp audio.

thanks
maxxer

Maxxer,
if .3gp files are able to be thumbnailed by totem-video-thumbnailer (or gnome-video-thumbnailer, which I think (but am not sure) is the same thing) then it would be trivial to add .3gp support.  Even if it doesn't support them, we could still allow .3gp files to be loaded into the database, but they would have a blank (ie. the default) thumbnail, and thus somewhat unusable.

Could you either test totem-video-thumbnailer on a .3gp file (and post the results here) or send one to me via email so I could test it?  thanks

(In reply to comment #22)

> Could you either test totem-video-thumbnailer on a .3gp file (and post the
> results here) or send one to me via email so I could test it?  thanks

Actually it doesn't work. I tried with totem-2.16.5 and says 

** Message: don't know how to handle application/x-3gp


Being just able to tag them would be fine, because I would like to keep those small videos along with the photos taken in the same situation.
I know they just would be with a blank preview, but I guess it's just a small problem. After searching on Google it seems Gstreamer can handle 3gp files, so I don't understand why it's complaining.

I'll do some further searches and report back.

*** Bug 427832 has been marked as a duplicate of this bug. ***

very good if will possible *.avi too future. I have Canon A430 and it is *.avi format. Digital Camera is not only photo, it's short films too...

very good if will possible *.avi too future. I have Canon A430 and it is *.avi format. Digital Camera is not only photo, it's short films too...

Andrzej: The avi format is already included

Everybody:
The current list is [avi, mpg, mpeg, mov]
I may add 3gp support as well, but until we can reliably thumbnail them, it will be rather unusable except for importing and tagging.

keep in mind that there is really only 1 line of code that needs to be added in order to add support for a file.  In my patch, you will find a structure called "name_table" in MediaFile.cs that lists all usable formats.  Simply adding a new one will allow you to import that file into the database, tag it, etc... although other features (such as thumbnails, full screen mode, etc) may or may not work.

For example, this is the single line of code I added to allow .mpg files to work:
name_table [".mpg"] = typeof (VideoFile);

Feel free to add these yourself if there is a format you wish to have that is not included in the patch (and then let us know how it worked on this bug report! :)

(In reply to comment #27)
> Andrzej: The avi format is already included
> 
> Everybody:
> The current list is [avi, mpg, mpeg, mov]
> I may add 3gp support as well, but until we can reliably thumbnail them, it
> will be rather unusable except for importing and tagging.

Well, tagging would be good enough! Btw this is the function of F-Spot on videos, isn't it?
Just having a movie tagged along with other pictures would be great :-)

Anyway, from the searches I did it seems totem (gstreamer) support 3gp files, but actually I couldn't make it work on my pc.

I will let you know if I make any progress in thumbnailizing them :)

I'm sorry, but where is this file? 
"MediaFile.cs"

Maxxer: like I said, it's in my patch.  You will first have to apply the patch to a clean code tree.  From the base directory, use "patch -p0 < locationOfPatch".  Or follow these instructions: http://f-spot.org/How_To_Build_from_HEAD

My patch is the last attachment to this bug page (comment #20 by me)

After you have applied the patch, it's at(base_directory_of_F-Spot)/src/Imaging/MediaFile.cs

(That last message should have been directed to Andrzej, not Maxxer.  My apologies)

Oh, and btw, I did not have much trouble generating a thumbnail from a .3gp file I found on the web (although it did issue a warning about not recognizing the sound.... but we don't care about that), so in my next patch I will be adding 3gp support as well.

Hi Michael, here's my review of your patch

- This patch doesn't solve at all the reported bug (which was about embedded audio files) but it's still very valuable...

- I didn't tested it yet, but it compiles with some manual patching due to latest changes in svn

- note for an potential committer, do not commit MediaFile as-is, but do first a svn cp from ImageFile, then apply the changes (so we keep history)

- IBrowsableItem.cs: Editable and IsEditable does not belongs to BrowsablePointer. This may cause problems while selecting multiples files and videos and then trying to edit them (the status of the button will only reflect the Editable capability of one item). So, the Editable proberty of BrowsablePointer should be AND'ed from the Editable properties of the inner collection. 

- Using Editable to disallow printing is potentially wrong, cause the Editable property should reflect more than just the video/image duality. I totally can think about un-editable but printable items...

- Same for the export, some exporters can easily supports video (like Picasaweb). So, for both print and export, I'd say do not disallow the button at the main ui level but instead let the print or export code deal with those files...

- VideoFile.cs: GetThumbnailerCommand and GetScreenCaptureCommand should be made static properties instead. I think also that both could be unified and the 2 Load methods could share some code

- Please follow the HACKING conventions, esp. for space around () and the case for variables.

That's it for now... as you can see, no big showstoppers, only some cosmetic sugar to add here and there... Hope to be able to test this soon

Thank you Stephane!
It's nice to finally get feedback on my first patch.  Now I can go fix it up! (well, after final exams are over...)

As for not solving the reported bug/feature... It does not do what the description says (embedded audio) but the title is "Support for audio and video media from digital cameras", so according to that I did half of it.  Perhaps it wasn't the best idea to hijack the bug, but I figured it was the closest match.

And for the comments on the code, I'll think about your suggestions and try to make a fix as soon as I have time (after June 15)

Thanks again!

What is the status of this fix? Is it likely to be committed soon?

Also, does it handle the upload from the camera properly? Does any more work need doing on it?

Cheers

Hi Michael,

I already tested superficially your patch and seems to work properly, excepting a little bug:
- The code " & item.IsEditable" that appears in some places in your patch doesn't work if the DB is empty (after the first installation, for example). A short-circuit and ("&&") should have been used in order to avoid the evaluation of the getter with an invalid "item".

I didn't review the coding style or anything like that. I'm sorry, I know that I'm not following the Review Guidelines, but I'm a programmer (although a newbie in C#) and I couldn't hold me back from attacking the code directly :-)

I adapted it to a not older than one month development source version, but I didn't generate any patch :-( And unfortunately I have already modified the code too much to generate it now. In fact, I'm trying to extend it to support Canon videos (they come with some .thm attached files, were the metadata of each video are contained). Right now I'm just hacking the code very messy, I'll try to make it up later (when it works) and follow the Coding Guidelines and then I'll post it for a review.

I'm quite happy with F-Spot and will try to participate in its improvement.

*** Bug 370347 has been marked as a duplicate of this bug. ***

I second Henry Gomersall's question: is the patch going to committed anytime soon?

Created attachment 106068 [details] [review]
Review comments of Stephane Delcroix processed, updated to SVN 2008-02-27 and added support for Canon .thm accompanying files

Hi there,

I finally found some time to work a little bit on this patch!

I simply added the following things: 
- I processed the comments of Stephane Delcroix to the patch delivered on 2007-03-30 by Michael Wayne Goodman (http://bugzilla.gnome.org/attachment.cgi?id=85586&action=view).
- I added support for the files with extension .thm that Canon cameras generate for each video containing the metadata of the video.
- I added some nice handling for a couple of actions non-applicable/non-supported for videos: rotate and print. It's still undone for all other non-applicable actions (for example, all the actions that can be done in the "Edit" view.

I know that this patch doesn't add much, but that's better than nothing :) I hope that you find it useful and to find some more time to work on it in the future.

I'm eager to hear your comments to it.

Hasta la vista, baby

Thanks Silvano!  I'm glad someone has time to finish this up.  I was starting to feel bad that others were waiting for me to finish this, but school has been keeping me too busy.

One comment: I'm not sure exactly how to check for this in the patch, but did you recreate MediaFile.cs by using "svn cp" on ImageFile?  Stephane asked to do this so we can preserve the version history in the file.

Anyway, like I said, grad school affords me no time to do hobby coding for F-Spot, so I can't test out your code just yet.  I'll look forward to testing it out soon, though!

Thanks again!

Just gave a try to the last patch. It didn't apply absolutely clean and I have to change two lines from FSpot.Unix.xxx to FSpot.Utils.Unix.xxx. Other than that seems working.

the patch doesn't apply anymore.
Silvano, if you can find the time to update it to current svn there are big chances that it will be committed soon.

I'm on it. I had some problems to get all the dependencies resolved, but I finally got it.

I already updated the source code to the last svn version (revision 4075). It starts at least :) I hope that I'll have time to test it in the following days. I'll submit it as soon as I'm ready with it.

Created attachment 114218 [details] [review]
Updated to last SVN revision 4166 (2008.07.08)

I finally got some time to update the patch to the last SVN revision 4166 and test it.

Could anybody else please test it?

Great! Thank you so much! I found:

1.ignors .wmv file. debug info:
uri = file:///home/simeon/Bilder/All_Movies/Berlin-080524/Movie001.wmv
Scanning /home/simeon/Bilder/All_Movies/Berlin-080524
[Debug 20:44:11.710] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos WHERE uri LIKE "file://:dir%" AND uri NOT LIKE "file://:dir/%/%"
[Debug 20:44:11.715] Query took 0,00513s

file info on .wmv:
nothing

2. does not respect .thm files. 
The video file's timestamp is (mostly) not correct. The corresponding .thm file contains correct meta data if available.

3. CRASHES on "delete from disk"

.. but file got deleted.
Steps to reproduce: dragndrop avi file to import, switch to edit view, select "delete from disk". Trace:
simeon@dell-desk:~$ f-spot --debug
** Running f-spot in Debug Mode **
** Running Mono with --debug   **
[Info  20:27:27.183] Initializing DBus
[Debug 20:27:27.303] DBusInitialization took 0,096989s
[Info  20:27:27.303] Initializing Mono.Addins
[Debug 20:27:27.461] Mono.Addins Initialization took 0,15801s
[Info  20:27:27.469] Starting new FSpot server
[Debug 20:27:27.816] Db Initialization took 0,226017s
[Debug 20:27:28.027] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 20:27:28.224] Query took 0,195772s
[Debug 20:27:28.239] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 20:27:28.380] Query took 0,140983s
[Info  20:27:28.735] Starting BeagleService
[Debug 20:27:28.737] BeagleService startup took 2,5E-05s
uri = file:///home/simeon/Bilder/All_Movies/MVI_1717.AVI
Scanning /home/simeon/Bilder/All_Movies
[Debug 20:27:45.004] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos WHERE uri LIKE "file://:dir%" AND uri NOT LIKE "file://:dir/%/%"
[Debug 20:27:45.010] Query took 0,005288s
Stopping
[Debug 20:27:46.476] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE  photos.roll_id IN (274)  AND photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 20:27:46.482] Query took 0,006607s
[Debug 20:27:46.482] GroupAdaptor::Reloading
[Debug 20:27:46.482] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 20:27:46.668] Query took 0,185757s
[Debug 20:27:46.693] open uri = file:///home/simeon/Fotos/2008/04/30/MVI_1717.AVI
[Debug 20:27:46.757] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE  photos.roll_id IN (274)  AND photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 20:27:46.763] Query took 0,006111s
[Debug 20:27:46.763] GroupAdaptor::Reloading
[Debug 20:27:46.763] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 20:27:46.849] Query took 0,086002s

(f-spot:8202): GdkPixbuf-WARNING **: GdkPixbufLoader finalized without calling gdk_pixbuf_loader_close() - this is not allowed. You must explicitly end the data stream to the loader before dropping the last reference.
Syncing metadata to file...
 path == /home/simeon/Fotos/2008/04/30/MVI_1717.AVI
[Debug 20:28:02.112] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE  photos.roll_id IN (274)  AND photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 20:28:02.124] Query took 0,011433s
[Debug 20:28:02.124] GroupAdaptor::Reloading
[Debug 20:28:02.124] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 20:28:02.287] Query took 0,162722s
Exception in Gtk# callback delegate
  Note: Applications can use GLib.ExceptionManager.UnhandledException to handle the exception.
System.ArgumentNullException: Argument cannot be null.
Parameter name: key
  at System.Collections.Generic.Dictionary`2[System.String,Gdk.Pixbuf].set_Item (System.String , Gdk.Pixbuf ) [0x001ca] in /build/buildd/mono-1.2.6+dfsg/mcs/class/corlib/System.Collections.Generic/Dictionary.cs:202 
  at FSpot.Utils.DisposableCache`2[System.String,Gdk.Pixbuf].Add (System.String , Gdk.Pixbuf ) [0x00000] 
  at FSpot.Widgets.Filmstrip.GetPixbuf (Int32 i, Boolean highlighted) [0x00000] 
  at FSpot.Widgets.Filmstrip.GetPixbuf (Int32 i) [0x00000] 
  at FSpot.Widgets.Filmstrip.OnExposeEvent (Gdk.EventExpose evnt) [0x00000] 
  at Gtk.Widget.exposeevent_cb (IntPtr widget, IntPtr evnt) [0x00000] 
   at GLib.ExceptionManager.RaiseUnhandledException(System.Exception e, Boolean is_terminal)
   at Gtk.Widget.exposeevent_cb(IntPtr widget, IntPtr evnt)
   at Gtk.Widget.exposeevent_cb(IntPtr , IntPtr )
   at Gtk.Application.gtk_main()
   at Gtk.Application.gtk_main()
   at Gtk.Application.Run()
   at Gnome.Program.Run()
   at FSpot.Driver.Main(System.String[] args)


But all looks very good. I really, really like it.

I'm on Ubuntu Hardy, F-Spot Rev. 4166.

Oh, and this one:
Not possible to set comment directly after import in edit view. Furthermore a big, red X is displayed only in edit view (the thumbnail slide above is OK). When removing the import roll filter, the edit view is OK again.

Thank you! That's really motivating! Having someone who's seriously testing my patch is really helpful. I'll have a look at your comments as soon as possible and try to clean the bugs.

I forgot to say that right now it only supports metadata of Canon videos :-| Because those are the only ones that I have to test the patch. Therefore I would appreciate any other video with metadata sample that I could get to add it to the patch.

Right now the patch supports AVIs, MOVs and MPEGs, but not yet WMVs. Could you send me a sample to try to add it to the patch? If "totem-gstreamer-video-thumbnailer" is able of extracting a thumbnail out of it, then it should be as easy to solve as adding a new line to VideoFile.cs :-)

BTW, I'd like to point out that around 90% of the patch or even more was originally written by Michael Wayne Goodman. I'm just trying to finalize it :-)

Thanks for the credit, Silvano. Let's not forget Alex Polvi, who teamed up w/ me for the first couple patches. He's also the dude who got me interested in the patch in the first place :)

Btw, when I was testing my patches I found some videos on the web from different cameras... I'm not sure where I got them. Perhaps f-spot.org should keep a small set of photos and videos (contributed by users) for developers to test with?

I'd be happy to provide a small video sample from a Nikon Coolpix S210. I've uploaded it here: http://epistel.no/temp/dscn0485.avi (just a second or two, I suppose that's all you need?)

I also have a Canon camera, it's a IXY-90. Here is a example for .avi and .thm file. http://homepages.fh-regensburg.de/~fes32045/canon-ixy-90.tar.gz.
However I lost it, what a pity, so I cannot test import with this.

Here are more suggestions/bugs:

1. Videos from a Kodak EasyShare Z740: It produces *.mov containing mpeg. The files are imported correctly. However, there is no big view in edit view, only a small strike. f-spot --debug:
(...)
[Debug 23:26:57.510] Query took 0,086305s
[Info  23:26:57.812] Starting BeagleService
[Debug 23:26:57.813] BeagleService startup took 1,9E-05s
[Debug 23:26:59.671] open uri = file:///home/simeon/Fotos/2008/07/11/100_5172.mov

(f-spot:13772): GdkPixbuf-WARNING **: GdkPixbufLoader finalized without calling gdk_pixbuf_loader_close() - this is not allowed. You must explicitly end the data stream to the loader before dropping the last reference.

file info: 
simeon@dell-desk:file 100_5172.mov 
100_5172.mov: MPEG sequence

this sample file:
http://homepages.fh-regensburg.de/~fes32045/kodak-easyshare-z740.mov

totem-gstreamer-video-thumbnailer worked fine on it.

2. Editing tools should be grayed out in edit view
3. Don't ask for new version to create on "open with" when it's a video file
4. If multiple videos are selected, don't show "x photos" selected in the left sidebar, but "x Videos"; if multiple photos and videos selected, show "x media files"
5. CRASHES on leaving "slide show". Probably another issue. Using Nvidea prop. drivers:
simeon@dell-desk:~$ f-spot --debug
** Running f-spot in Debug Mode **
** Running Mono with --debug   **
[Info  12:10:50.748] Initializing DBus
[Debug 12:10:50.917] DBusInitialization took 0,14541s
[Info  12:10:50.917] Initializing Mono.Addins
[Debug 12:10:51.134] Mono.Addins Initialization took 0,217009s
[Info  12:10:51.141] Starting new FSpot server
[Debug 12:10:51.561] Db Initialization took 0,265946s
[Debug 12:10:51.789] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 12:10:51.958] Query took 0,16831s
[Debug 12:10:51.971] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 12:10:52.052] Query took 0,080786s
[Info  12:10:52.384] Starting BeagleService
[Debug 12:10:52.385] BeagleService startup took 2,4E-05s

(f-spot:12785): GdkPixbuf-WARNING **: GdkPixbufLoader finalized without calling gdk_pixbuf_loader_close() - this is not allowed. You must explicitly end the data stream to the loader before dropping the last reference.
[Debug 12:10:54.744] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE (((id IN (SELECT photo_id FROM photo_tags WHERE tag_id IN (142))) AND id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2))) ORDER BY photos.time
[Debug 12:10:54.757] Query took 0,012877s
[Debug 12:10:54.757] GroupAdaptor::Reloading
[Debug 12:10:54.757] Query: SELECT photos.id, photos.time, photos.uri, photos.description, photos.roll_id, photos.default_version_id, photos.rating FROM photos  WHERE photos.id NOT IN (SELECT photo_id FROM photo_tags WHERE tag_id = 2) ORDER BY photos.time
[Debug 12:10:54.837] Query took 0,079372s
[Debug 12:10:54.861] open uri = file:///home/simeon/Fotos/2008/04/30/CLIP0063.AVI
[Debug 12:10:57.744] open uri = file:///home/simeon/Fotos/2008/04/30/CLIP0063.AVI
[Info  12:10:57.763] Inhibit screensaver for slideshow
[Debug 12:11:03.770] open uri = file:///home/simeon/Fotos/2008/04/30/CLIP0064.AVI
[Debug 12:11:13.293] open uri = file:///home/simeon/Fotos/2008/04/30/CLIP0063.AVI
The program 'f-spot' received an X Window System error.
This probably reflects a bug in the program.
The error was 'GLXBadContext'.
  (Details: serial 7799 error_code 128 request_code 128 minor_code 4)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
Locking assertion failure.  Backtrace:
#0 /usr/lib/libxcb-xlib.so.0 [0xb59d3767]
#1 /usr/lib/libxcb-xlib.so.0(xcb_xlib_lock+0x2e) [0xb59d381e]
#2 /usr/lib/libX11.so.6 [0xb5dad518]
#3 /usr/lib/libGL.so.1 [0xb2cb17d5]

"3. Don't ask for new version to create on "open with" when it's a video file"

Disagree. I never want to work on the original file, regardless of whether the file in question is a photo or a video. I'm assuming here that "open with" will give access to video editing applications if any are installed, in addition to video viewers.

Hmm, that's a good point.

The reason that's there is because F-Spot doesn't play video, and we have to open it in another application for viewing. I suppose the best solution is to embed a video player in F-Spot, but that should probably be another feature request.

But you're right. We shouldn't break consistency with regular F-Spot behavior, because the user might assume a new version is created and accidentally write over the original file.

A question: I just noticed that f-spot doesn't put the imported avi files into the right date folder. All avi files are put in the folder of the day of importing, rather than when they were actually recorded. Will this patch do anything to fix that, or should I report it separately? Is the meta data available in the file at all?

I'm sorry I didn't have time to have a look at the reported problems/questions.

I just had time to check the issue reported in comment #54 by Eira Monstad (http://bugzilla.gnome.org/show_bug.cgi?id=166038#c54). And I think that I should explain how the patch regarding metadata works.

As far as I know typical video formats doesn't support metadata (like JPEG files for example do). By default my patch uses the file creation time as video creation time, because no other date and time is available. Fortunately, photo camera makers have found workaround to make "videos with metadata". 

I can explain how Canon resolved it in my camera model (and I suppose that in many other). My Canon Ixus 50 creates and extra file (with .thm extension) accompanying the video file (with .avi extension). The accompanying file is simply a JPEG file with .thm extension. The metadata of the file are those of the video and the image is a snapshot of the video at a lower resolution (in fact simply a thumbnail). Therefore videos taken by my camera "contain" metadata, I just have to abstract a video no as a file, but as a group of files :-)

To summarize, "no metadata, no way to report the right date" :-)

Regarding point "2. Editing tools should be grayed out in edit view
" of comment #51 of comicinker (http://bugzilla.gnome.org/show_bug.cgi?id=166038#c51): that's one of the pending TODO's :-)

Regarding point "2. does not respect .thm files. 
" of comment #44 from comicinker (http://bugzilla.gnome.org/show_bug.cgi?id=166038#c44):

I can confirm it, altough I wondered how it can happen, since the video metadata handling got copied from the JPEG metadata handling... I'm thinking that it's probably related to the problem mentioned here http://www.mail-archive.com/f-spot-list@gnome.org/msg04316.html ("Resets the date/time to GMT if you have a world time camera"). Let's see if I can figure it out somehow.

Created attachment 115497 [details] [review]
Updated to last SVN revision 4209 (2008.07.29)

- Updated to SVN revision 4209
- VideoCanonFile.cs slightly modified to maintain it so similar to JpegFile.cs as possible (it's easier to maintain)
- VideoCanonFile.cs slightly modified to use exactly same DateTime management as JpegFile.cs, therefore issue with DateTime metadata modified to use GMT (see http://www.mail-archive.com/f-spot-list@gnome.org/msg04316.html) common to both

I already had a look at the issue 1. of the comicinker's comment #44 (http://bugzilla.gnome.org/show_bug.cgi?id=166038#c44): "ignors .wmv file".

The problem is that the gnome-video-thumbnailer can't unfortunately process .wmv files :-( And I didn't find any Linux tool to generate thumbnails out of .wmv files 8-O

Since I don't know any way to get .wmv videos properly imported to F-Spot, I would say that they won't be supported by F-Spot, at least not by my patch.

Let's go to the last issue (number 3.) of the comicinker's comment #44
(http://bugzilla.gnome.org/show_bug.cgi?id=166038#c44): 'CRASHES on "delete from disk"'.

I wasn't able to reproduce the problem, although I followed comicinker's instructions. However, I have to say, that I tried it with the last version of the patch over revision 4209. So I would recommend you to test it again with the same configuration: SVN trunk revision 4209 + patch ID 115497 (http://bugzilla.gnome.org/attachment.cgi?id=115497).

Nevertheless, by testing the reported error I discovered that if the video has an accompanying file (for example, the .thm file that Canon files generate), the "Delete from disk" command forget to delete the accompanying file. That bug will get resolved in the next version of the patch.

One comment regarding the support for .wmv videos: gnome-video-thumbnailer usually doesn't support .wmv videos, but from time to time it does work 8-O Really! The problem is that  

gnome-video-thumbnailer --gst-debug-level=1

Just forget my previous comment, I accidentally pressed posted it :-/

One comment regarding the support for .wmv videos: gnome-video-thumbnailer
usually doesn't support .wmv videos, but from time to time it does work 8-O
Really! The problem is that "ffmpeg" can't handle them properly. Just try this "gnome-video-thumbnailer --gst-debug-level=1 video.wmv thumbnail.png", I get following error: "ERROR ffmpeg :0:: Old WMV3 version detected, only I-frames will be decoded". Why does it sometimes work? No freaking idea :-)

*** Bug 549708 has been marked as a duplicate of this bug. ***

In my other bug (the one I just closed as duplicate, sorry) I had the idea that tagging videos should be done on a timeline; for example if I were to film a video in which different people show up over time it would be great if I then could assign different tags to different pieces of the video.

The search would then, possibly, seek to the right video position when matching a video and show that frame, or at least when I click on the video I get the tags to jump forward to that frame.

*** Bug 550141 has been marked as a duplicate of this bug. ***

*** Bug 553737 has been marked as a duplicate of this bug. ***

Hi, I see there hasn't been any recently news on this feature and I wanted to know if it is ready to make it into the mainstream release?

I want to add that I think it's one of the most desirable features as I've reviewed other picture management programs and couldn't find any free-open-linux with a good video integration which today is a must as it's already mainstream to record video and audio (media) with what used to be only-still-picture cameras and it's part of the integrated process from an end-user point of view.

I will be trying to build from scratch and apply the patch to issue further technical comments, but since I'm not that experienced, I'm not sure when will that be... in the mean time, if any of the maintainers could comment, it'll be appreciated.

Just finished compiling the last header version with no problems, applied the patch and I get an error regarding the impossibility to apply the patches since neither of the following files exist anymore (at least not where the patch looks for them):
  src/PrintDialog.cs	(revision 4209)
  extensions/FacebookExport/FacebookExport.cs	(revision 4209)
and the compilation fails.

I understand that it can't work with head, but it's a sanity test that I did in order to review that I'm actually able to compile and run a head version. All went normal.

So I start again as suggested with the 4209... and this version fails to compile (without applying the patch), so I'm basically stuck then. The patch was ok to apply though, but forget about compiling.

I will post the error, but I'm not sure it is worth taking a look at it if the main trunk has already moved so much from this patch/branch and it would be nice to know whether it will be merged in the main trunk?

I used  svn co http://svn.gnome.org/svn/f-spot/trunk -r 4209 f-spot.TestPatch
and then the error in the make was around here:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I. -I.. -I .. -DLIBEOG_ETTORE_CHANGES=1 -DG_LOG_DOMAIN=\"libf\" -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED -DORBIT2=1 -pthread -D_REENTRANT -I/usr/include/libgnome-2.0 -I/usr/include/orbit-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/include/pango-1.0 -I/usr/include/gail-1.0 -I/usr/include/freetype2 -I/usr/include/atk-1.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/libexif -I:/usr/lib/pkgconfig/../../share/gapi-2.0/glade-api.xml -I:/usr/lib/pkgconfig/../../share/gapi-2.0/pango-api.xml -I:/usr/lib/pkgconfig/../../share/gapi-2.0/atk-api.xml -I:/usr/lib/pkgconfig/../../share/gapi-2.0/gdk-api.xml -I:/usr/lib/pkgconfig/../../share/gapi-2.0/gtk-api.xml -I:/usr/lib/pkgconfig/../../share/gapi-2.0/glib-api.xml -I:/usr/lib/pkgconfig/../../share/gapi-2.0/gnome-vfs-api.xml -I/usr/include/mono-1.0 -I/usr/include/libexif -g -O2 -MT f-image-view.lo -MD -MP -MF .deps/f-image-view.Tpo -c f-image-view.c  -fPIC -DPIC -o .libs/f-image-view.o
In file included from f-image-view.h:27,
                 from f-image-view.c:26:
../libeog/image-view.h:97: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘image_view_get_type’
f-image-view.c: In function ‘f_image_view_window_coords_to_image’:
f-image-view.c:110: error: expected expression before ‘ImageView’
f-image-view.c:110: warning: passing argument 1 of ‘image_view_get_pixbuf’ makes pointer from integer without a cast
f-image-view.c:112: error: expected expression before ‘ImageView’
f-image-view.c:114: warning: passing argument 1 of ‘image_view_get_offsets_and_size’ makes pointer from integer without a cast
f-image-view.c: In function ‘image_coords_to_window’:
f-image-view.c:144: error: expected expression before ‘ImageView’
f-image-view.c:144: warning: passing argument 1 of ‘image_view_get_pixbuf’ makes pointer from integer without a cast
f-image-view.c:147: error: expected expression before ‘ImageView’

Maxim, maybe you don't consider it good, but KPhotoAlbum has video integration and I'm quite happy with it. This feature lacking on F-Spot is one of the showstoppers to switch for me.

Getting on the cc: list. I would like to see video added to F-Spot.

Ditto.  This is the only reason I'm using digiKam instead of f-spot.

Hello,
This feature would be very useful for me but I don't really want to install f-spot from source. Wouldn't be possible to make it as an add-in (extension) so everybody can test it more easily?
I've seen that there is an howto to build an extension at: http://f-spot.org/Extend_F-Spot

Thanks

Video support is what I need. CCed

Please make this happen.

Thank you.

Did you think about using the profiles that Arista¹/Transmageddon² share in order to transcode vidéos ?
I’d realy like to be able to send videos to picasaweb.
One of the basic important thing is to be able to 90° rotate a video. For the moment, I use a one line mplayer command…

Maybe some code from the embeded video player in banshee could be useful.

Thank’s for your amazing job !
Cheers,

[1] http://programmer-art.org/projects/arista-transcoder
[2] http://www.linuxrising.org/transmageddon/

(In reply to comment #73)
> Video support is what I need. CCed

Same here, this is my prio 1 enhancement request since video support is so common on todays photo devices.

nice enhancement, whats the status now?

Please add this feature urgently!

At least, the feature to import the video files and to add a note / comment / tag over that file.

If it's so hard to achieve, did it with no thumbnail, no video play. Just to import the file.

Now, I connect my camera and use f-spot to download my pictures, and then I've to open nautilus and navigate to the video folder on the camera to manually download the video files to the same f-spot folder.

Thanks in advance...

Comment on attachment 115497 [details] [review]
Updated to last SVN revision 4209 (2008.07.29)

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###

I've been looking to see what digital camera management program would import videos natively. It is a giant pain in the butt for me to import pictures and then manually save videos. I shudder to think of what my relatives would do thinking that all videos were already imported and then wiping the camera card. 

I hate to be the bearer of competing news, but Shotwell has been working on this same feature ( http://trac.yorba.org/ticket/855 ) and has closed their ticket. 

Their release date for that feature is November 2010. 

As an end user with years and years of f-spot videos already I have to admit that this is the one feature that would get me to switch.  So if there is a plan in place for f-spot to do the same - please let us know - otherwise if SHotwell seems stable and f-spot doesn't do video you will probably see a big userbase switch, myself included.

Perhaps Bugzilla is not the place to post me-toos, but as I consider this ticket to be an RFE :
I fully concur with comment #80 (and previous comments since the opening of this ticket, in 2005).

A/V recording has been a consumer camera feature for years ; F-Spot should at least provide import and GUI placeholders for this data, as otherwise data loss (wiping cards without having transferred all data) may and will occur.

While it is unfortunate, I want to make clear that I have no plans to further develop this feature. First of all, I have other, higher-priority commitments, and second it seems F-Spot development in general has stalled. Ruben, I appreciate your offer for quicker responses, and hopefully if someone else picks up this patch they can take you up on the offer.

I have moved on to Shotwell instead, no crashes and already supports movies!

F-Spot has moved to https://github.com/f-spot/f-spot/issues

If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub.

Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.