GNOME Bugzilla – Bug 164776
fullscreen mode quirks
Last modified: 2005-02-07 23:00:05 UTC
"Exit Fullscreen" should be "Leave Fullscreen" as per HIG, should be in the top-right corner instead of bottom-left where it obscurs the thumbnail sidebar, and use the new stock_leave-fullscreen stock icon from g-i-t instead of GTK_STOCK_QUIT. If you agree, I'm going to provide a patch.
Sounds good, I'm unsure about the position though... ccing Bryan
Ok, the stock icon update sounds good. I'm hesitant about the positioning since two apps that I like and use very much (Epiphany and Totem) both have the 'Exit Fullscreen' on the bottom left. Everything in the guildeline sounds good, however the positioning seems bad, or maybe just not as important as having most apps use the same place. Maybe I should get a hold of Calum and figure out if we really wanted it on the top right and not the bottom left.
In Epiphany we've just changed it to top-right (from bug 153270), since that's what the HIG says...
Ok, I didn't get a hold of Calum, but I checked out the new Epiphany (good work!) and it looks reasonable to put the 'Leave Fullscreen' button in the upper right as part of the toolbar. I suppose we'll run into the same autohide issues. PDF and PS viewers are very often used for presentations so we should think about making the autohide functionality work well too. Thanks!
This is waiting for patches from the awesome chpe :-)
*** Bug 165794 has been marked as a duplicate of this bug. ***
Created attachment 37038 [details] [review] fix This patch does (all the same as Epiphany): - change "Exit Fullscreen" to "Leave Fullscreen" - use the new stock_leave-fullscreen icon from g-i-t - move the popup to top right corner - if toolbar=on, show a "Leave Fullscreen" item in the toolbar to the right, instead of showing the popup - on focus in/out, show/hide the popup as to not show up on other workspaces too It also fixes a bug I noticed while working on this: toggle toolbar off, sidebar on, go fullscreen and activate the sidebar's combo box -> surprise! :)
/* Toolbar icons */ #define EV_STOCK_ZOOM_FIT_WIDTH "ev-zoom-fit-width" +#define EV_STOCK_LEAVE_FULLSCREEN "stock_leave-fullscreen" no space between the defines please. I'm totally sure you missed my nitpicks a lot :P + /* This sucks, but there is no way to have a draw=no, expand=true separator + * in a GtkUIManager-built toolbar. So, just add another toolbar. + */ Did you post a bug about this? It should probably be referenced there. How much would it take to persist chrome in prefs like in epiphany?
Created attachment 37073 [details] [review] Checked in fix for attachment >/* Toolbar icons */ > #define EV_STOCK_ZOOM_FIT_WIDTH "ev-zoom-fit-width" > >+#define EV_STOCK_LEAVE_FULLSCREEN "stock_leave-fullscreen" >no space between the defines please. Fixed. >+ /* This sucks, but there is no way to have a draw=no, expand=true separator >+ * in a GtkUIManager-built toolbar. So, just add another toolbar. >+ */ >Did you post a bug about this? It should probably be referenced there. Filed, it's gtk+ bug 166489. >How much would it take to persist chrome in prefs like in epiphany? Implemented in the updated patch: I now persist the toolbar, statusbar and sidebar toggles to gconf, and read them on startup from there. Schemas file added too.
Comment on attachment 37073 [details] [review] Checked in fix for attachment + <key>/schemas/apps/evince/show_toolbar_bar</key> + <applyto>/apps/evince/show_toolbar/applyto> Looks like you have a wrong _bar suffix in all keys there. Please commit with this fixed, thanks!
Comment on attachment 37073 [details] [review] Checked in fix for attachment I just updated the schema file and commited to fix this error: - <applyto>/apps/evince/show_toolbar/applyto> + <applyto>/apps/evince/show_toolbar</applyto> - <applyto>/apps/evince/show_sidebar/applyto> + <applyto>/apps/evince/show_sidebar</applyto> - <applyto>/apps/evince/show_statusbar/applyto> + <applyto>/apps/evince/show_statusbar</applyto>
Seems like this has all landed in CVS, closing. I guess reopen it if I'm mistaken.