GNOME Bugzilla – Bug 155393
Add "open with" button to gnome-screenshot
Last modified: 2021-05-25 12:37:35 UTC
my user case with gnome-panel-screenshot is: 1.- take an screenshot 2.- Save it on the Desktop 3.- Open with the gimp 4.- Edit it (crop, shadows and so...) 5.- Save again So maybe next patch is useful: If there is one or more applications that can open png files next option is showed: "Save on the desktop and open with [Combo box]" I've choosen to save the "temporal" file in the Desktop (maybe the home dir?) instead of /tmp/gnome-screenshot.324Cj3 because presing save on the image editor should be easier that selecting again a new location (and saving in the default one would be very confusing for the user... "where is the file?")
Created attachment 32607 [details] [review] Patch adding an Open entry
That would be a nice addition, I think. I often save a screenshot and then open the new file with Gimp. Marking as new
*** Bug 98913 has been marked as a duplicate of this bug. ***
Comment on attachment 32607 [details] [review] Patch adding an Open entry >+ command_line = g_strdup_printf ("%s %s", app->command, file); I'm not sure but I think you need to escape file here, or do %s '%s'. >+ applications = gnome_vfs_mime_get_all_applications ("image/png"); >+ if (applications != NULL) { >+ for (p = applications; p != NULL; p = p->next) { It'd be great to use gnome_vfs_mime_get_default_application() to preselect the default application for png.
yup, please take a look at bug #155386 and its dups.
Huum, we need to escape the file, ok. About using gnome_vfs_mime_get_default_application() I don't agree. Just because the default desktop application for images uses to be a image viewer (eog) and what we want here is an image editor. So maybe remembering last selected application and preselecting it is better.
> About using gnome_vfs_mime_get_default_application() I don't agree. Just because > the default desktop application for images uses to be a image viewer (eog) and > what we want here is an image editor. So maybe remembering last selected > application and preselecting it is better. Agree. But the first time, the default application should probably be preselected :-)
I don't really like this way of editing the image. It seems like it would be pretty cluttered, and the dialog is really nice and simple right now. Additionally, you can drag the image straight to the gimp/eog as need be.
Humm, with your new code for adding drop shadows to the window shots the gimp use will be reduced on a 70% (it would it necessary only for cropping big screenshots). BTW IIRC the drop shadow is on by default... next patch would use it only if the --border-efect=shadow or the gconf key is activated: Index: gnome-panel-screenshot.c =================================================================== RCS file: /cvs/gnome/gnome-utils/gnome-screenshot/gnome-panel-screenshot.c,v retrieving revision 1.82 diff -u -r1.82 gnome-panel-screenshot.c --- gnome-panel-screenshot.c 10 Nov 2004 06:20:32 -0000 1.82 +++ gnome-panel-screenshot.c 10 Nov 2004 08:53:02 -0000 @@ -53,7 +53,7 @@ static char *last_save_dir = NULL; static char *window_title = NULL; static char *temporary_file = NULL; -static gboolean drop_shadow = TRUE; +static gboolean drop_shadow = FALSE; static gboolean save_immediately = FALSE; /* Options */ @@ -444,6 +444,12 @@ g_free (border_effect); border_effect = border_effect_arg; } + + if (border_effect != NULL && !strcmp (border_effect, "shadow")) + { + drop_shadow = TRUE; + } + if (delay_arg > 0) {
*** Bug 348544 has been marked as a duplicate of this bug. ***
I'd like to suggest that we make this a high priority for gnome-screenshot and then WONTFIX bug 149862, bug 155061, bug 169450, bug 325187 and bug 334063 as something that GIMP does much better.
What I would really like would be the ability to crop the image before saving: I guesstimate that I want to do that, and only that on 70-80% of the screenshots I take, if not more. Something like the crop dialog in gThumb would be perfect for this. Of course this opens something of a Pandoras box as in: if that's in, why not resize, or enhance, or... but at least for me, cropping would definitely do it. And maybe it's not a bad thing either if the really really common cases could be handled without opening any extra applications. It could be put in a discreet menu and the dialog itself would remain almost as clean as before. Anyway, having to open a separate application for the simplest of use cases seems wasteful (especially as it takes quite some time).
I think replicating gimp features is a bad idea. Drop shadows may be in your common workflow, but they aren't in mine. Highlighting areas is though, but adding an option for that increases the complexity more. I think a screenshot helper should be very light and just present a dropdown&button for opening it with an appropriate application.
*** Bug 525878 has been marked as a duplicate of this bug. ***
Making the bug a bit more generic (see bug #525878).
i agree with that report, Comment #11 and Comment #13 : keep the simplicity of gnome-screenshot but allow to directly open the current picture in another application (GIMP or another one) As i wrote in Bug 525878, both Nautilus and Eye of GNOME let the user to easily open the picture within another application through right-clicking Therefore GNOME users may be accustomed to that behaviour Looking back on my own experience, i was surprised to not find that functionality in gnome-screenshot From a GNOME user point of view, there is certain lack of coherence i think
patch does not apply anymore. somebody up to the task of doing this?
I'm not sure if I understand the problem. One can easily Drag & Drop the screenshot from gnome-screenshot to another application like Gimp. Together with the ability to copy the screenshot to the clipboard there are several ways for quickly getting a screenshot into another application without loosing the simplicity of the GUI (elegance in that case IMHO!) if it ain't broke, don't fix it. :)
I - Concerning the initial report by Fernando Herrera and Comment #18 by puntarenas : it is indeed possible to drag & drop the picture from gnome-screenshot to GIMP or to select in gnome-screenshot "copy to clipboard" then in GIMP (File menu > Create from Clipboard). But i would still be more efficient in this case to add "open with" (EoG, GIMP...) option through gnome-screenshot contextual menu since user will not have to open GIMP (or whatever) before to drop the image or to select Create from Clipboard. Having applications talking each other (gnome-screenshot saying to GIMP : "hey, GIMP, launch yourself and load that picture!") is a great functionnality from a user point of view, it add consistency to the desktop i think Since that functionality would be brought through gnome-screenshot contextual menu, it would not clutter the interface nor make gnome-screenshot lost its simplicity. II - What i'm note sure concerning its implementation (if people decide to implement that functionality) is does gnome-screenshot has to save the picture before sending it to another application and how will that be done ? The initial reporter has suggested "Save on the desktop and open with [Combo box]" but some user don't have a desktop (it can be desactivated with gconf-editor and some netbooks offer a launcher instead of the traditional desktop : see Ubuntu Netbook Remix for instance). Instead of that, xdg-user-dirs spec suggest a /home/pictures folder But question for me are : - does gnome-screenshot has to save the picture before sending it to another application ? - does gnome-screenshot has to stay open aftenr sending the picture to another application or should it close itself For the record, see Bug 98913 : Comment #4 from Vincent Untz But it needs to be saved to be opened by the GIMP or EOG, doesn't it? Comment #5 from Jason A. Pfeil Maybe putting a checkbox below the radio buttons that would allow you to open it with an application after it's saved. The application to use could be a dropdown list of the applications that can handle PNGs and defaulting to the default PNG handler. Including an "Other" that would allow you to browse would be good too. A better solution than a two-step save-and-load-in-app would be to allow communication between gtk-based apps to send data between them so that there would not need to be a separate save step...but that is outside the scope of this bug.
*** Bug 632663 has been marked as a duplicate of this bug. ***
*** Bug 641535 has been marked as a duplicate of this bug. ***
+1 for opening screenshot data directly in GIMP. Every Android app does this.
+1 I have to make nearly every day one or more Screenshots at work and mostly have to edit something in the picture like to point something out. So i have to copy the screenshot and then open it myself in Gimp. This is possible but annoying. I can also use shutter but i like Gnome and all of it's components and don't want to have more than one tool installed for the same activity.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/gnome-screenshot/-/issues/ Thank you for your understanding and your help.