After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 155203 - New locations in Germany for gweather
New locations in Germany for gweather
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
git master
Other All
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 151505 (view as bug list)
Depends on:
Blocks: 150905
 
 
Reported: 2004-10-12 16:31 UTC by Martin Kretzschmar
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: 2.10.0
GNOME version: Unversioned Enhancement

Attachments
New locations patch (6.68 KB, patch)
2004-10-12 16:32 UTC, Martin Kretzschmar 		needs-work Details | Review
Updated patch. (10.50 KB, patch)
2004-10-16 16:20 UTC, Martin Kretzschmar 		accepted-commit_now Details | Review

Description Martin Kretzschmar 2004-10-12 16:31:58 UTC 
May I commit this patch that adds some German airports to the locations file?

The patch applies only cleanly, if the patch from bug 155202 was applied.

The resulting Locations.xml.in is xmllint clean ;-)
Comment 1 Martin Kretzschmar 2004-10-12 16:32:55 UTC 
Created attachment 32524 [details] [review]
New locations patch
Comment 2 Danielle Madeley 2004-10-13 01:29:32 UTC 
Comment on attachment 32524 [details] [review]
New locations patch

Assuming the - between Berlin-Schonfeld and Berlin-Tegel are airports or
somesuch, this is now deprecated.

Instead, you can use the <city> tag to have multiple locations. This means you
can have
 Berlin
   - Schonefeld
   - Tegel

etc.

It would be great if you could update your patch to use this as it's now
available in gweather 2.9.
Comment 3 Martin Kretzschmar 2004-10-15 12:22:27 UTC 
Okay, I'll group the locations where possible. While I'm at it, I'll add states
information for Germany.

Is it possible to mix <states> and <city>s outside of <state>s in a country? I.e.

<country>
  <state> ... Bavaria ... </state>
  <city> ... Berlin ... </city>
  <city> ... Hamburg ... </city>
  <state> ... Hessen ... </state>
<country>

(Berlin, Hamburg and Bremen are their own states.)
Comment 4 Vincent Noel 2004-10-15 18:36:24 UTC 
There's another patch to include German cities cooking in bug 151505.
Comment 5 Martin Kretzschmar 2004-10-16 16:20:43 UTC 
Created attachment 32676 [details] [review]
Updated patch.

I added city tags for Berlin and Hamburg.

Additionally I grouped the locations by state (Bundesland) and sometimes
improved the names using information from Wikipedia and http://www.eddh.de
(airport database, it seems).

The patch from bug 151505 had 5 additional cities. weather.noaa.gov returned
only several months old information for those 5 so I added them in comments (so
it's easy to readd them should they ever become active again)
Comment 6 Martin Kretzschmar 2004-10-16 16:25:15 UTC 
*** Bug 151505 has been marked as a duplicate of this bug. ***
Comment 7 Danielle Madeley 2004-10-17 00:55:34 UTC 
Comment on attachment 32676 [details] [review]
Updated patch.

I can't actually test this at the moment.

You should add comments to the commented out cities saying why they are
commented out.

Otherwise this looks fine to commit to HEAD.
Comment 8 Danielle Madeley 2004-10-31 02:34:08 UTC 
What's the status of this?
Comment 9 Martin Kretzschmar 2004-10-31 09:19:36 UTC 
Committed but "someone" forgot to close the bug. Sorry and thanks for the reminder.