After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 155202 - Fix stupid de-umlautization of German locations
Fix stupid de-umlautization of German locations
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
git master
Other All
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: locations-love
 
 
Reported: 2004-10-12 16:25 UTC by Martin Kretzschmar
Modified: 2005-02-08 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that adds back umlauts and uses English city names where possible (99.38 KB, patch)
2004-10-12 16:27 UTC, Martin Kretzschmar
needs-work Details | Review
Patch for Locations.xml.in with comments (and de.po) (3.58 KB, patch)
2004-10-16 16:07 UTC, Martin Kretzschmar
accepted-commit_now Details | Review

Description Martin Kretzschmar 2004-10-12 16:25:06 UTC
A lot of the gweather locations in Germany have umlauts in their names. Their
_names in the Locations.xml.in have not. This is ugly. Here's a patch that adds
the umlauts.

For Cologne, Munich, and Nuremberg I replaced the German names without umlauts
with their English names.

The patch does those substitutions on the po-locations pos as well to minimize
translator work.

May I commit (with ChangeLog entry, of course)?
Comment 1 Martin Kretzschmar 2004-10-12 16:27:21 UTC
Created attachment 32523 [details] [review]
Patch that adds back umlauts and uses English city names where possible
Comment 2 Danielle Madeley 2004-10-13 01:34:26 UTC
Comment on attachment 32523 [details] [review]
Patch that adds back umlauts and uses English city names where possible

I agree, Locations.xml.in should use the US spelling of the city name. The file
should then also include a note for the translators saying:
  <!-- TRANSLATOR: Munich is spelt Munchen locally -->
(I would add the omlaut, but I don't think bugzilla is unicode clean).
 You'll notice messages like this through other parts of the file.

Just submit a patch for Locations.xml.in for now, I don't like approving
patches to the po files, since that's really the translation teams domain,
however a TRANSLATOR comment will make it very easy for them to get it sorted
out.
Comment 3 Martin Kretzschmar 2004-10-16 16:07:00 UTC
Created attachment 32675 [details] [review]
Patch for Locations.xml.in with comments (and de.po)

How about this one: I added the translator comments and the only po file that I
touch is de.po. The German translators know how to reach me if they want to
kick me because I broke the translation.
Comment 4 Danielle Madeley 2004-10-17 00:28:02 UTC
Comment on attachment 32675 [details] [review]
Patch for Locations.xml.in with comments (and de.po)

Ok, this seems fine. Commit this to HEAD. Thanks.
Comment 5 Danielle Madeley 2004-10-30 15:06:39 UTC
What's the status of this?
Comment 6 Martin Kretzschmar 2004-10-31 09:19:25 UTC
Committed but "someone" forgot to close the bug. Sorry and thanks for the reminder.
Comment 7 Christian Rose 2004-12-20 09:56:31 UTC
I noticed there are some new German locations in Locations.xml.in. Some of these
new locations seem to have been mangled to ASCII-only, and would also need
fixing. Hence I'm reopening this bug report.

One example is "Aachen/Merzbruck". Should possibly be "Merzbrück" and assigned
to the city "Aachen".
Also "Grafenwoehr" and "Kuemmersruck" look possibly suspicious, and some others
of these new German locations as well.
Comment 8 Danielle Madeley 2004-12-20 10:18:05 UTC
This will have been caused by the sync with the METAR list. Can someone more
local look at this please?
Comment 9 Danielle Madeley 2005-01-09 08:03:52 UTC
Indeed, some names are garbled. Probably from one of the character encoding
f-ckups I caused.

Attaching this to the Locations Love bug.
Comment 10 Danielle Madeley 2005-02-08 15:12:38 UTC
This should all now be resolved.