GNOME Bugzilla – Bug 135841
gok keyboard layout algorithms incomplete
Last modified: 2004-12-22 21:47:04 UTC
The gok keyboard layout algorithm(s) is(are) not yet part of the regular build. Further required work and consideration: - UI preferences, - different keyboard weightings (e.g. upper left, lower right, center) - testing
David: if you now run gok --keyboard alpha-frequency you'll see that the UPPERL layout isn't working for this keyboard.
raising priority now that we have exposed the frequency-table keyboards in the UI.
I think this has resolved. Bill can you confirm?
It hasn't resolved... the UPPERL layout still isn't implemented: the frequency alpha keyboard attempts to set KEYBOARD_LAYOUR_UPPERL but it doesn't result in layout of keys by scan-order, it still lays them out left-to-right and then top-to-bottom.
Created attachment 27639 [details] [review] small diff to show desired upperl layouts I've got to run off to a meeting, but I thought I would show how to get test out the upperl layout code...
Thanks David. Is there a reason this code was #define'd out? I removed the #ifdef bracketing, then changed gok_main_ds to pass the keyboard's own layout type to gok_keyboard_layout, which seemed to fix the issue. I attach my modified patch; there are some small issues for the future, for instance we assume that frequency keyboards should be laid out in UPPERL which isn't, for isntance, the case for access methods like single-selection.
Created attachment 27650 [details] [review] small patch which may resolve this bug.
It was #defined out because I had wanted to test it more. IIRC the center weighted frequency algorithm isn't implemented yet (although strangely I remember working on it). We could make that a separate bug if you wanted to close this one. The other corner weighted algorithms are just variations of the UPPERL...
I don't see any of the other corner-weighted algorithms yet, but that's fine since our scanning methods all scan RTL/top-to-bottom now anyhow. That's an i18n bug that needs to be filed I suppose. Should we just apply the patch (second one) above, then? And will you do the honors, or shall I?
Done. Thanks Bill.
I believe we can close this bug and leave the center-weighted, etc. layouts in their own RFEs.