GNOME Bugzilla – Bug 133545
gok frequency based compose keyboard modifier needs hookup
Last modified: 2004-12-22 21:47:04 UTC
When trying out the gok_keyboard_get_alpha_by_frequency code path (requires code modification) the resulting compose keyboard doesn't seem to respond to the modifier keys. Trying shift doesn't seem to change the "level" of the label or output...
bumping severity up so it appears on my radar ;)
Created attachment 26093 [details] [review] patch to connect shift modifier to alpha and freq keyboards, and also supply shift keys.
Created attachment 26095 [details] [review] revised patch as committed to cvs. I am committing based on initial review by David - however I'd appreciate it if you'd glance at the final patch (David) as it differs a bit (mostly in the addition of shift/modifier keys to the alpha keyboards themselves). I also added a BackSpace key to these keyboards, on the assumption that a destructive backspace would generally be desirable in this context. There's also a minor correction to the code which creates 'frequency' keyboards - I've given them the correct name ('alpha-frequency'), and pass a KeyboardLayouts argument to the compose keyboard create function, so that the frequency-based keyboard uses UPPERL by default. Note however that the resulting feature isn't working as expected - the keyboard's layout flag seems to be ignored when the keyboard is actually laid out. Perhaps you could revisit the old layout bug? Thanks