After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 88318 - Clean up new window/tab menu items when only one profile exists
Clean up new window/tab menu items when only one profile exists
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
AP4
: 79426 307497 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-07-16 12:14 UTC by Calum Benson
Modified: 2005-09-25 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove the profile submenus in New Window/Tab when they're not needed (10.61 KB, patch)
2003-07-15 00:26 UTC, Mariano Suárez-Alvarez
none Details | Review
Same as before, and make /Terminal/Change Profile insensitive when there is 1 profile (11.84 KB, patch)
2004-07-14 02:59 UTC, Mariano Suárez-Alvarez
none Details | Review

Description Calum Benson 2002-07-16 12:14:12 UTC
When you only have one profile set up (be it the default or otherwise), it
would probably be better if the list of profiles didn't show up on the New
Window and New Tab submenus... right now it looks a bit silly:

   New Window  > Default  Shift+Ctrl+T
                 --
                 1. Default

Alternatively, you could maybe lose the first item altogether, and just
list the shortcut against the current default profile.  So if you only had
one profile you'd get:

   New Window  > 1. Default Shift+Ctrl+T

and for more than one you'd get something like:

   New Window  > 1. Default
                 2. Blue xterm    Shift+Ctrl+T
                 3. Yellow vt100
Comment 1 Havoc Pennington 2002-07-16 12:58:11 UTC
Seems sane.
Comment 2 Luis Villa 2002-07-16 18:46:53 UTC
Duplicate already had the usability keyword set, even :) Wouldn't have
been that hard to find ;) That said, this has more concrete
suggestions so marking that a dup of this.
Comment 3 Luis Villa 2002-07-16 18:47:01 UTC
*** Bug 79426 has been marked as a duplicate of this bug. ***
Comment 4 Seth Nickell 2002-07-16 19:43:14 UTC
As an alternative, have:

New Window
New Window Using Profile->  (bad wording)

The idea is that people who don't use profiles (I'm willing to bet
most people do not use profiles) can completely ignore them.
Comment 5 Calum Benson 2003-04-03 14:53:26 UTC
Updating status_whiteboard field to reflect A11Y team's assessment 
of accessibility impact.
Comment 6 Mariano Suárez-Alvarez 2003-07-15 00:24:26 UTC
Next is a patch implementing Calum's first option: make the New
Window/New Tab menu items not have submenus when there is just one
profile (most probable scenario, I guess)

Calum's second option (dropping the first item in the submenu) look
funny when there is just one profile: submenus having one item are
ugly, IMO.
Comment 7 Mariano Suárez-Alvarez 2003-07-15 00:26:11 UTC
Created attachment 18293 [details] [review]
Remove the profile submenus in New Window/Tab when they're not needed
Comment 8 Havoc Pennington 2003-07-15 04:52:01 UTC
Looks good, I believe this has to wait until we branch gnome-2-4 and 
can put it on HEAD though.
Comment 9 Mariano Suárez-Alvarez 2003-07-19 19:54:42 UTC
This does need updating the docs in Usage/To Open and Close Terminals
section.
Comment 10 Calum Benson 2003-08-07 16:10:03 UTC
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME
bug list :)
Comment 11 alexander.winston 2004-02-07 23:50:11 UTC
This would be great to apply soon . . . But do we have to wait because
of that feature freeze thing?
Comment 12 Mariano Suárez-Alvarez 2004-02-08 00:21:29 UTC
We can get this in, being it ui-reviewish, I guess.
The only reason it's not commiteted, in fact, is that iirc the HUG
does not like menus coming and going that much: 

Calum, is this patch really better than the status quo?
Comment 13 Calum Benson 2004-02-09 13:43:35 UTC
Probably not a big enough deal to be throwing in at the last minute,
anyway-- I'd be happy enough to wait or discuss it more if there are
any concerns about it.  (Having a submenu with just one item is kind
of sucky as well, after all...)
Comment 14 Elijah Newren 2004-03-10 21:53:32 UTC
I'm adding the BLOCKED_BY_FREEZE keyword, but I hesitate some because
of Calum's comments about extra discussion.  Someone feel free to
remove it if they feel that this isn't close enough to being appliable
after the next thaw.
Comment 15 Mariano Suárez-Alvarez 2004-07-14 02:59:04 UTC
Pinging Calum and other u7y people for comments...

Not putting the submenus is definitely the best for people not using profiles,
though.

Now that I think of it, too, I should make the Change Profile item in the
Terminal menu insensitive when there is just one profile.
Comment 16 Mariano Suárez-Alvarez 2004-07-14 02:59:54 UTC
Created attachment 29523 [details] [review]
Same as before, and make /Terminal/Change Profile insensitive when there is 1 profile
Comment 17 Calum Benson 2004-10-21 16:43:59 UTC
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs.
 Filter on "SUN A11Y SPAM" to ignore.
Comment 18 Elijah Newren 2004-12-20 23:13:29 UTC
blocked by freeze definitely doesn't apply right now...  :-)
Comment 19 Olav Vitters 2005-07-01 21:45:54 UTC
*** Bug 307497 has been marked as a duplicate of this bug. ***
Comment 20 Kjartan Maraas 2005-09-25 15:31:48 UTC
I commited this to HEAD.