After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791361 - Allow to go back to playlist via mouse click from album view
Allow to go back to playlist via mouse click from album view
Status: RESOLVED DUPLICATE of bug 771934
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2017-12-07 19:25 UTC by kevin
Modified: 2017-12-19 11:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
moidif on window.py (1.51 KB, patch)
2017-12-07 19:25 UTC, kevin
needs-work Details | Review

Description kevin 2017-12-07 19:25:47 UTC
Created attachment 365212 [details] [review]
moidif on window.py

Backbutton with mouse when we are on album to back to playlist . ( gamers mouse )
Comment 1 André Klapper 2017-12-08 04:38:57 UTC
What is "moidif"? What is not working with "backbutton mouse from album"? What is this ticket about?
Comment 2 kevin 2017-12-08 14:16:02 UTC
Hello 
Is not really a bug , is a extension for the page Album like the Alt+Left. With this patch we can back with a clic (gamers mouse)
Comment 3 Marinus Schraal 2017-12-19 10:23:06 UTC
Review of attachment 365212 [details] [review]:

Your commit message is lacking (see https://wiki.gnome.org/Git/CommitMessages).
libgd should not be part of your patch.

My main problem here is the specific mapping of button 8. Why this button? What button is it exactly? Seems rather device/user specific.

I'm not sure we can accept this.

::: gnomemusic/window.py
@@ +323,3 @@
         self._key_press_event_id = self.connect('key_press_event', self._on_key_press)
+        
+        self.button_press_event_id = self.connect('button_press_event', self.button_press)

This var should be internal (prepend with _), but is unused anyway.

@@ +401,3 @@
     @log
+    
+    def button_press(self,widget,event):

This function should be internal (prepend with _).

@@ +404,3 @@
+        #Go Back from Album with mouse button 
+        if (event.button == 8):
+            if (self.toolbar._state != ToolbarState.MAIN):

This can be one conditional (if x AND y).
Comment 4 Marinus Schraal 2017-12-19 11:08:08 UTC

*** This bug has been marked as a duplicate of bug 771934 ***