GNOME Bugzilla – Bug 787845
VPN menu is always visible
Last modified: 2018-01-10 09:12:26 UTC
The VPN submenu is always visible, even if I don’t have any VPN connections, or even any VPN software installed. gnome-shell-3.26.0-1.fc27.x86_64
I think this regression was introduced by commit f2a9467f91b2d34c5b8d7a653ff14562e2210015 which removed the _sync function, which set the actor visibility. > - _sync: function() { > - let nItems = this._connectionItems.size; > - this.item.actor.visible = (nItems > 0);
Created attachment 366465 [details] [review] network: Fix visibility of VPN section Commit f2a9467f91b was too eager to simplify the code, and removed the bits that hid the section in case no VPNs are set up - add them back to fix the visibility. Gah, I had the fix sitting around locally and forgot to attach it :-(
Review of attachment 366465 [details] [review]: lgtm
Attachment 366465 [details] pushed as f91fbd7 - network: Fix visibility of VPN section