After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772287 - Brightness and volume overlays jitter horizontally when changing values above 50%
Brightness and volume overlays jitter horizontally when changing values above...
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
triaged
: 772625 774088 774369 778546 782011 792023 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-10-01 12:21 UTC by Daniel Boles
Modified: 2021-07-05 14:04 UTC
See Also:
GNOME target: ---
GNOME version: 3.21/3.22


Attachments
screencast (482.60 KB, video/webm)
2016-10-01 12:21 UTC, Daniel Boles
  Details
osdWindow: always round-up sizes when updating allocation (990 bytes, patch)
2016-10-11 00:03 UTC, Cosimo Cecchi
committed Details | Review
Screenshot of OSD (1.15 MB, image/png)
2017-11-15 19:23 UTC, Kadir
  Details
volume overlay jittering (116.93 KB, video/webm)
2017-11-15 20:09 UTC, Alessandro Bono
  Details
Jitter at 1920x1200 (246.77 KB, video/webm)
2017-11-20 17:41 UTC, Kadir
  Details
osdWindow: change the centering calculation (1.87 KB, patch)
2018-06-06 11:03 UTC, slatchurie
none Details | Review

Description Daniel Boles 2016-10-01 12:21:30 UTC
Created attachment 336725 [details]
screencast

The title and attached screen recording basically say it all.

The square overlays showing the new value for brightness or volume change their horizontal location slightly each time the value is changed - if and only if it's being changed to/from something above 50%. When changing between values at/below 50%, the overlay stays in the same position, as it should.

fwiw, I don't recall this happening before, so either (A) my memory is rubbish (very likely), or (B) it's a new thing that just started happening in the last day or 2.
Comment 1 Florian Müllner 2016-10-08 20:24:48 UTC
*** Bug 772625 has been marked as a duplicate of this bug. ***
Comment 2 Cosimo Cecchi 2016-10-11 00:03:20 UTC
Created attachment 337381 [details] [review]
osdWindow: always round-up sizes when updating allocation

This fixes the OSD window flickering horizontally at certain
resolutions.
Comment 3 Florian Müllner 2016-10-11 00:14:18 UTC
Review of attachment 337381 [details] [review]:

OK
Comment 4 Cosimo Cecchi 2016-10-11 00:25:33 UTC
Attachment 337381 [details] pushed as f819654 - osdWindow: always round-up sizes when updating allocation
Comment 5 Florian Müllner 2016-11-08 16:32:00 UTC
*** Bug 774088 has been marked as a duplicate of this bug. ***
Comment 6 Florian Müllner 2016-11-13 17:36:36 UTC
*** Bug 774369 has been marked as a duplicate of this bug. ***
Comment 7 Kadir 2017-11-15 19:23:46 UTC
Created attachment 363743 [details]
Screenshot of OSD

Hi, since Gnome 3.24 (Fedora 26) and Gnome 3.26 (Fedora 27), I also experience the same bug on all of my machines. The volume and brightness OSD jitters above 50%.

This happens on my laptop (1366x768), my desktop (1920x1200) and my work setup (dual monitors, dual 1920x1200). I also tested this with Ubuntu 17.10, with the same result. 

I have no extensions running, just a vanilla Gnome 3.26 setup on all of my machines.

Besides the jitter, I also have a graphic issue since Gnome 3.22, see the attachment. This grahical glitch ONLY happens when animations are ON. When the animations are OFF, the graphical glitch does not happen, just the jitter.
Comment 8 Kadir 2017-11-15 19:32:03 UTC
BTW, my shell version is:

gnome-shell.x86_64   3.26.2-1.fc27
Comment 9 Daniel Boles 2017-11-15 19:58:33 UTC
You should reopen this bug if you can still demonstrate the same problem. A video of your system would be good to confirm it's likely the exact same thing.

For the other issue - which ideally would have a textual description too, but presumably is incorrect placement/clipping of the graphics? - you should open a new bug report.
Comment 10 Alessandro Bono 2017-11-15 20:09:12 UTC
Created attachment 363759 [details]
volume overlay jittering

(In reply to Daniel Boles from comment #9)
> You should reopen this bug if you can still demonstrate the same problem. A
> video of your system would be good to confirm it's likely the exact same
> thing.

I have the same problem with Fedora 27. A screencast is attached.
Comment 11 Kadir 2017-11-15 20:26:33 UTC
(In reply to Daniel Boles from comment #9)
> For the other issue - which ideally would have a textual description too,
> but presumably is incorrect placement/clipping of the graphics? - you should
> open a new bug report.

Thank you, I have opened that bug here: https://bugzilla.gnome.org/show_bug.cgi?id=790413
Comment 12 Daniel Boles 2017-11-19 20:37:27 UTC
(In reply to Kadir from comment #8)
> BTW, my shell version is:
> 
> gnome-shell.x86_64   3.26.2-1.fc27

Conversely, I haven't seen this reoccur yet, and I'm currently on Debian with gnome-shell_3.26.2-1_amd64.deb (and X, fwiw)
Comment 13 Lionel Landwerlin 2017-11-19 20:40:18 UTC
I can still see this issue on 3.26.2.
Comment 14 Kadir 2017-11-20 17:41:06 UTC
Created attachment 364064 [details]
Jitter at 1920x1200

With a freshly installed and fully updated Fedora 27 install (with gnome-shell.x86_64 version 3.26.2-1.fc27), I see the jitter above 50%. The system is a desktop with a monitor resolution of 1920x1200.

No extensions, shell/gtk themes or icon themes installed, a fully stock system.
Comment 15 Daniel Boles 2017-11-20 19:10:11 UTC
I wrote a big post with my versions of gjs, libmozjs, etc. Then discarded it by accident. :|

Suffice it to say the machine in question, which does not exhibit the jitter, is running Debian unstable, fully up-to-date as of yesterday, on a 1920x1080 screen with scaling 1, font size 10, the stock theme, and a handful of the standard extensions turned on.
Comment 16 Florian Müllner 2017-12-29 09:55:41 UTC
*** Bug 792023 has been marked as a duplicate of this bug. ***
Comment 17 Florian Müllner 2018-04-13 14:48:13 UTC
*** Bug 778546 has been marked as a duplicate of this bug. ***
Comment 18 Daniel van Vugt 2018-06-05 09:19:37 UTC
Please see attachment 352891 [details] [review] in bug 782011 for a potential fix.
Comment 19 slatchurie 2018-06-06 11:03:50 UTC
Created attachment 372570 [details] [review]
osdWindow: change the centering calculation

The current method relies on Clutter.ActorAlign.CENTER.
But it doesn't take into account the new size of the OSD, and
another calculation has to be made to correct it.
When the level bar is wide enough, a jitter of 1px can appear
from the difference between the two centering methods.

This moves the centering calculation from the screen actor to the
constraint box of the OSD.
Comment 20 Florian Müllner 2018-07-11 11:10:46 UTC
*** Bug 782011 has been marked as a duplicate of this bug. ***
Comment 21 Daniel van Vugt 2018-07-26 03:38:04 UTC
Downstream: https://launchpad.net/bugs/1692394
Comment 22 Jonas Ådahl 2018-07-26 09:56:42 UTC
slatchurie, could you turn this into a merge request on gitlab?
Comment 23 Florian Müllner 2018-08-23 19:24:56 UTC
It's possible that the issue has been fixed in https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/2, as the level bar is (once again) a custom drawn actor instead of a fill-level actor inside a trough actor.
Comment 24 Lionel Landwerlin 2018-08-23 21:05:30 UTC
I can still reproduce on 3.28.3, I can't really tell what version that merge request ended up in.
Comment 25 Florian Müllner 2018-08-23 21:12:59 UTC
Sorry I haven't been more clear. The merge request wasn't about this issue at all, but about implementing a feature - it just happened that the involved refactoring touched (and replaced) the code that was previously identified to cause the jiggling, which is why it's possible that the issue is fixed.

But being a larger patch set that involves UI changes and refactoring, we are talking about an unstable change (3.29.90 to be precise).
Comment 26 GNOME Infrastructure Team 2021-07-05 14:04:23 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of  gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/

Thank you for your understanding and your help.